mbox series

[00/17] staging: r8188eu: clean up mlme handlers

Message ID 20221024081417.66441-1-martin@kaiser.cx
Headers
Series staging: r8188eu: clean up mlme handlers |

Message

Martin Kaiser Oct. 24, 2022, 8:14 a.m. UTC 
  This series cleans up the mlme handlers that process incoming management
frames.

We can reorder the handler functions and remove forward declarations. We
can also remove unused return values and simplify the error handling.

This series should be applied after the "some more small cleanups" series.

As usual, this series was tested with EdimaxV2 on an arm32 system.

Martin Kaiser (17):
  staging: r8188eu: restructure mlme subfunction handling
  staging: r8188eu: make OnAssocReq static
  staging: r8188eu: make OnAssocRsp static
  staging: r8188eu: make OnProbeReq static
  staging: r8188eu: make OnProbeRsp static
  staging: r8188eu: make OnBeacon static
  staging: r8188eu: make OnDisassoc static
  staging: r8188eu: make OnAuthClient static
  staging: r8188eu: make OnDeAuth static
  staging: r8188eu: make OnAction static
  staging: r8188eu: make OnAuth static
  staging: r8188eu: change mlme handlers to void
  staging: r8188eu: remove unnecessary label
  staging: r8188eu: remove unnecessary else branch
  staging: r8188eu: remove unnecessary return
  staging: r8188eu: remove an else branch
  staging: r8188eu: go2asoc is not needed

 drivers/staging/r8188eu/core/rtw_mlme_ext.c   | 226 ++++++++----------
 .../staging/r8188eu/include/rtw_mlme_ext.h    |  23 +-
 2 files changed, 100 insertions(+), 149 deletions(-)

Comments

Philipp Hortmann Oct. 24, 2022, 5:43 p.m. UTC | #1 
On 10/24/22 10:14, Martin Kaiser wrote:
> This series cleans up the mlme handlers that process incoming management
> frames.
> 
> We can reorder the handler functions and remove forward declarations. We
> can also remove unused return values and simplify the error handling.
> 
> This series should be applied after the "some more small cleanups" series.
> 
> As usual, this series was tested with EdimaxV2 on an arm32 system.
> 
> Martin Kaiser (17):
>    staging: r8188eu: restructure mlme subfunction handling
>    staging: r8188eu: make OnAssocReq static
>    staging: r8188eu: make OnAssocRsp static
>    staging: r8188eu: make OnProbeReq static
>    staging: r8188eu: make OnProbeRsp static
>    staging: r8188eu: make OnBeacon static
>    staging: r8188eu: make OnDisassoc static
>    staging: r8188eu: make OnAuthClient static
>    staging: r8188eu: make OnDeAuth static
>    staging: r8188eu: make OnAction static
>    staging: r8188eu: make OnAuth static
>    staging: r8188eu: change mlme handlers to void
>    staging: r8188eu: remove unnecessary label
>    staging: r8188eu: remove unnecessary else branch
>    staging: r8188eu: remove unnecessary return
>    staging: r8188eu: remove an else branch
>    staging: r8188eu: go2asoc is not needed
> 
>   drivers/staging/r8188eu/core/rtw_mlme_ext.c   | 226 ++++++++----------
>   .../staging/r8188eu/include/rtw_mlme_ext.h    |  23 +-
>   2 files changed, 100 insertions(+), 149 deletions(-)
> 
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> # Edimax N150