mbox series

[v3,0/3] thermal: qcom: tsens: small fixup for debugfs

Message ID 20221022125657.22530-1-ansuelsmth@gmail.com
Headers
Series thermal: qcom: tsens: small fixup for debugfs |

Message

Christian Marangi Oct. 22, 2022, 12:56 p.m. UTC 
  This is a small series to fixup some bug in how tsens init debufs.

The first patch just handle situation where tsens fails to register and
debugfs are getting registred anyway. When tsens is tried to reprobe
debugs will print a warning as the directory are already there.

The second patch is a fixup for wrong version when the ancient VER_0 is
used.

The third patch is a rework of debugfs structure moving version in the
tsens istance instead of ignoring any other tsens istance if it will
ever be the case in the future of having multiple tsens instance with
different version. It's just futureproof on it's own and also removed
one additional check.

changes v3:
- remove extra space from patch 1
- split patch 2 to 2 different patch
- patch 3 rework wrong debugfs structure
changes v2:
- Changed sob name to new one.

(the resend was actually v2 but i totally forgot that I sent it as v2 with
the sob name fixed... but everything should be good now...)

Christian Marangi (3):
  thermal: qcom: tsens: init debugfs only with successful probe
  thermal: qcom: tsens: fix wrong version id dbg_version_show
  thermal: qcom: tsens: rework debugfs file structure

 drivers/thermal/qcom/tsens.c | 23 +++++++++--------------
 1 file changed, 9 insertions(+), 14 deletions(-)

Comments

Daniel Lezcano Oct. 22, 2022, 4:26 p.m. UTC | #1 
On 22/10/2022 14:56, Christian Marangi wrote:
> This is a small series to fixup some bug in how tsens init debufs.
> 
> The first patch just handle situation where tsens fails to register and
> debugfs are getting registred anyway. When tsens is tried to reprobe
> debugs will print a warning as the directory are already there.
> 
> The second patch is a fixup for wrong version when the ancient VER_0 is
> used.
> 
> The third patch is a rework of debugfs structure moving version in the
> tsens istance instead of ignoring any other tsens istance if it will
> ever be the case in the future of having multiple tsens instance with
> different version. It's just futureproof on it's own and also removed
> one additional check.
> 
> changes v3:
> - remove extra space from patch 1
> - split patch 2 to 2 different patch
> - patch 3 rework wrong debugfs structure
> changes v2:
> - Changed sob name to new one.
> 
> (the resend was actually v2 but i totally forgot that I sent it as v2 with
> the sob name fixed... but everything should be good now...)
> 
> Christian Marangi (3):
>    thermal: qcom: tsens: init debugfs only with successful probe
>    thermal: qcom: tsens: fix wrong version id dbg_version_show
>    thermal: qcom: tsens: rework debugfs file structure
> 
>   drivers/thermal/qcom/tsens.c | 23 +++++++++--------------
>   1 file changed, 9 insertions(+), 14 deletions(-)

Applied thanks