[v12,00/46] KVM: x86: hyper-v: Fine-grained TLB flush + L2 TLB flush features

Message ID 20221021153521.1216911-1-vkuznets@redhat.com
Headers
Series KVM: x86: hyper-v: Fine-grained TLB flush + L2 TLB flush features |

Message

Vitaly Kuznetsov Oct. 21, 2022, 3:34 p.m. UTC
  Changes since v11:
- Don't export kvm_vcpu_flush_tlb_guest() and don't call it from
 kvm_hv_vcpu_flush_tlb(), these are just leftovers from older versions
 [Sean]
- Correctly adjust data_offset/consumed_xmm_halves in kvm_hv_flush_tlb()
 in 'all_cpus' case. Leave a comment about the fact that it is 
(theoretically) possible to meet non-zero 'var_cnt'.
- Don't use ternary operator in kvm_hv_send_ipi() [Sean]
- Don't inject GP in kvm_hv_hypercall_complete() [Sean]
- Fix various asserts in PV IPI/PV TLB flush selftests [Sean]
- Add a check that L2 has exited due to NMI to 'evmcs_test' [Sean]
- Rebase to the latest kvm/queue [e18d6152ff0f]

Original description:

Currently, KVM handles HVCALL_FLUSH_VIRTUAL_ADDRESS_LIST{,EX} requests
by flushing the whole VPID and this is sub-optimal. This series introduces
the required mechanism to make handling of these requests more 
fine-grained by flushing individual GVAs only (when requested). On this
foundation, "Direct Virtual Flush" Hyper-V feature is implemented. The 
feature allows L0 to handle Hyper-V TLB flush hypercalls directly at
L0 without the need to reflect the exit to L1. This has at least two
benefits: reflecting vmexit and the consequent vmenter are avoided + L0
has precise information whether the target vCPU is actually running (and
thus requires a kick).

Sean Christopherson (7):
  x86/hyperv: Move VMCB enlightenment definitions to hyperv-tlfs.h
  KVM: selftests: Move "struct hv_enlightenments" to x86_64/svm.h
  KVM: SVM: Add a proper field for Hyper-V VMCB enlightenments
  x86/hyperv: KVM: Rename "hv_enlightenments" to
    "hv_vmcb_enlightenments"
  KVM: x86: Move clearing of TLB_FLUSH_CURRENT to
    kvm_vcpu_flush_tlb_all()
  KVM: x86: hyper-v: Add helper to read hypercall data for array
  KVM: selftests: Drop helpers to read/write page table entries

Vitaly Kuznetsov (39):
  KVM: x86: Rename 'enable_direct_tlbflush' to 'enable_l2_tlb_flush'
  KVM: VMX: Rename "vmx/evmcs.{ch}" to "vmx/hyperv.{ch}"
  KVM: x86: hyper-v: Resurrect dedicated KVM_REQ_HV_TLB_FLUSH flag
  KVM: x86: hyper-v: Introduce TLB flush fifo
  KVM: x86: hyper-v: Handle HVCALL_FLUSH_VIRTUAL_ADDRESS_LIST{,EX} calls
    gently
  KVM: x86: hyper-v: Expose support for extended gva ranges for flush
    hypercalls
  KVM: x86: Prepare kvm_hv_flush_tlb() to handle L2's GPAs
  x86/hyperv: Introduce
    HV_MAX_SPARSE_VCPU_BANKS/HV_VCPUS_PER_SPARSE_BANK constants
  KVM: x86: hyper-v: Use
    HV_MAX_SPARSE_VCPU_BANKS/HV_VCPUS_PER_SPARSE_BANK instead of raw
    '64'
  KVM: x86: hyper-v: Don't use sparse_set_to_vcpu_mask() in
    kvm_hv_send_ipi()
  KVM: x86: hyper-v: Create a separate fifo for L2 TLB flush
  KVM: x86: hyper-v: Use preallocated buffer in 'struct kvm_vcpu_hv'
    instead of on-stack 'sparse_banks'
  KVM: nVMX: Keep track of hv_vm_id/hv_vp_id when eVMCS is in use
  KVM: nSVM: Keep track of Hyper-V hv_vm_id/hv_vp_id
  KVM: x86: Introduce .hv_inject_synthetic_vmexit_post_tlb_flush()
    nested hook
  KVM: x86: hyper-v: Introduce kvm_hv_is_tlb_flush_hcall()
  KVM: x86: hyper-v: L2 TLB flush
  KVM: x86: hyper-v: Introduce fast guest_hv_cpuid_has_l2_tlb_flush()
    check
  KVM: nVMX: hyper-v: Cache VP assist page in 'struct kvm_vcpu_hv'
  KVM: nVMX: hyper-v: Enable L2 TLB flush
  KVM: x86: Make kvm_hv_get_assist_page() return 0/-errno
  KVM: nSVM: hyper-v: Enable L2 TLB flush
  KVM: x86: Expose Hyper-V L2 TLB flush feature
  KVM: selftests: Better XMM read/write helpers
  KVM: selftests: Move HYPERV_LINUX_OS_ID definition to a common header
  KVM: selftests: Move the function doing Hyper-V hypercall to a common
    header
  KVM: selftests: Hyper-V PV IPI selftest
  KVM: selftests: Fill in vm->vpages_mapped bitmap in virt_map() too
  KVM: selftests: Export vm_vaddr_unused_gap() to make it possible to
    request unmapped ranges
  KVM: selftests: Hyper-V PV TLB flush selftest
  KVM: selftests: Sync 'struct hv_enlightened_vmcs' definition with
    hyperv-tlfs.h
  KVM: selftests: Sync 'struct hv_vp_assist_page' definition with
    hyperv-tlfs.h
  KVM: selftests: Move Hyper-V VP assist page enablement out of evmcs.h
  KVM: selftests: Split off load_evmcs() from load_vmcs()
  KVM: selftests: Create a vendor independent helper to allocate Hyper-V
    specific test pages
  KVM: selftests: Allocate Hyper-V partition assist page
  KVM: selftests: evmcs_test: Introduce L2 TLB flush test
  KVM: selftests: hyperv_svm_test: Introduce L2 TLB flush test
  KVM: selftests: Rename 'evmcs_test' to 'hyperv_evmcs'

 arch/x86/include/asm/hyperv-tlfs.h            |  37 +
 arch/x86/include/asm/kvm-x86-ops.h            |   2 +-
 arch/x86/include/asm/kvm_host.h               |  42 +-
 arch/x86/include/asm/svm.h                    |   7 +-
 arch/x86/kvm/Makefile                         |   5 +-
 arch/x86/kvm/hyperv.c                         | 346 +++++++--
 arch/x86/kvm/hyperv.h                         |  64 +-
 arch/x86/kvm/svm/hyperv.c                     |  18 +
 arch/x86/kvm/svm/hyperv.h                     |  50 +-
 arch/x86/kvm/svm/nested.c                     |  49 +-
 arch/x86/kvm/svm/svm.c                        |   7 +
 arch/x86/kvm/svm/svm.h                        |   5 +-
 arch/x86/kvm/svm/svm_onhyperv.c               |   8 +-
 arch/x86/kvm/svm/svm_onhyperv.h               |  25 +-
 arch/x86/kvm/trace.h                          |  21 +-
 arch/x86/kvm/vmx/{evmcs.c => hyperv.c}        |  45 +-
 arch/x86/kvm/vmx/{evmcs.h => hyperv.h}        |  12 +-
 arch/x86/kvm/vmx/nested.c                     |  43 +-
 arch/x86/kvm/vmx/vmx.c                        |   7 +-
 arch/x86/kvm/vmx/vmx_ops.h                    |   2 +-
 arch/x86/kvm/x86.c                            |  36 +-
 include/asm-generic/hyperv-tlfs.h             |   5 +
 include/asm-generic/mshyperv.h                |  11 +-
 tools/testing/selftests/kvm/.gitignore        |   4 +-
 tools/testing/selftests/kvm/Makefile          |   5 +-
 .../selftests/kvm/include/kvm_util_base.h     |   1 +
 .../selftests/kvm/include/x86_64/evmcs.h      |  48 +-
 .../selftests/kvm/include/x86_64/hyperv.h     | 102 +++
 .../selftests/kvm/include/x86_64/processor.h  |  76 +-
 .../selftests/kvm/include/x86_64/svm.h        |  26 +-
 .../selftests/kvm/include/x86_64/vmx.h        |   8 -
 tools/testing/selftests/kvm/lib/kvm_util.c    |   9 +-
 .../testing/selftests/kvm/lib/x86_64/hyperv.c |  46 ++
 .../selftests/kvm/lib/x86_64/processor.c      |  21 +-
 tools/testing/selftests/kvm/lib/x86_64/vmx.c  |  45 +-
 .../kvm/x86_64/emulator_error_test.c          |   6 +-
 .../x86_64/{evmcs_test.c => hyperv_evmcs.c}   |  71 +-
 .../selftests/kvm/x86_64/hyperv_features.c    |  25 +-
 .../testing/selftests/kvm/x86_64/hyperv_ipi.c | 314 ++++++++
 .../selftests/kvm/x86_64/hyperv_svm_test.c    |  86 ++-
 .../selftests/kvm/x86_64/hyperv_tlb_flush.c   | 690 ++++++++++++++++++
 41 files changed, 2074 insertions(+), 356 deletions(-)
 create mode 100644 arch/x86/kvm/svm/hyperv.c
 rename arch/x86/kvm/vmx/{evmcs.c => hyperv.c} (95%)
 rename arch/x86/kvm/vmx/{evmcs.h => hyperv.h} (95%)
 create mode 100644 tools/testing/selftests/kvm/lib/x86_64/hyperv.c
 rename tools/testing/selftests/kvm/x86_64/{evmcs_test.c => hyperv_evmcs.c} (72%)
 create mode 100644 tools/testing/selftests/kvm/x86_64/hyperv_ipi.c
 create mode 100644 tools/testing/selftests/kvm/x86_64/hyperv_tlb_flush.c
  

Comments

Sean Christopherson Oct. 26, 2022, 10:28 p.m. UTC | #1
On Fri, Oct 21, 2022, Vitaly Kuznetsov wrote:
>   KVM: selftests: evmcs_test: Introduce L2 TLB flush test
>   KVM: selftests: hyperv_svm_test: Introduce L2 TLB flush test

Except for these two (patches 44 and 45),

Reviewed-by: Sean Christopherson <seanjc@google.com>
  
Sean Christopherson Oct. 26, 2022, 10:31 p.m. UTC | #2
On Wed, Oct 26, 2022, Sean Christopherson wrote:
> On Fri, Oct 21, 2022, Vitaly Kuznetsov wrote:
> >   KVM: selftests: evmcs_test: Introduce L2 TLB flush test
> >   KVM: selftests: hyperv_svm_test: Introduce L2 TLB flush test
> 
> Except for these two (patches 44 and 45),
> 
> Reviewed-by: Sean Christopherson <seanjc@google.com>

Actually, easiest thing is probably for Paolo to queue everything through 43
(with a comment in patch 13 about the GPA translation), and then you can send a
new version containing only the stragglers.
  
Vitaly Kuznetsov Oct. 31, 2022, 9:18 a.m. UTC | #3
Sean Christopherson <seanjc@google.com> writes:

> On Wed, Oct 26, 2022, Sean Christopherson wrote:
>> On Fri, Oct 21, 2022, Vitaly Kuznetsov wrote:
>> >   KVM: selftests: evmcs_test: Introduce L2 TLB flush test
>> >   KVM: selftests: hyperv_svm_test: Introduce L2 TLB flush test
>> 
>> Except for these two (patches 44 and 45),
>> 
>> Reviewed-by: Sean Christopherson <seanjc@google.com>

Thanks! I'll take a look at 44/45 shortly.

>
> Actually, easiest thing is probably for Paolo to queue everything through 43
> (with a comment in patch 13 about the GPA translation), and then you can send a
> new version containing only the stragglers.

Paolo,

do you want to follow this path or do you expect the full 'v13' from me?
  
Vitaly Kuznetsov Nov. 1, 2022, 2:54 p.m. UTC | #4
Vitaly Kuznetsov <vkuznets@redhat.com> writes:

>
> Paolo,
>
> do you want to follow this path or do you expect the full 'v13' from me? 

v13 it is :-) I've added all the tags and addressed the remaining
feedback (a typo fixed + a comment added).