From patchwork Fri Oct 21 13:11:46 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Morse X-Patchwork-Id: 483 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4242:0:0:0:0:0 with SMTP id s2csp690371wrr; Fri, 21 Oct 2022 06:13:11 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4xYjZBs3kVjITumB3f5MB+djTMPulUkwFYyVFNAi0hwPsbwXHMwQ70ZernjR+sAJ05KX54 X-Received: by 2002:a65:6a0d:0:b0:464:4fff:2991 with SMTP id m13-20020a656a0d000000b004644fff2991mr15721179pgu.506.1666357990948; Fri, 21 Oct 2022 06:13:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666357990; cv=none; d=google.com; s=arc-20160816; b=vHyVnd6z31ortWJDyzmNATCJYD+ZQ0YsCMs8OMpaTjCtJm1PR+g6fvYRepla3QU7Mi +FHf2gIpWMloXht+DhazPye7NWGu4A4sWQuyB5ngI/HWz9MEpSv4CrAL8dHms9fFTySx QN5Y6/ssBe/0m3ZV7ldg+gVcPjRXHaa8qP3mp9tVV7EZhrey3sWrcVDwnTypkpMYWa6o 9/QCtuqP42l+YXqEkRoJfpabjpO9d4Lji5Vh7evKLafZBpZcbajczRykq+g5rvrj2W2l 5rNRhZ/ZPuqKm9TQCY6TTjALp08hn797L+XqwlF7w9YmrzfsRKpSco+RBytMDqVIoD0H +aGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=2N8dotwJF3Lhzae+cliz9/qgwLOBpXDZmBaczMcwfeA=; b=cAnUnL17Pv7wQe9Hzfh2ZKPvbfWpQwhTIcoGCLGuv/mZzckD3dsem9XB/8103x9weL XnwddUWaVHDAzTBvkGpb7yrcBTHoyW9TOmghZyt4dTPoT3i/3ESLc3uWs8DufOsOjrcu tuVg93h1w0xP82paOloGb3j5pe8L+uBDTxVIpm9N/4Zd1Cm4T88G1pN8dEU9D3LjR3nN amn/tJt4z80T95GprkmlJrEAus5AV9dXCU8QpM4TNn9jmMOcGVH6pNrI/Lk6/VPYtUKl eNttFv5nrKzf7aXAJcmacdbMzJj0ar7EXC7QMPumAiE/G32ozLI1HL/ZVomZkPdI0HmH 8J8g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q3-20020a170902eb8300b00174c5fdc8d2si23518296plg.307.2022.10.21.06.12.55; Fri, 21 Oct 2022 06:13:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230211AbiJUNMh (ORCPT + 99 others); Fri, 21 Oct 2022 09:12:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35570 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230087AbiJUNMe (ORCPT ); Fri, 21 Oct 2022 09:12:34 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 7308524E42C for ; Fri, 21 Oct 2022 06:12:22 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C45511042; Fri, 21 Oct 2022 06:12:27 -0700 (PDT) Received: from merodach.members.linode.com (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 21F0C3F792; Fri, 21 Oct 2022 06:12:19 -0700 (PDT) From: James Morse To: x86@kernel.org, linux-kernel@vger.kernel.org Cc: Fenghua Yu , Reinette Chatre , Thomas Gleixner , Ingo Molnar , Borislav Petkov , H Peter Anvin , Babu Moger , James Morse , shameerali.kolothum.thodi@huawei.com, D Scott Phillips OS , carl@os.amperecomputing.com, lcherian@marvell.com, bobo.shaobowang@huawei.com, tan.shaopeng@fujitsu.com, Jamie Iles , Xin Hao , xingxin.hx@openanolis.org, baolin.wang@linux.alibaba.com, peternewman@google.com Subject: [PATCH 00/18] x86/resctrl: monitored closid+rmid together, separate arch/fs locking Date: Fri, 21 Oct 2022 13:11:46 +0000 Message-Id: <20221021131204.5581-1-james.morse@arm.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747302996897036112?= X-GMAIL-MSGID: =?utf-8?q?1747302996897036112?= Hello! This series does two things, it changes resctrl to call resctrl_arch_rmid_read() in a way that works for MPAM, and it separates the locking so that the arch code and filesystem code don't have to share a mutex. I tried to split this as two series, but these touch similar call sites, so it would create more work. (What's MPAM? See the cover letter of the first series. [1]) On x86 the RMID is an independent number. MPAMs equivalent is PMG, but this isn't an independent number - it extends the PARTID (same as CLOSID) space with bits that aren't used to select the configuration. The monitors can then be told to match specific PMG values, allowing monitor-groups to be created. But, MPAM expects the monitors to always monitor by PARTID. The Cache-storage-utilisation counters can only work this way. (In the MPAM spec not setting the MATCH_PARTID bit is made CONSTRAINED UNPREDICTABLE - which is Arm's term to mean portable software can't rely on this) It gets worse, as some SoCs may have very few PMG bits. I've seen the datasheet for one that has a single bit of PMG space. To be usable, MPAM's counters always need the PARTID and the PMG. For resctrl, this means always making the CLOSID available when the RMID is used. To ensure RMID are always unique, this series combines the CLOSID and RMID into an index, and manages RMID based on that. For x86, the index and RMID would always be the same. Currently the architecture specific code in the cpuhp callbacks takes the rdtgroup_mutex. This means the filesystem code would have to export this lock, resulting in an ill-defined interface between the two, and the possibility of cross-architecture lock-ordering head aches. The second part of this series adds a domain_list_lock to protect writes to the domain list, and protects the domain list with RCU - or read_cpus_lock(). This series is based on v6.1-rc1, and can be retrieved from: https://git.kernel.org/pub/scm/linux/kernel/git/morse/linux.git mpam/monitors_and_locking/v1 Bugs welcome, Thanks, James [1] https://lore.kernel.org/lkml/20210728170637.25610-1-james.morse@arm.com/ James Morse (18): x86/resctrl: Track the closid with the rmid x86/resctrl: Access per-rmid structures by index x86/resctrl: Create helper for RMID allocation and mondata dir creation x86/resctrl: Move rmid allocation out of mkdir_rdt_prepare() x86/resctrl: Allow RMID allocation to be scoped by CLOSID x86/resctrl: Allow the allocator to check if a CLOSID can allocate clean RMID x86/resctrl: Move CLOSID/RMID matching and setting to use helpers x86/resctrl: Queue mon_event_read() instead of sending an IPI x86/resctrl: Allow resctrl_arch_rmid_read() to sleep x86/resctrl: Allow arch to allocate memory needed in resctrl_arch_rmid_read() x86/resctrl: Make resctrl_mounted checks explicit x86/resctrl: Move alloc/mon static keys into helpers x86/resctrl: Make rdt_enable_key the arch's decision to switch x86/resctrl: Add helpers for system wide mon/alloc capable x86/resctrl: Add cpu online callback for resctrl work x86/resctrl: Allow overflow/limbo handlers to be scheduled on any-but cpu x86/resctrl: Add cpu offline callback for resctrl work x86/resctrl: Separate arch and fs resctrl locks arch/x86/include/asm/resctrl.h | 83 ++++++ arch/x86/kernel/cpu/resctrl/core.c | 71 ++--- arch/x86/kernel/cpu/resctrl/ctrlmondata.c | 19 +- arch/x86/kernel/cpu/resctrl/internal.h | 24 +- arch/x86/kernel/cpu/resctrl/monitor.c | 333 ++++++++++++++++------ arch/x86/kernel/cpu/resctrl/pseudo_lock.c | 15 +- arch/x86/kernel/cpu/resctrl/rdtgroup.c | 298 +++++++++++++------ include/linux/resctrl.h | 15 +- 8 files changed, 623 insertions(+), 235 deletions(-) Tested-by: Shaopeng Tan