mbox series

[0/3] squashfs: fix some regressions introduced in the readahead code

Message ID 20221020223616.7571-1-phillip@squashfs.org.uk
Headers
Series squashfs: fix some regressions introduced in the readahead code |

Message

Phillip Lougher Oct. 20, 2022, 10:36 p.m. UTC 
  Hi,

This patch-set fixes 3 regressions introduced by the recent readahead code.
The first regression is causing "snaps" to randomly fail after a couple of
hours or days, which how the regression came to light.

----------------------------------------------------------------
Phillip Lougher (3):
      squashfs: fix read regression introduced in readahead code
      squashfs: fix extending readahead beyond end of file
      squashfs: fix buffer release race condition in readahead code

 fs/squashfs/file.c       | 23 ++++++++++++++---------
 fs/squashfs/page_actor.c |  3 +++
 fs/squashfs/page_actor.h |  6 +++++-
 3 files changed, 22 insertions(+), 10 deletions(-)

Comments

Bagas Sanjaya Oct. 21, 2022, 12:42 p.m. UTC | #1 
On Thu, Oct 20, 2022 at 11:36:13PM +0100, Phillip Lougher wrote:
> Hi,
> 
> This patch-set fixes 3 regressions introduced by the recent readahead code.
> The first regression is causing "snaps" to randomly fail after a couple of
> hours or days, which how the regression came to light.
> 
> ----------------------------------------------------------------
> Phillip Lougher (3):
>       squashfs: fix read regression introduced in readahead code
>       squashfs: fix extending readahead beyond end of file
>       squashfs: fix buffer release race condition in readahead code
> 
>  fs/squashfs/file.c       | 23 ++++++++++++++---------
>  fs/squashfs/page_actor.c |  3 +++
>  fs/squashfs/page_actor.h |  6 +++++-
>  3 files changed, 22 insertions(+), 10 deletions(-)

The regression goes away with this series, thanks.

For the series,

Tested-by: Bagas Sanjaya <bagasdotme@gmail.com>
Andrew Morton Oct. 22, 2022, 10:56 p.m. UTC | #2 
On Sat, 22 Oct 2022 03:38:01 +0200 Mirsad Goran Todorovac <mirsad.todorovac@alu.unizg.hr> wrote:

> Please consider crediting Marc Miltenberger, who was first to reproduce 
> and confirm that the
> bug was not in my build but in mainline kernel.

Thanks, Marc.  I've added your Reported-by: to my copies of the
three patches.