From patchwork Thu Oct 20 19:44:55 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 441 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4242:0:0:0:0:0 with SMTP id s2csp294378wrr; Thu, 20 Oct 2022 12:51:53 -0700 (PDT) X-Google-Smtp-Source: AMsMyM44fr+S+Qn3PJncPGx6pegE5KiYYG2Nfpfl/0KfJKVEuNGM5OjK4f4TKN3CIvG7epxWLNLD X-Received: by 2002:a17:902:bf46:b0:179:eba5:90ba with SMTP id u6-20020a170902bf4600b00179eba590bamr15576362pls.16.1666295513214; Thu, 20 Oct 2022 12:51:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666295513; cv=none; d=google.com; s=arc-20160816; b=k8tScJet/5NVpyjxADNvIBT21XywByQO6ahTj/qNeRqZAoimHyj6zk01Hwd6w9tGoj h1oyMB/wdxlO7bV2vWrYaw43Z0uNLBJWtRGLLQ3/On8zRPWP6jRTDAJCbGSEevFZNoFf GddiTl64Z/7aJqN4tfDtJcixCW1qeNM7qyPQSNXjuzf62dcChi++xmZOU/LTXzSI+7/f BInoyxacUIb3Ul1XQ49oXSAehu7ltYEFvGTG49tjVbbt4GPJceagVrQv0CL/S4DOu57l pbTSXTnDAa4QU35DZpiAbe8+1w5dWlcVKohfM+7gzHfty9Mwmh4GELV7UD53d+eaOPpc 0iQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=BFvTbCU+3vWvQ4lhRiprIrS5FtwaR6sLqkvSBbuIhrk=; b=hkTy/zU52hL+EowIOkdmaeHbgKs5m+OSwi8FUzDbfzq4jtZw/V853TkMRiwgROxcXm ubvEMTFkB8Qv3o87MktNMI5GqRM4x3TeONT5CIOTb4kN/jB92r5ji3CFJNXFUdtKWRU+ Irgy3m6p22q0VpGcxfCAifEctnY/XxzGbOqCWUUuByl4liHjGzpU03mF4GjZxwzGJhus 7prJJvaW7WfCQfKTmE9Hag/in/9Y7oFZdUw3MgGtlBtYgZjA5ca/ewa/BzhrgHzG6hHu JxV+3yTzgUIzR5GHz0lTNycddiA2Ftw/7SIqeCp++qX7Y5W4on3CL38wSeZ0m6E2YzHl RgIg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=buXWpudE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u17-20020a170902e81100b00178b6dfc03fsi27208225plg.40.2022.10.20.12.51.40; Thu, 20 Oct 2022 12:51:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=buXWpudE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230054AbiJTToy (ORCPT + 99 others); Thu, 20 Oct 2022 15:44:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43164 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230020AbiJTToq (ORCPT ); Thu, 20 Oct 2022 15:44:46 -0400 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 340083C8FF; Thu, 20 Oct 2022 12:44:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666295085; x=1697831085; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=cDRbvPGMB4daHpf4H0/xcqTeuiVnp6lHkMnNi54s/1I=; b=buXWpudEq7k8plZFKn/EZuw/i588rwx0xQi5IXWqkLQhLmuQW5ENLTbs BZOAAqANxExccZo0VK2xK+w3WVb48LfB8o9YUvbVgBWSoy2Q6LzHr5nrl r1JH5D+Unt9I8prI9HZuheURQ1Go1RQW9slliUQiXdFSD/l8exb4WBHqf +iLpXvdR6tAZRSDF0UHNwd7yhTblTpyi17fQUxY4Qh/0FMU/VZqNptoAg dLAZH2pHr5Cm2iWlYIP5ZU3rikA52T8EIZ52XdrIW4czoBeiExtNFMBB1 wMZEUVJjQbuz6Vh69ldQdReLfa7WwViiz/lGswM2tXSsPilvvv6rTZJ62 A==; X-IronPort-AV: E=McAfee;i="6500,9779,10506"; a="305559079" X-IronPort-AV: E=Sophos;i="5.95,199,1661842800"; d="scan'208";a="305559079" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Oct 2022 12:44:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10506"; a="630031800" X-IronPort-AV: E=Sophos;i="5.95,199,1661842800"; d="scan'208";a="630031800" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga002.jf.intel.com with ESMTP; 20 Oct 2022 12:44:42 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id DA0E3107; Thu, 20 Oct 2022 22:45:03 +0300 (EEST) From: Andy Shevchenko To: Andy Shevchenko , linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Daniel Mack , Haojian Zhuang , Robert Jarzmik , Mark Brown Subject: [PATCH v4 0/5] spi: pxa2xx: Pass the SSP type via device property Date: Thu, 20 Oct 2022 22:44:55 +0300 Message-Id: <20221020194500.10225-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747224956882539098?= X-GMAIL-MSGID: =?utf-8?q?1747237484002508798?= Currently the SPI PXA2xx devices on Intel platforms can be instantiated via the following paths: 1) as ACPI LPSS device on Haswell, Bay Trail and Cherry Trail; 2) as ACPI LPSS device on the Sky Lake and newer; 3) as PCI LPSS device on Haswell, Bay Trail and Cherry Trail; 4) as PCI LPSS device on the Sky Lake and newer; 5) as PCI device via ID table. Each of these cases provides some platform related data differently, i.e.: 1) via drivers/acpi/acpi_lpss.c and drivers/spi/spi-pxa2xx.c 2) via drivers/mfd/intel-lpss-acpi.c 3) via drivers/spi/spi-pxa2xx-pci.c 4) via drivers/mfd/intel-lpss-pci.c and drivers/spi/spi-pxa2xx.c 5) via drivers/spi/spi-pxa2xx-pci.c This approach has two downsides: a) there is no data propagated in the case #2 because we can't have two or more drivers to match the same ACPI ID and hence some cases are still not supported (Sky Lake and newer ACPI enabled LPSS); b) the data is duplicated over two drivers in the cases #1 & #4 and, besides to be a bloatware, it is error prone (e.g. Lakefield has a wrong data right now due to missed PCI entry in the spi-pxa2xx.c). This series fixes the downsides, and enables previously unsupported cases. On top of that it has a couple of cleanups (patches 4 and 5). Changelog v4: - apply the property only for known MFD enumerated devices (Mark) Changelog v3: - added tags to patches 4 & 5 (Jonathan) - massaged cover letter Changelog v2: - added cover letter (Mark) - dropped applied patch Andy Shevchenko (5): spi: pxa2xx: Respect Intel SSP type given by a property spi: pxa2xx: Remove no more needed PCI ID table spi: pxa2xx: Move OF and ACPI ID tables closer to their user spi: pxa2xx: Consistently use dev variable in pxa2xx_spi_init_pdata() spi: pxa2xx: Switch from PM ifdeffery to pm_ptr() drivers/spi/spi-pxa2xx.c | 186 ++++++++----------------------------- include/linux/pxa2xx_ssp.h | 1 + 2 files changed, 41 insertions(+), 146 deletions(-)