From patchwork Thu Oct 20 16:26:26 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 435 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4242:0:0:0:0:0 with SMTP id s2csp206181wrr; Thu, 20 Oct 2022 09:32:46 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5cCgBhOlh8W9MwmEMk7l55P1qfZussPOeDAw1P2gQFI8Y6y9deNmFDlAFE37i67cIS5wZI X-Received: by 2002:a17:907:a05:b0:77b:b538:6476 with SMTP id bb5-20020a1709070a0500b0077bb5386476mr11974881ejc.324.1666283566413; Thu, 20 Oct 2022 09:32:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666283566; cv=none; d=google.com; s=arc-20160816; b=WZQRxtLHKsslBtQiuf3PTF5QfFx1tgPZsUrkBXWd4mpHVh1XzTRgaYWBhCJXVcaZ+6 ecB4Ombm8KOUYcdb52OhkOoSpV6cpZuFaO+dII8udpnJPhK/NI+LIBl7NVBlC2h4Hgzr t/v3RRMa2QYX0vjEId/MSAuvjH9asGUP6MW6T7hUynKSqGByGsVtViKez9q6DlEiUv6J YzgM1NFnEcM1pGKFzjOTHPNV2aYa1UzgVPeCODW3mHgZ4uFBEOmWRMAewlPlbYwvxld/ bauhrfqQCV/XRub7kWH6vn3JSc4Okfi3otFMExnKslUlbDTyzDi0c+4KZjfLB5B9yW/U C6Zg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=TA5qcLGSk+RvOXWJqEJcLQGNThpe0FDJ20E8nIuLby4=; b=hnVs1+U8xm33qKHed97WbrjZ+vVtwITUbS/FBVXd943IJYo+IeWJTUaOAxVhG9JE03 OIQeRyKFJJW2ex4QCUaVazQhsc7p9LgYH7fLW8vyIT/SR4jtxwq3Q7FfRazl4xCiF2MR SUstBQUDjdiIw5aFnvUzUWKrbEsgmt/wKH+S0T5ppBSorfEomcNi/0lPRKsX69UoGtvX WzXK9dkrZaI0gqOENdbTNKKUlByR8RU3wbatqUmCm+WctMkw2ERj78H8wMcYQ0DXzCQV dnhWA9Rxp1gsEhgBycmOvozfxpEyQSiFT7tVmGmaW3u2KB5yocM1vltwaxWTT2VMaDHg Cyrw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=FhUfgggr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id fg10-20020a056402548a00b00459ff7667b4si15101358edb.203.2022.10.20.09.32.16; Thu, 20 Oct 2022 09:32:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=FhUfgggr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229828AbiJTQ00 (ORCPT + 99 others); Thu, 20 Oct 2022 12:26:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38804 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229784AbiJTQ0V (ORCPT ); Thu, 20 Oct 2022 12:26:21 -0400 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 922A16392; Thu, 20 Oct 2022 09:26:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666283178; x=1697819178; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=L1PpsyQD3YIK+QP7eDAPlt7fNZIEOmcOxOCOyV/CAlg=; b=FhUfgggrV43MyhyaVgEEf7+W26+vyJiWjcDG8VQwQvzbqNoEy3PCvEok Jq3+iqz8BjwZajyg+s3oflBiwL4+FFb3IK2yuVqmLcWgQP14jndXlMLWb gTVl17mcmpw5zK2LnAdWkVJI29RBUmFgNRhrv7iLEjrxte8B/TbfpGJiD 2e3arBjQFbXdDTjVLkyGc9HvMCycsS2t8Gx8cb7wYhV493CedTPDHyGVG 1K6fOWiUyDnm+4hcht+EYx3NOuTG28K/yH+L7eYFuZ5uf+f+v3NRjadzM rRUYOAlM23CVWg336795ff8ptvyv6PkKB8tXZOmEH0kml9MWh9yS2ZjDv g==; X-IronPort-AV: E=McAfee;i="6500,9779,10506"; a="287164938" X-IronPort-AV: E=Sophos;i="5.95,199,1661842800"; d="scan'208";a="287164938" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Oct 2022 09:26:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10506"; a="581004363" X-IronPort-AV: E=Sophos;i="5.95,199,1661842800"; d="scan'208";a="581004363" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga003.jf.intel.com with ESMTP; 20 Oct 2022 09:26:11 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id A2394291; Thu, 20 Oct 2022 19:26:32 +0300 (EEST) From: Andy Shevchenko To: Andy Shevchenko , linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Daniel Mack , Haojian Zhuang , Robert Jarzmik , Mark Brown Subject: [PATCH v3 0/5] spi: pxa2xx: Pass the SSP type via device property Date: Thu, 20 Oct 2022 19:26:26 +0300 Message-Id: <20221020162631.68914-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747224956882539098?= X-GMAIL-MSGID: =?utf-8?q?1747224956882539098?= Currently the SPI PXA2xx devices on Intel platforms can be instantiated via the following paths: 1) as ACPI LPSS device on Haswell, Bay Trail and Cherry Trail; 2) as ACPI LPSS device on the Sky Lake and newer; 3) as PCI LPSS device on Haswell, Bay Trail and Cherry Trail; 4) as PCI LPSS device on the Sky Lake and newer; 5) as PCI device via ID table. Each of these cases provides some platform related data differently, i.e.: 1) via drivers/acpi/acpi_lpss.c and drivers/spi/spi-pxa2xx.c 2) via drivers/mfd/intel-lpss-acpi.c 3) via drivers/spi/spi-pxa2xx-pci.c 4) via drivers/mfd/intel-lpss-pci.c and drivers/spi/spi-pxa2xx.c 5) via drivers/spi/spi-pxa2xx-pci.c This approach has two downsides: a) there is no data propagated in the case #2 because we can't have two or more drivers to match the same ACPI ID and hence some cases are still not supported (Sky Lake and newer ACPI enabled LPSS); b) the data is duplicated over two drivers in the cases #1 & #4 and, besides to be a bloatware, it is error prone (e.g. Lakefield has a wrong data right now due to missed PCI entry in the spi-pxa2xx.c). This series fixes the downsides, and enables previously unsupported cases. On top of that it has a couple of cleanups (patches 4 and 5). Changelog v3: - added tags to patches 4 & 5 (Jonathan) - massaged cover letter Changelog v2: - added cover letter (Mark) - dropped applied patch Andy Shevchenko (5): spi: pxa2xx: Respect Intel SSP type given by a property spi: pxa2xx: Remove no more needed PCI ID table spi: pxa2xx: Remove no more needed driver data spi: pxa2xx: Move OF and ACPI ID tables closer to their user spi: pxa2xx: Switch from PM ifdeffery to pm_ptr() drivers/spi/spi-pxa2xx.c | 170 +++++++------------------------------ include/linux/pxa2xx_ssp.h | 1 + 2 files changed, 30 insertions(+), 141 deletions(-)