From patchwork Wed Oct 19 00:12:59 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 311 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp48258wrs; Tue, 18 Oct 2022 17:14:56 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5bRE9qgzzxJZWJ/TN84amMcouN4ya9/GDz69PWr+2C1Z4CqeTlSqYg1diVCLpXKTiJPv+K X-Received: by 2002:a05:6402:5191:b0:45c:dea0:2c7 with SMTP id q17-20020a056402519100b0045cdea002c7mr4790758edd.239.1666138496129; Tue, 18 Oct 2022 17:14:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666138496; cv=none; d=google.com; s=arc-20160816; b=woedkjm5yAOwY2NWNhIyCcBoCJdv2JA7aXMkflQzTH7xIZ9bQwLO7deTstSuy9wPt6 Qds2X93XrLlqx7xWJoJtrvCT3qNMbGkQ7caVKFVDhpkTbKf+uaTHYg4ceqMQsJiI0KVW Bl1fzR9NrFW4SiWPf7+zNcqBbDjYmgEIs8aTbKdzU77/tk8CzfiXu26pgJ3OxqQQyMhK vIxh1HmBtHYGvpWGX9YrkcB5D921UazN614Xxl/me9ppSQOkZI3VepcKbBW7N51JoleP vZ0c1ArGdP2Gl9RsywdzuEPZC7V66DxFdVFnT1rtZQ/C9uBMi2Jw4RLz/M6Vo1ljgdEL TXAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=6mNEdwOCmEa/+jS90ZxeNQmY7kOd+AQChBRnVfie79U=; b=bM3aaYUzzeu3bsK8ImiQoqkrYUzKsczFqRpUnuhIq3P/1SkUjqPNUV1Q1xm/lvj7x/ 0ApZ9EsrolXSaHKz92dkUAHJGPDZn8bIz2KTu6r8aJ3Qew0Z7DR09NR37oPYOh0BRl9J lrIEy8+yeI1RPh6aN16BArKIzY7NBcTD4Zx7CB9Y5tbYjRmOknbCf7q8mXUE9hymqZ9f 8tHPBmnN3EDQ9C0znu/8pbHb4GXHRoMFtDQQNbTNZFkWY6a5DPTlDt60uyrcgGZKyp6F 8moJwZlOg/MHoq1OcgX0wvtqi6mwfuDrm9PEjxmfeO91pYZopCpMtDzRUd/F6lCodyU/ MCdg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=AMx1r4qT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qk38-20020a1709077fa600b00774195db4e7si13466554ejc.117.2022.10.18.17.14.31; Tue, 18 Oct 2022 17:14:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=AMx1r4qT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229834AbiJSANd (ORCPT + 99 others); Tue, 18 Oct 2022 20:13:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57746 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229680AbiJSAN0 (ORCPT ); Tue, 18 Oct 2022 20:13:26 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46620D0CF8; Tue, 18 Oct 2022 17:13:25 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E8C96B821A0; Wed, 19 Oct 2022 00:13:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1B0B0C433C1; Wed, 19 Oct 2022 00:13:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666138402; bh=dpOBk5cVjdXzz1IhM8jwMTCjeK/vMf8lWOrAu4uF1nI=; h=From:To:Cc:Subject:Date:From; b=AMx1r4qTE/UyPgLZgfR5w8EvSMa0cCZcRacr+T37GLPlvpDnrsV5EV9anW1tduwEz E6qFwNNegxjwQfGq52tzTQEUHmCJmMXqBgslB+xe2jyWfYYx3alV7HZOhemXyeDxxe mWa9vG4ErR4W5SQunrbc/Dv3iz7DUuoqAbErw+08cKG3Bzmt/Ni3FRsH47s4pNBxnH pvthyGj5RJV4PpHP3r3fSx/0rOZKHXYNUmdIfGoJRg+haHcBvQNzpLj9Esi4wQXLer zT1o6Sp/8DsxgnftipgRl55GRnS6LFt2QkVAvSmDPGrszWcGiuz5e9TlxgEExCzrVf DGpbnHIXrQ4ug== From: SeongJae Park To: Andrew Morton , Jonathan Corbet , SeongJae Park Cc: damon@lists.linux.dev, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [RFC PATCH 00/18] efficiently expose damos action tried regions information Date: Wed, 19 Oct 2022 00:12:59 +0000 Message-Id: <20221019001317.104270-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747072840042714480?= X-GMAIL-MSGID: =?utf-8?q?1747072840042714480?= DAMON users can retrieve the monitoring results via 'after_aggregation' callbacks if the user is using the kernel API, or 'damon_aggregated' tracepoint if the user is in the user space. Those are useful if full monitoring results are necessary. However, if the user has interest in only some regions having specific access pattern, the interfaces could be inefficient. For example, some DAMOS users might want to know exactly what regions were identified as fulfilling the access pattern of the scheme, for a debugging or a tuning. This patchset implements DAMON kernel API callbacks and sysfs directory for efficient exposure of the information. The new callback will be called for each region before specific DAMOS action is gonna tried to be applied. The sysfs directory will be called 'tried_regions' and placed under each scheme sysfs directory. User can write a special keyworkd, 'update_schemes_regions' to the 'state' file of a kdamond sysfs directory. Then, DAMON sysfs interface will fill the directory with the information of regions that corresponding scheme action was tried to be applied for one aggregation interval. Patches Sequence ---------------- First five patches (1-5) clean up and refactor code that following patch will touch, and the following one (patch 6) implements the DAMON callback for DAMON kernel API users. Following six patches (7-12) clean up and refactor the sysfs interface before the new sysfs directory introduction. Following two patches (13 and 14) implement the sysfs directories, and successing two patches (15 and 16) implement the special keyword for 'state' to fill and clean up the directories. Finally, two more patches (17 and 18) for the documentation of the usage and ABI follow. Assembled Tree -------------- This patchset is based on the latest mm-unstable tree[1]. Assembled tree is also available at the damon/next tree[2]. [1] https://git.kernel.org/akpm/mm/h/mm-unstable [2] https://git.kernel.org/sj/h/damon/next SeongJae Park (18): mm/damon/modules: deduplicate init steps for DAMON context setup mm/damon/core: split out DAMOS-charged region skip logic into a new function mm/damon/core: split damos application logic into a new function mm/damon/core: split out scheme stat update logic into a new function mm/damon/core: split out scheme quota adjustment logic into a new function mm/damon/core: add a DAMON callback for scheme target regions check mm/damon/sysfs: Use damon_addr_range for regions' start and end values mm/damon/sysfs: remove parameters of damon_sysfs_region_alloc() mm/damon/sysfs: move sysfs_lock to common module mm/damon/sysfs: move unsigned long range directory to common module mm/damon/sysfs: split out kdamond-independent schemes stats update logic into a new function mm/damon/sysfs: move schemes directory implementation to separate module mm/damon/sysfs-schemes: implement schemes/tried_regions directory mm/damon/sysfs-schemes: implement scheme region directory mm/damon/sysfs: implement DAMOS-tried regions update command mm/damon/sysfs-schemes: implement DAMOS tried regions clear command Docs/admin-guide/mm/damon/usage: document schemes//tried_regions directory Docs/ABI/damon: document 'schemes//tried_regions' directory .../ABI/testing/sysfs-kernel-mm-damon | 32 + Documentation/admin-guide/mm/damon/usage.rst | 44 +- include/linux/damon.h | 5 + mm/damon/Makefile | 6 +- mm/damon/core.c | 259 ++-- mm/damon/lru_sort.c | 17 +- mm/damon/modules-common.c | 42 + mm/damon/modules-common.h | 3 + mm/damon/reclaim.c | 17 +- mm/damon/sysfs-common.c | 107 ++ mm/damon/sysfs-common.h | 56 + mm/damon/sysfs-schemes.c | 1281 +++++++++++++++++ mm/damon/sysfs.c | 1224 ++-------------- 13 files changed, 1813 insertions(+), 1280 deletions(-) create mode 100644 mm/damon/modules-common.c create mode 100644 mm/damon/sysfs-common.c create mode 100644 mm/damon/sysfs-common.h create mode 100644 mm/damon/sysfs-schemes.c