mbox series

[v2,0/2] pinctrl: pinctrl-zynqmp: Revert output-enable and bias-high-impedance support

Message ID 20221017130303.21746-1-sai.krishna.potthuri@amd.com
Headers
Series pinctrl: pinctrl-zynqmp: Revert output-enable and bias-high-impedance support |

Message

Sai Krishna Potthuri Oct. 17, 2022, 1:03 p.m. UTC 
  Having support for output-enable and bias-high-impedance properties
causing system hang with older Xilinx ZynqMP Platform Management Firmware
because there is missing autodetection feature.
When this feature is implemented, support for these two properties should
bring back.

changes in v2:
-> Added stable tree tag in 1/2 and 2/2 patches.

Sai Krishna Potthuri (2):
  Revert "pinctrl: pinctrl-zynqmp: Add support for output-enable and
    bias-high-impedance"
  Revert "dt-bindings: pinctrl-zynqmp: Add output-enable configuration"

 .../devicetree/bindings/pinctrl/xlnx,zynqmp-pinctrl.yaml | 4 ----
 drivers/pinctrl/pinctrl-zynqmp.c                         | 9 ---------
 2 files changed, 13 deletions(-)

Comments

Michal Simek Oct. 17, 2022, 1:13 p.m. UTC | #1 
On 10/17/22 15:03, Sai Krishna Potthuri wrote:
> Having support for output-enable and bias-high-impedance properties
> causing system hang with older Xilinx ZynqMP Platform Management Firmware
> because there is missing autodetection feature.
> When this feature is implemented, support for these two properties should
> bring back.
> 
> changes in v2:
> -> Added stable tree tag in 1/2 and 2/2 patches.
> 
> Sai Krishna Potthuri (2):
>    Revert "pinctrl: pinctrl-zynqmp: Add support for output-enable and
>      bias-high-impedance"
>    Revert "dt-bindings: pinctrl-zynqmp: Add output-enable configuration"
> 
>   .../devicetree/bindings/pinctrl/xlnx,zynqmp-pinctrl.yaml | 4 ----
>   drivers/pinctrl/pinctrl-zynqmp.c                         | 9 ---------
>   2 files changed, 13 deletions(-)
> 

Acked-by: Michal Simek <michal.simek@amd.com>

Thanks,
Michal
Linus Walleij Oct. 18, 2022, 7:51 a.m. UTC | #2 
On Mon, Oct 17, 2022 at 3:03 PM Sai Krishna Potthuri
<sai.krishna.potthuri@amd.com> wrote:

> Having support for output-enable and bias-high-impedance properties
> causing system hang with older Xilinx ZynqMP Platform Management Firmware
> because there is missing autodetection feature.
> When this feature is implemented, support for these two properties should
> bring back.
>
> changes in v2:
> -> Added stable tree tag in 1/2 and 2/2 patches.

Patches applied for fixes!

Thanks for dealing with this, I hope you find a proper way to make
it work with all firmwares.

Yours,
Linus Walleij
Michal Simek Oct. 18, 2022, 8:06 a.m. UTC | #3 
On 10/18/22 09:51, Linus Walleij wrote:
> On Mon, Oct 17, 2022 at 3:03 PM Sai Krishna Potthuri
> <sai.krishna.potthuri@amd.com> wrote:
> 
>> Having support for output-enable and bias-high-impedance properties
>> causing system hang with older Xilinx ZynqMP Platform Management Firmware
>> because there is missing autodetection feature.
>> When this feature is implemented, support for these two properties should
>> bring back.
>>
>> changes in v2:
>> -> Added stable tree tag in 1/2 and 2/2 patches.
> 
> Patches applied for fixes!
> 
> Thanks for dealing with this, I hope you find a proper way to make
> it work with all firmwares.

The way what pmufw team described is that driver will ask firmware if that 
feature is available or not. If yes, the current calls will be made. Maybe we 
could do it via module parameter but this is the cleanest solution for now.

Thanks,
Michal