Message ID | 20221017114705.8277-1-johan+linaro@kernel.org |
---|---|
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp1401189wrs; Mon, 17 Oct 2022 04:52:56 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7hdHk3o1U6AB5EOiViATEtsKPctnREnOvWYug1Io4+IWA1sLvyv98eybFlu7AzoV2RxjPO X-Received: by 2002:a17:90b:1bc5:b0:20d:7bbf:46cc with SMTP id oa5-20020a17090b1bc500b0020d7bbf46ccmr13511952pjb.212.1666007576216; Mon, 17 Oct 2022 04:52:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666007576; cv=none; d=google.com; s=arc-20160816; b=t4ODO7+uGS9aQWOKd3pfj+L5urz23RMeCzQyyD6mBbb022ex6YN7ki/1s0GvoAJyVD 6jYj1vUFDKSOLez5QjNail5nl3kztv37h2IbTq7EPAwXLT2be8HOLPls+91Vrqp8/2oI /JXogE8ILuhnvB485qPZuCEkKYIU+E5vDxCw/2sb3E8E74bzFubKGpNU7StzjKeAurqe oBpS0uzkl2Rckm6n3ltPI16usMiBUK0neSgNsqjOBN+lBsGVGCkmpPEm8BRLbSXCdA2M UNZ8DkU7T9XKgwxt8678ZVUProRBQHmLRz+L0mCRQXMi3eZcr49Qm5dVvcsNgSqtY5HZ WTcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=1i2+KKSBuFvZSoFQFaNq/teT6vFRyVdvTC75zrJXXg4=; b=CsAkpx43DxZm8IhseJr/Lvkpyi5a9tCzO8qwxaFnweqIS5cxId9cu0MmQtksv6xS+5 u7cov3cAWjOFzUuLJaaikdvTAGFDJ6TH3CZW12i5ngQLRdNEHI24pfppuq5oCBQqhn3V tK7zUEfkBPmOYn3c6ZTOOo5Dhr16U0RXmfIzMFGOizDl0EWKoBNF0G+kim0Lxa0tRK25 XUfRQHbannhHL+ntxXreO83Fdf48arkRusBti0UzkshGS5gmD7GaGM7I10B3NlJODbVc ACYHGpg2yXsbL05BGtD2oPjs3k3tkYNILujj3ZPp6NFS3gA2jNfYaMB29RGdwtfRtEu/ Xi/w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ZTMJIIza; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ob9-20020a17090b390900b00202a519f846si17711482pjb.173.2022.10.17.04.52.42; Mon, 17 Oct 2022 04:52:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ZTMJIIza; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230198AbiJQLsE (ORCPT <rfc822;ouuuleilei@gmail.com> + 99 others); Mon, 17 Oct 2022 07:48:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230188AbiJQLsC (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 17 Oct 2022 07:48:02 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E423C53D37; Mon, 17 Oct 2022 04:48:00 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B86496108B; Mon, 17 Oct 2022 11:47:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1D867C433B5; Mon, 17 Oct 2022 11:47:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666007279; bh=XFapxTpHu9EzBGP12vik84DfocOA+gjV/xwOfeyX0eo=; h=From:To:Cc:Subject:Date:From; b=ZTMJIIza9WqAg9FcoVifjPEnqdm5bnc66SfCqoZNzaTiD+1fkBuPWLxLlf5L6KG6f MkbUXlcuWUplEpwvkxVoTOYnF/y29ieEEezT4x4dGDEBq/YQdQ+FFxq9rWqtxmrxvj t5KIS39DnkV2pzhoXXHpiHJrJrRKUGQ+8XWTBKU6S4v6Xn8SpaTIK0OrtDr7b07LQJ 4qM5C6Apu1/zr5C08NCusBgjquR/368GvVOkUgKIjqzk2yNOpNVQHndpgtYTfUjGV6 0bki8l7cajFT3inlnaUe60/CtJpeXgaY/36g7nStoZad+vNu8QeQBxdtWLN3EPv38o 4XMDtDffrE/pQ== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from <johan+linaro@kernel.org>) id 1okOay-0002Az-Ky; Mon, 17 Oct 2022 13:47:48 +0200 From: Johan Hovold <johan+linaro@kernel.org> To: Stanimir Varbanov <svarbanov@mm-sol.com>, Lorenzo Pieralisi <lpieralisi@kernel.org> Cc: Andy Gross <agross@kernel.org>, Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@somainline.org>, Bjorn Helgaas <bhelgaas@google.com>, Rob Herring <robh+dt@kernel.org>, =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= <kw@linux.com>, Manivannan Sadhasivam <mani@kernel.org>, linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold <johan+linaro@kernel.org> Subject: [PATCH v3 0/2] PCI: qcom: Add support for modular builds Date: Mon, 17 Oct 2022 13:47:03 +0200 Message-Id: <20221017114705.8277-1-johan+linaro@kernel.org> X-Mailer: git-send-email 2.37.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1746935560494866955?= X-GMAIL-MSGID: =?utf-8?q?1746935560494866955?= |
Series |
PCI: qcom: Add support for modular builds
|
|
Message
Johan Hovold
Oct. 17, 2022, 11:47 a.m. UTC
Allow the Qualcomm PCIe controller driver to be built as a module, which is useful for multi-platform kernels as well as during development. There's no rush with this, but I figured I'd send an updated version that has been rebased on 6.1-rc1 (where post_deinit() has been removed). I also broke out the qcom_pcie_host_deinit() handler in a separate patch as the host_deinit() callback has now been added to dwc core and can be used to fixes some late-probe error handling. Johan Changes in v3 - rebase on 6.1-rc1 where post_deinit() has been removed - split out host-init error handling - add Stan's ack Changes in v2 - rebase on next-20220720 (adjust context) - add Rob and Mani's reviewed-by tags Johan Hovold (2): PCI: qcom: Fix host-init error handling PCI: qcom: Add support for modular builds drivers/pci/controller/dwc/Kconfig | 2 +- drivers/pci/controller/dwc/pcie-qcom.c | 39 +++++++++++++++++++++++--- 2 files changed, 36 insertions(+), 5 deletions(-)
Comments
On Mon, Oct 17, 2022 at 01:47:03PM +0200, Johan Hovold wrote: > Allow the Qualcomm PCIe controller driver to be built as a module, which > is useful for multi-platform kernels as well as during development. > > There's no rush with this, but I figured I'd send an updated version > that has been rebased on 6.1-rc1 (where post_deinit() has been removed). > > I also broke out the qcom_pcie_host_deinit() handler in a separate patch > as the host_deinit() callback has now been added to dwc core and can be > used to fixes some late-probe error handling. Waiting for the dust to settle on patch 2, does it make sense to merge patch 1 on its own ? Thanks, Lorenzo > Johan > > > Changes in v3 > - rebase on 6.1-rc1 where post_deinit() has been removed > - split out host-init error handling > - add Stan's ack > > Changes in v2 > - rebase on next-20220720 (adjust context) > - add Rob and Mani's reviewed-by tags > > > Johan Hovold (2): > PCI: qcom: Fix host-init error handling > PCI: qcom: Add support for modular builds > > drivers/pci/controller/dwc/Kconfig | 2 +- > drivers/pci/controller/dwc/pcie-qcom.c | 39 +++++++++++++++++++++++--- > 2 files changed, 36 insertions(+), 5 deletions(-) > > -- > 2.37.3 >
On Fri, Jan 13, 2023 at 04:51:13PM +0100, Lorenzo Pieralisi wrote: > On Mon, Oct 17, 2022 at 01:47:03PM +0200, Johan Hovold wrote: > > Allow the Qualcomm PCIe controller driver to be built as a module, which > > is useful for multi-platform kernels as well as during development. > > > > There's no rush with this, but I figured I'd send an updated version > > that has been rebased on 6.1-rc1 (where post_deinit() has been removed). > > > > I also broke out the qcom_pcie_host_deinit() handler in a separate patch > > as the host_deinit() callback has now been added to dwc core and can be > > used to fixes some late-probe error handling. > > Waiting for the dust to settle on patch 2, does it make sense to > merge patch 1 on its own ? > Yeah, that makes sense. Thanks, Mani > Thanks, > Lorenzo > > > Johan > > > > > > Changes in v3 > > - rebase on 6.1-rc1 where post_deinit() has been removed > > - split out host-init error handling > > - add Stan's ack > > > > Changes in v2 > > - rebase on next-20220720 (adjust context) > > - add Rob and Mani's reviewed-by tags > > > > > > Johan Hovold (2): > > PCI: qcom: Fix host-init error handling > > PCI: qcom: Add support for modular builds > > > > drivers/pci/controller/dwc/Kconfig | 2 +- > > drivers/pci/controller/dwc/pcie-qcom.c | 39 +++++++++++++++++++++++--- > > 2 files changed, 36 insertions(+), 5 deletions(-) > > > > -- > > 2.37.3 > >
On Fri, Jan 13, 2023 at 04:51:13PM +0100, Lorenzo Pieralisi wrote: > On Mon, Oct 17, 2022 at 01:47:03PM +0200, Johan Hovold wrote: > > Allow the Qualcomm PCIe controller driver to be built as a module, which > > is useful for multi-platform kernels as well as during development. > > > > There's no rush with this, but I figured I'd send an updated version > > that has been rebased on 6.1-rc1 (where post_deinit() has been removed). > > > > I also broke out the qcom_pcie_host_deinit() handler in a separate patch > > as the host_deinit() callback has now been added to dwc core and can be > > used to fixes some late-probe error handling. > > Waiting for the dust to settle on patch 2, does it make sense to > merge patch 1 on its own ? Sure, please do. I haven't found the time and motivation to reiterate the arguments for why I think blocking patch 2 is misguided, but I'm still confident that anyone reviewing the arguments will reach the same conclusion (e.g. if you want to dig through the archives). I'll get to it eventually. Johan > > Changes in v3 > > - rebase on 6.1-rc1 where post_deinit() has been removed > > - split out host-init error handling > > - add Stan's ack > > > > Changes in v2 > > - rebase on next-20220720 (adjust context) > > - add Rob and Mani's reviewed-by tags > > > > > > Johan Hovold (2): > > PCI: qcom: Fix host-init error handling > > PCI: qcom: Add support for modular builds > > > > drivers/pci/controller/dwc/Kconfig | 2 +- > > drivers/pci/controller/dwc/pcie-qcom.c | 39 +++++++++++++++++++++++--- > > 2 files changed, 36 insertions(+), 5 deletions(-) > > > > -- > > 2.37.3 > >
On Mon, 17 Oct 2022 13:47:03 +0200, Johan Hovold wrote: > Allow the Qualcomm PCIe controller driver to be built as a module, which > is useful for multi-platform kernels as well as during development. > > There's no rush with this, but I figured I'd send an updated version > that has been rebased on 6.1-rc1 (where post_deinit() has been removed). > > I also broke out the qcom_pcie_host_deinit() handler in a separate patch > as the host_deinit() callback has now been added to dwc core and can be > used to fixes some late-probe error handling. > > [...] Applied to pci/qcom, thanks! [1/2] PCI: qcom: Fix host-init error handling https://git.kernel.org/lpieralisi/pci/c/6996d631fa33 Thanks, Lorenzo