mbox series

[v3,0/7] ASoC: codecs: jz4725b: Various improvements and fixes

Message ID 20221016132648.3011729-1-lis8215@gmail.com
Headers
Series ASoC: codecs: jz4725b: Various improvements and fixes |

Message

Siarhei Volkau Oct. 16, 2022, 1:26 p.m. UTC 
  The patchset fixes:
 - Line In path stays powered off during capturing or
   bypass to mixer.
 - incorrectly represented dB values in alsamixer, et al.
 - incorrect represented Capture input selector in alsamixer
   in Playback tab.
 - wrong control selected as Capture Master

The patchset improves:
 - Exposes output stage (post mixer) gain control and makes it new
   Master playback gain, DAC gain was the previous master.
   However, no Master mute now.
 - Exposes all mixer inputs (both Mics, LineIn and DAC) with their
   gain controls.
 - Exposes microphones widgets: single/differential input, boost.

Known issues:
 - Bypass path enablement isn't applied immediately, for make
   things going bit clock needs to be triggered for a bit,
   e.g. by aplay dummy.wav
   It might be a hardware bug, since the bit clock isn't
   declared as required for codec operation.

Tested on:
 - Ritmix RZX-27 (jz4725b).
 - Ritmix RZX-50 (jz4755).

Diff from v2:
 - add microphone widgets

Diff from v1:
 - each change in a separate patch

Tested-by: Siarhei Volkau <lis8215@gmail.com>
Signed-off-by: Siarhei Volkau <lis8215@gmail.com>

Siarhei Volkau (7):
  ASoC: codecs: jz4725b: add missed Line In power control bit
  ASoC: codecs: jz4725b: fix reported volume for Master ctl
  ASoC: codecs: jz4725b: use right control for Capture Volume
  ASoC: codecs: jz4725b: fix capture selector naming
  ASoC: codecs: jz4725b: use right control for Master Playback
  ASoC: codecs: jz4725b: add missed Mixer inputs
  ASoC: codecs: jz4725b: add missed microphone widgets

 sound/soc/codecs/jz4725b.c | 109 +++++++++++++++++++++++++++++++------
 1 file changed, 92 insertions(+), 17 deletions(-)

Comments

Mark Brown Oct. 18, 2022, 11:28 a.m. UTC | #1 
On Sun, 16 Oct 2022 16:26:41 +0300, Siarhei Volkau wrote:
> The patchset fixes:
>  - Line In path stays powered off during capturing or
>    bypass to mixer.
>  - incorrectly represented dB values in alsamixer, et al.
>  - incorrect represented Capture input selector in alsamixer
>    in Playback tab.
>  - wrong control selected as Capture Master
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/7] ASoC: codecs: jz4725b: add missed Line In power control bit
      commit: 1013999b431b4bcdc1f5ae47dd3338122751db31
[2/7] ASoC: codecs: jz4725b: fix reported volume for Master ctl
      commit: 088777bf65b98cfa4b5378119d0a7d49a58ece44
[3/7] ASoC: codecs: jz4725b: use right control for Capture Volume
      commit: 1538e2c8c9b7e7a656effcc6e4e7cfe8c1b405fd
[4/7] ASoC: codecs: jz4725b: fix capture selector naming
      commit: 80852f8268769715db335a22305e81a0c4a38a84
[5/7] ASoC: codecs: jz4725b: use right control for Master Playback
      commit: e6233ee25059de0eeac6ed3d9d49737afdbd5087
[6/7] ASoC: codecs: jz4725b: add missed Mixer inputs
      commit: 616c291820d155cbad258ecae5c7dbca2c01f07f
[7/7] ASoC: codecs: jz4725b: add missed microphone widgets
      commit: 4b192aa09b3c3615c79f8c60704a2efd15e500d0

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
Siarhei Volkau Oct. 20, 2022, 11:58 a.m. UTC | #2 
вт, 18 окт. 2022 г. в 14:28, Mark Brown <broonie@kernel.org>:
> Applied to
>
>    https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
>
> Thanks!

Great! Thank you!

Unfortunately I found a critical bug in my patchset, yet easy to fix.
So I need some help to make and send the fix.

> If any updates are required or you are submitting further changes they
> should be sent as incremental updates against current git, existing
> patches will not be replaced.

What are mailing lists it needs to be sent to?
Any additional tags needed? I know about Fixes tag.
Do I need to keep a link on this patchset somehow?
Do I need to mail a patch with the fix to this thread or
create a new one?

PS: the patch will look like:
 - {"ADC Sourc Capture Routee", "Line In", "Line In"},
 + {"ADC Source Capture Route", "Line In", "Line In"},

Thanks in advance,
Siarhei
Paul Cercueil Oct. 20, 2022, 12:01 p.m. UTC | #3 
Hi Siarhei,

Le jeu., oct. 20 2022 at 14:58:51 +0300, Siarhei Volkau 
<lis8215@gmail.com> a écrit :
> вт, 18 окт. 2022 г. в 14:28, Mark Brown <broonie@kernel.org>:
>>  Applied to
>> 
>>     
>> https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git 
>> for-next
>> 
>>  Thanks!
> 
> Great! Thank you!
> 
> Unfortunately I found a critical bug in my patchset, yet easy to fix.
> So I need some help to make and send the fix.
> 
>>  If any updates are required or you are submitting further changes 
>> they
>>  should be sent as incremental updates against current git, existing
>>  patches will not be replaced.
> 
> What are mailing lists it needs to be sent to?
> Any additional tags needed? I know about Fixes tag.
> Do I need to keep a link on this patchset somehow?
> Do I need to mail a patch with the fix to this thread or
> create a new one?
> 
> PS: the patch will look like:
>  - {"ADC Sourc Capture Routee", "Line In", "Line In"},
>  + {"ADC Source Capture Route", "Line In", "Line In"},

Somebody already submitted a fix.

> Thanks in advance,
> Siarhei

Cheers,
-Paul
Mark Brown Oct. 20, 2022, 12:14 p.m. UTC | #4 
On Thu, Oct 20, 2022 at 02:58:51PM +0300, Siarhei Volkau wrote:
> вт, 18 окт. 2022 г. в 14:28, Mark Brown <broonie@kernel.org>:

> > If any updates are required or you are submitting further changes they
> > should be sent as incremental updates against current git, existing
> > patches will not be replaced.

> What are mailing lists it needs to be sent to?

The same ones as for any other patch submission - alsa-devel in this
case.

> Any additional tags needed? I know about Fixes tag.

No.

> Do I need to keep a link on this patchset somehow?

The fixes tag should be enough.

> Do I need to mail a patch with the fix to this thread or
> create a new one?

Please create a new thread.

> PS: the patch will look like:
>  - {"ADC Sourc Capture Routee", "Line In", "Line In"},
>  + {"ADC Source Capture Route", "Line In", "Line In"},

This was already fixed by Colin...
Siarhei Volkau Oct. 20, 2022, 12:29 p.m. UTC | #5 
чт, 20 окт. 2022 г. в 15:14, Mark Brown <broonie@kernel.org>:
> This was already fixed by Colin...

Wow! Thank you all, guys!