Message ID | 20220815-rpi-fix-4k-60-v3-0-fc56729d11fe@cerno.tech |
---|---|
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp169980wrs; Thu, 13 Oct 2022 02:16:40 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6VkBZ0uycWXOqnVTs5DlsBIxu2FM2L0XLy3SiJOfttG01E8/rg/jkWtmd7Ct/0UAOggV6J X-Received: by 2002:a17:90a:f3c6:b0:20b:3ae:4c40 with SMTP id ha6-20020a17090af3c600b0020b03ae4c40mr9999131pjb.20.1665652600644; Thu, 13 Oct 2022 02:16:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665652600; cv=none; d=google.com; s=arc-20160816; b=QChyo55OijEkPV3U3Pn/9M5w5l3kPQaZdAENiA+jZjvcALIi+Q1LOnnAdpkRr8+1dA YxbEYg47VUuiQ+gFyYceN6jIlHKfG3u3Fx3IiCt7jWe5Teg+eJYqqcDF5shM/kjTWjwz k0xH+4sbTyCu6pUOiRPgxSgIFTO3xkMe3Yr6VP3em1i/4KkzP7dIdSrOkEoEaGADZCvG JITqWCgZKi+5+ScVAPccGvM7ESLuiLgQvOFe3Rx/q1/klznB24NfniKp5HaFMoF+tOk2 iUI4btRBwhM6eQfz8P9g1oJBRwtVDNr64FElDY6ZwuSLGpv1KFYJzYonmmioXgT3Ut3l OHvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:message-id:date:from :content-transfer-encoding:mime-version:subject:feedback-id :dkim-signature:dkim-signature; bh=0vEYkd8bixr3ku/BHWvI3mqVBiV48ootD5ag5Hu/HHs=; b=xXLJlzImEpWH2LCutZck5lqYK3EBFyEk/yHZpFRLEP9Iv9v8Vt7HzgObZ+XeocfABL xJVCQZ7g1g+E1bH3+GGlMVETsu6Yk9NUj3Pbijw+yhIKeFiv/hN73EMi6QTQ+SqPtstF +XgJJXpkOzylJY0BUrDsk86xS5kWEur80xbWh3O3c3ZZoVVf95tc9yMzTMjqURPdTfrY lz9UzNLs1WWk653heTnoPwgVHlQj0/foprJaaLgKx5pBkX+xtW5CW/x0uuzuhvMXNWdn o9Gur6R9OhwWBXRB2O/9xjpvqIihdac+QWXBDak6RFQGAkmNxaWDVdN6zk+CIFMCi8sP pRJw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cerno.tech header.s=fm3 header.b=Yh3pLrft; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=LXt6dKGu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=cerno.tech Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h66-20020a636c45000000b0042b807728e3si21971138pgc.762.2022.10.13.02.16.28; Thu, 13 Oct 2022 02:16:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@cerno.tech header.s=fm3 header.b=Yh3pLrft; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=LXt6dKGu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=cerno.tech Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229639AbiJMJNR (ORCPT <rfc822;ouuuleilei@gmail.com> + 99 others); Thu, 13 Oct 2022 05:13:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42488 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229516AbiJMJNP (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 13 Oct 2022 05:13:15 -0400 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0472D13D62F; Thu, 13 Oct 2022 02:13:13 -0700 (PDT) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 9A09B5C00EE; Thu, 13 Oct 2022 05:13:11 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 13 Oct 2022 05:13:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to; s=fm3; t=1665652391; x=1665738791; bh=0vEYkd8bix r3ku/BHWvI3mqVBiV48ootD5ag5Hu/HHs=; b=Yh3pLrftscvxWZtmtj2ioiEcla HOolYJoyvOR6PpCbsDWE+ZVDSKmQ8W7TPQYWBVFujwouweDFk2x9Cm/rDPRIQBjH /YvRcoR6N32KNORhClIO8IP8NKfzKXQSCxhU7U+7yxjHIweS9HDx3wfnC43Cz7s0 eZy3qaUnFMxg2O/l4X8A6PHZS2AjGQNfVAINthPzPvlK6zRAoYIpciY6tCw4jwYj SV1Fth+TEUtpqLgC4Cik3xP164nTX2sKObQ2X7pHroO0tr+fBUNw1RVoEr9HCQ/s N0nULHp5CRf1Utg0WxPwRR2Im3ePeHlHYRPQZx3g8yeuxe8nNIHl/ucRb4QA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1665652391; x=1665738791; bh=0vEYkd8bixr3k u/BHWvI3mqVBiV48ootD5ag5Hu/HHs=; b=LXt6dKGuNXrYQt30Ggwp18QnOBHiG xhsHYdDkoc3nODgNBUQ854lSgT/HxinHmQ91tx8dLVfVwNPxhySmPwk4DY0qapi4 ZwT2dWwHgg2JAGd5eC9VnT+AQNcX+kKYdKzTKNrLcPsjQlGLUWtaZ0hMCuFeleQ7 Vqm5l/K4v/qy9C94QOv/8cBZ1cKMRbCEPd+dcSk5XVljkH5aQPlTOhuQnwa/ggC0 AxJgR1Wqc+m7PvbU9XeiWa2hnaBjvRV61KgPWjounO2Xu65ADbHA3mvkTdwKLv8W AyAahZRXPeIkcQkSLP3Gd2BSvFGt9xXE36M7uMaUmzaOWQhYZcsC3Qlog== X-ME-Sender: <xms:ptZHYwU-qJ3y48ADIPjsH9KXPAt3JKJwuEhOH4173vMVifcdhPlztg> <xme:ptZHY0kC7RLRBC0Q2nCu5lERDC_f7XpPvAkusgBloIV-p8YivaqGIoqUqAaSEQczG RCQlKaTl8xgxPcmGtE> X-ME-Received: <xmr:ptZHY0bno18vJzTRqJ2Gz7u4BDtGxpSLz7gsGJFCd2AdzuYRLBP5pEt0W0jv5rg3-KJAnBew4COp5PbgeOTlcawQw9sWOlIPDWBL> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeektddgudegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepufggtgfghfffkffvvefosehtkeertdertdejnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepleeuveetteffvdevlefgffelgeduueefleevfedvudegheekfeekheejieek gedunecuffhomhgrihhnpehkvghrnhgvlhdrohhrghenucevlhhushhtvghrufhiiigvpe dtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: <xmx:ptZHY_XI_Sd7wb1FY_VcNo5eQiBOgttHJCfRvypgQ1gRyLUt4iELMw> <xmx:ptZHY6lyuv0o5yiHSSUK39B679xESKkyOZOkWKxbEtHDc9ht65TIBg> <xmx:ptZHY0dEGU6A_xK52Ys8ARXwmhNjvgHUTC07ZAmPst4CBsCRKQqGPA> <xmx:p9ZHY02zSNfYQkQHTl6gNo4i20sdeXn4YcZvUTyrdfULbKc27YKgCQ> Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 13 Oct 2022 05:13:09 -0400 (EDT) Subject: [PATCH v3 0/7] drm/vc4: Fix the core clock behaviour MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-b4-tracking: H4sIAKPWR2MC/3WNwQqDMBBEf0Vy7krcaNSe+h+lhySudSlESSS0SP69sfeehjfwZg4RKTBFca0OES hx5NUXUJdKuMX4JwFPhQVKRDk0HYSNYeY3tC/QEpoee6U72eI4ieJYEwlsMN4tp5V0Lc964biv4fN7 SVji/m8wIUgYB4W9toOaNd4cBb/WO5XFR875C++5PxqyAAAA From: Maxime Ripard <maxime@cerno.tech> Date: Thu, 13 Oct 2022 11:13:07 +0200 Message-Id: <20220815-rpi-fix-4k-60-v3-0-fc56729d11fe@cerno.tech> To: Florian Fainelli <f.fainelli@gmail.com>, Michael Turquette <mturquette@baylibre.com>, Emma Anholt <emma@anholt.net>, Stephen Boyd <sboyd@kernel.org>, Ray Jui <rjui@broadcom.com>, Scott Branden <sbranden@broadcom.com>, Broadcom internal kernel review list <bcm-kernel-feedback-list@broadcom.com>, Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>, Maxime Ripard <mripard@kernel.org> Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Maxime Ripard <maxime@cerno.tech>, Stefan Wahren <stefan.wahren@i2se.com>, linux-clk@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, Dom Cobley <popcornmix@gmail.com>, dri-devel@lists.freedesktop.org X-Mailer: b4 0.11.0-dev-7da52 X-Developer-Signature: v=1; a=openpgp-sha256; l=2888; i=maxime@cerno.tech; h=from:subject:message-id; bh=q5AgOh+USgAmEBoawabygqWU6QbAvt2sDptobotpAq8=; b=owGbwMvMwCX2+D1vfrpE4FHG02pJDMnu15b0S4qxu4mmZoZ1PdOP0bCo1bFZZVU/89SDLXGsffty taM7SlkYxLgYZMUUWWKEzZfEnZr1upONbx7MHFYmkCEMXJwCMJH3jowMC1O8bSL4a4+lvz6xe9Pr9w eC3HbO5gwubtddnmuUfMKklJHhTuqyaNVV77MyDhjZW1eluRsaVQhZVytWu0XXPjge/54LAA== X-Developer-Key: i=maxime@cerno.tech; a=openpgp; fpr=BE5675C37E818C8B5764241C254BCFC56BF6CE8D X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1746562651357545070?= X-GMAIL-MSGID: =?utf-8?q?1746563341439351694?= |
Series |
drm/vc4: Fix the core clock behaviour
|
|
Message
Maxime Ripard
Oct. 13, 2022, 9:13 a.m. UTC
Hi,
Those patches used to be part of a larger clock fixes series:
https://lore.kernel.org/linux-clk/20220715160014.2623107-1-maxime@cerno.tech/
However, that series doesn't seem to be getting anywhere, so I've split out
these patches that fix a regression that has been there since 5.18 and that
prevents the 4k output from working on the RaspberryPi4.
Hopefully, we will be able to merge those patches through the DRM tree to avoid
any further disruption.
Let me know what you think,
Maxime
To: Florian Fainelli <f.fainelli@gmail.com>
To: Broadcom internal kernel review list <bcm-kernel-feedback-list@broadcom.com>
To: Ray Jui <rjui@broadcom.com>
To: Scott Branden <sbranden@broadcom.com>
To: Michael Turquette <mturquette@baylibre.com>
To: Stephen Boyd <sboyd@kernel.org>
To: Emma Anholt <emma@anholt.net>
To: Maxime Ripard <mripard@kernel.org>
To: David Airlie <airlied@linux.ie>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Stefan Wahren <stefan.wahren@i2se.com>
Cc: linux-rpi-kernel@lists.infradead.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Cc: linux-clk@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: Dom Cobley <popcornmix@gmail.com>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
---
Changes in v3:
- Return UINT_MAX when the firmware call fails in the _get_max_rate function
- Link to v2: https://lore.kernel.org/r/20220815-rpi-fix-4k-60-v2-0-983276b83f62@cerno.tech
Changes in v2:
- Dropped the clock patches, made an ad-hoc function in the firmware driver
- Link to v1: https://lore.kernel.org/r/20220815-rpi-fix-4k-60-v1-0-c52bd642f7c6@cerno.tech
---
Dom Cobley (1):
drm/vc4: hdmi: Add more checks for 4k resolutions
Maxime Ripard (6):
firmware: raspberrypi: Introduce rpi_firmware_find_node()
firmware: raspberrypi: Move the clock IDs to the firmware header
firmware: raspberrypi: Provide a helper to query a clock max rate
drm/vc4: hdmi: Fix hdmi_enable_4kp60 detection
drm/vc4: hdmi: Rework hdmi_enable_4kp60 detection code
drm/vc4: Make sure we don't end up with a core clock too high
drivers/clk/bcm/clk-raspberrypi.c | 18 -----------
drivers/firmware/raspberrypi.c | 27 ++++++++++++++++
drivers/gpu/drm/vc4/vc4_drv.h | 16 ++++++++++
drivers/gpu/drm/vc4/vc4_hdmi.c | 25 ++++++++-------
drivers/gpu/drm/vc4/vc4_hdmi.h | 8 -----
drivers/gpu/drm/vc4/vc4_hvs.c | 26 +++++++++++++++
drivers/gpu/drm/vc4/vc4_kms.c | 13 +++++---
include/soc/bcm2835/raspberrypi-firmware.h | 51 ++++++++++++++++++++++++++++++
8 files changed, 141 insertions(+), 43 deletions(-)
---
base-commit: 4fe89d07dcc2804c8b562f6c7896a45643d34b2f
change-id: 20220815-rpi-fix-4k-60-17273650429d
Best regards,