Message ID | 170863444851.1479840.10249410842428140526.stgit@dwillia2-xfh.jf.intel.com |
---|---|
Headers |
Return-Path: <linux-kernel+bounces-77326-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:a81b:b0:108:e6aa:91d0 with SMTP id bq27csp198021dyb; Thu, 22 Feb 2024 12:41:10 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWz0qIzV5Q7+q92z9wovxftxNrYGgCXVtggcbPhekNrvbAKidSc1mgRAFI8TM9mrF1KGrP6wNT4KNk202d+PvvnWoylFw== X-Google-Smtp-Source: AGHT+IGg+SDiPosuvAejd3nfdnpoquxqfcJnh2GwqDVMjg7A5bkNP1r8VInxfaNnHYdIb4AtUC39 X-Received: by 2002:aa7:c742:0:b0:564:fe3a:280a with SMTP id c2-20020aa7c742000000b00564fe3a280amr3803366eds.9.1708634470026; Thu, 22 Feb 2024 12:41:10 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708634470; cv=pass; d=google.com; s=arc-20160816; b=jaAsMsjxUIy78RLZ5twbjsG1Ucn45EsNK0FKjzCL+VuurdbBYk02PDkq/o9h1bKA2l tnTzC/VyHjfRPPlABuc6vxRHiFtuikv07v7mKmEg/juMoN6yUNzUfM5EaKGkzUZOpToP 8l6eCoekeRr7x1I9UXMATWG+136ZM3jpEdrb//CG+83aIlvt7nVJ06JXlJnF2yCwILHm +vCjZSGsyfvlu1qLQZHGrMyYBAuUDQyOV5lipk2fgTty2iKUGCjNQ2MZcaQYVOcUSzOB qfrBw3G9LBztUs/SiJp1oVZLSce8sw5HyARb9ZMbG/rrg0bKo0ZzIACyGND95FEVJaUx 08kQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:user-agent:message-id:date:cc:to :from:subject:dkim-signature; bh=9dVqSj1eymBwQQWBX7ljJFhSRs4+a6FdcwJV5wLYO5k=; fh=DhhRFiPN9WH5yyY0siVxSoAJxG2bKzQrHrbYWRuRRBE=; b=DoHRzrkKLQBdEnwDC5HFmTCM/SQ4birrhSTGs2IEFpDGUHcMkUo5hreSrmZGRMePH0 xFqBS6J5ylh7S8UAl1kUXi+maVeJqwYgMGV+lyUNegHlQ0mXYU6JX9IFevfWAwSNNB/Q 0XrQDWTbQeCghfICraZmCoJm9Gx22AUHRizWXefa42FToXJir2zcVxvnBHHz0oF1y8M/ A4KuTPb9bU9RenWjZbZWfzYx/y0IHE5TpGVVcN495+9yHQem3Nu5nhtig7D3/DLUk5iG gIpeqQilnq/6mWbUZGJFJ++cgB9eU0UgV6a16OX0SjnXt8FpIVT+Q4dRG9Dispvj9zQo F7TQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=FBCEBsZO; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-77326-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-77326-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id y24-20020aa7ccd8000000b0056391332f0bsi5387336edt.174.2024.02.22.12.41.09 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Feb 2024 12:41:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-77326-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=FBCEBsZO; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-77326-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-77326-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 7238C1F27F4D for <ouuuleilei@gmail.com>; Thu, 22 Feb 2024 20:41:09 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 825B771750; Thu, 22 Feb 2024 20:40:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="FBCEBsZO" Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3480F6AF8D; Thu, 22 Feb 2024 20:40:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.9 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708634453; cv=none; b=gOKJAu/vWxzUh7XhG6YULXvEFVQ36uMC5v/lLSOc4DeMAHZ6gfu4KyrRmUt2oJJ0Ywo57vgMoXcvELeV9v8QO27wPKrp2nK3/FSGz8gzBYb9CyOFnVYX9B6bDyHGtms430BcbgVnVlEcF31gCgfShlcePX/OKgnZWdXZLpTxyeo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708634453; c=relaxed/simple; bh=jeAQTPQrhXpg49xvZysNAxqhbPsEr5aAB0AbuUICJgI=; h=Subject:From:To:Cc:Date:Message-ID:MIME-Version:Content-Type; b=Dt+wWfS9jBCHSp6zo2FOBylK4/IcDWjdWASmsP6jMhya7oRX1ReiICAnIDA+Y4Me1RWlOttL8yl640KJb/PsTZEd95eVJXHzRIDi6ITDCjoQ2fy6iSAYBLCXQEUb4uL2iBYRIzho7ZvlQjMhILswwGpgQYVkqWDNVM6AWIOafbk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=FBCEBsZO; arc=none smtp.client-ip=198.175.65.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708634450; x=1740170450; h=subject:from:to:cc:date:message-id:mime-version: content-transfer-encoding; bh=jeAQTPQrhXpg49xvZysNAxqhbPsEr5aAB0AbuUICJgI=; b=FBCEBsZO2YBkg1tE7Q5bj4p7HcX5XA/KomeEgKgUhB3XRKbdt4vnpCZI BWBk+7Iqut+NJ32HlQGiYuF6MdgZEfavKi4KArm25O0Rsk2OaqpNhjs1x UaN2opVxzR/YzywA3M6fs+W9ODXoTwWgNlPLj9RVoSTkT86bdiuqhvs93 /jYr2dru5RGPUYP9FKqMyKLGbmmBQWhwinJZL+VKxTTFHBjhH8AxKl187 8Ybmk0Qwj+u1J68FPO0QSZS2nqP23T4zDY7rD65iwR5iSUwa+E+YoejtF LmWXEs2bWq0zGptVAkJmWOfm+Lo42NuFiyYoA5smpKgMQHIl1SzGspClT w==; X-IronPort-AV: E=McAfee;i="6600,9927,10992"; a="25358626" X-IronPort-AV: E=Sophos;i="6.06,179,1705392000"; d="scan'208";a="25358626" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Feb 2024 12:40:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10992"; a="913585365" X-IronPort-AV: E=Sophos;i="6.06,179,1705392000"; d="scan'208";a="913585365" Received: from wyeh-mobl.amr.corp.intel.com (HELO dwillia2-xfh.jf.intel.com) ([10.209.77.87]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Feb 2024 12:40:49 -0800 Subject: [PATCH 0/3] sysfs: Group visibility fixups From: Dan Williams <dan.j.williams@intel.com> To: gregkh@linuxfoundation.org Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>, Marc Herbert <marc.herbert@intel.com>, "Rafael J. Wysocki" <rafael@kernel.org>, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-coco@lists.linux.dev, alsa-devel@alsa-project.org Date: Thu, 22 Feb 2024 12:40:48 -0800 Message-ID: <170863444851.1479840.10249410842428140526.stgit@dwillia2-xfh.jf.intel.com> User-Agent: StGit/0.18-3-g996c Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791633097966426425 X-GMAIL-MSGID: 1791633097966426425 |
Series | sysfs: Group visibility fixups | |
Message
Dan Williams
Feb. 22, 2024, 8:40 p.m. UTC
Hey Greg, Marc was able to get me a backtrace for that bootup hang scenario that Pierre noted here [1]. A Tested-by is still pending, but I am certain this is the issue, and it may impact more than just the one platform if that "empty_attrs" pattern has been repeated anywhere else in the kernel. I also took some time to document how to use the helpers a bit better, and introduce DEFINE_SIMPLE_SYSFS_GROUP_VISIBLE() for cases where all that matters is group visibility and not per attribute visibility. [1]: http://lore.kernel.org/r/b93ec9c2-23f5-486b-a3dc-ed9b960df359@linux.intel.com --- Dan Williams (3): sysfs: Fix crash on empty group attributes array sysfs: Document new "group visible" helpers sysfs: Introduce DEFINE_SIMPLE_SYSFS_GROUP_VISIBLE() fs/sysfs/group.c | 4 +- include/linux/sysfs.h | 85 +++++++++++++++++++++++++++++++++++++++++++++++-- 2 files changed, 84 insertions(+), 5 deletions(-) base-commit: 70317fd24b419091aa0a6dc3ea3ec7bb50c37c32
Comments
On Thu, Feb 22, 2024 at 12:40:48PM -0800, Dan Williams wrote: > Hey Greg, > > Marc was able to get me a backtrace for that bootup hang scenario that > Pierre noted here [1]. A Tested-by is still pending, but I am certain > this is the issue, and it may impact more than just the one platform if > that "empty_attrs" pattern has been repeated anywhere else in the > kernel. > > I also took some time to document how to use the helpers a bit better, > and introduce DEFINE_SIMPLE_SYSFS_GROUP_VISIBLE() for cases where all > that matters is group visibility and not per attribute visibility. > > [1]: http://lore.kernel.org/r/b93ec9c2-23f5-486b-a3dc-ed9b960df359@linux.intel.com I'll just queue these up now on my normal driver-core-next branch, and not worry about a stable tag as I doubt anyone wants that now. But if they do, please let me know and I can provide one. thanks for the quick fixes! greg k-h