mbox series

[v8,0/5] arm64: qcom: sa8775p: add support for EP PCIe

Message ID 1699669982-7691-1-git-send-email-quic_msarkar@quicinc.com
Headers
Series arm64: qcom: sa8775p: add support for EP PCIe |

Message

Mrinmay Sarkar Nov. 11, 2023, 2:32 a.m. UTC 
  This series adds the relavent DT bindings, new compatible string,
add support to EPF driver and add EP PCIe node in dtsi file for
ep pcie0 controller.

v7 -> v8:
- Add new patch PCI: epf-mhi: Add "pci_epf_mhi_" prefix to the function
  names
- Update PCI: epf-mhi: Add support for SA8775P patch on top of the new
  patch and update commit message.

v6 -> v7:
- add reviewed by tag in commit message in all patches.
- update commit message in patch 2 as per comment.
- update reason for reusing PID in commit message.

v5 -> v6:
- update cover letter.

v4 -> v5:
- add maxItems to the respective field to constrain io space and
  interrupt in all variants.

v3 -> v4:
- add maxItems field in dt bindings
- update comment in patch2
- dropped PHY driver patch as it is already applied [1]
- update comment in EPF driver patch
- update commect in dtsi and add iommus instead of iommu-map

[1] https://lore.kernel.org/all/169804254205.383714.18423881810869732517.b4-ty@kernel.org/

v2 -> v3:
- removed if/then schemas, added minItems for reg,
  reg-bnames, interrupt and interrupt-names instead.
- adding qcom,sa8775p-pcie-ep compitable for sa8775p
  as we have some specific change to add.
- reusing sm8450's pcs_misc num table as it is same as sa8775p.
  used appropriate namespace for pcs.
- remove const from sa8775p_header as kernel test robot
  throwing some warnings due to this.
- remove fallback compatiable as we are adding compatiable for sa8775p.

v1 -> v2:
- update description for dma
- Reusing qcom,sdx55-pcie-ep compatibe so remove compaitable
  for sa8775p
- sort the defines in phy header file and remove extra defines
- add const in return type pci_epf_header and remove MHI_EPF_USE_DMA
  flag as hdma patch is not ready
- add fallback compatiable as qcom,sdx55-pcie-ep, add iommu property


Mrinmay Sarkar (5):
  dt-bindings: PCI: qcom-ep: Add support for SA8775P SoC
  PCI: qcom-ep: Add support for SA8775P SOC
  PCI: epf-mhi: Add "pci_epf_mhi_" prefix to the function names
  PCI: epf-mhi: Add support for SA8775P
  arm64: dts: qcom: sa8775p: Add ep pcie0 controller node

 .../devicetree/bindings/pci/qcom,pcie-ep.yaml      | 64 +++++++++++++++++++++-
 arch/arm64/boot/dts/qcom/sa8775p.dtsi              | 46 ++++++++++++++++
 drivers/pci/controller/dwc/pcie-qcom-ep.c          |  1 +
 drivers/pci/endpoint/functions/pci-epf-mhi.c       | 21 ++++++-
 4 files changed, 128 insertions(+), 4 deletions(-)

Comments

Mrinmay Sarkar Nov. 20, 2023, 10:06 a.m. UTC | #1 
Some of the patches are reviewed. Please apply in linux-next.

Thanks,
Mrinmay

On 11/11/2023 8:02 AM, Mrinmay Sarkar wrote:
> This series adds the relavent DT bindings, new compatible string,
> add support to EPF driver and add EP PCIe node in dtsi file for
> ep pcie0 controller.
>
> v7 -> v8:
> - Add new patch PCI: epf-mhi: Add "pci_epf_mhi_" prefix to the function
>    names
> - Update PCI: epf-mhi: Add support for SA8775P patch on top of the new
>    patch and update commit message.
>
> v6 -> v7:
> - add reviewed by tag in commit message in all patches.
> - update commit message in patch 2 as per comment.
> - update reason for reusing PID in commit message.
>
> v5 -> v6:
> - update cover letter.
>
> v4 -> v5:
> - add maxItems to the respective field to constrain io space and
>    interrupt in all variants.
>
> v3 -> v4:
> - add maxItems field in dt bindings
> - update comment in patch2
> - dropped PHY driver patch as it is already applied [1]
> - update comment in EPF driver patch
> - update commect in dtsi and add iommus instead of iommu-map
>
> [1] https://lore.kernel.org/all/169804254205.383714.18423881810869732517.b4-ty@kernel.org/
>
> v2 -> v3:
> - removed if/then schemas, added minItems for reg,
>    reg-bnames, interrupt and interrupt-names instead.
> - adding qcom,sa8775p-pcie-ep compitable for sa8775p
>    as we have some specific change to add.
> - reusing sm8450's pcs_misc num table as it is same as sa8775p.
>    used appropriate namespace for pcs.
> - remove const from sa8775p_header as kernel test robot
>    throwing some warnings due to this.
> - remove fallback compatiable as we are adding compatiable for sa8775p.
>
> v1 -> v2:
> - update description for dma
> - Reusing qcom,sdx55-pcie-ep compatibe so remove compaitable
>    for sa8775p
> - sort the defines in phy header file and remove extra defines
> - add const in return type pci_epf_header and remove MHI_EPF_USE_DMA
>    flag as hdma patch is not ready
> - add fallback compatiable as qcom,sdx55-pcie-ep, add iommu property
>
>
> Mrinmay Sarkar (5):
>    dt-bindings: PCI: qcom-ep: Add support for SA8775P SoC
>    PCI: qcom-ep: Add support for SA8775P SOC
>    PCI: epf-mhi: Add "pci_epf_mhi_" prefix to the function names
>    PCI: epf-mhi: Add support for SA8775P
>    arm64: dts: qcom: sa8775p: Add ep pcie0 controller node
>
>   .../devicetree/bindings/pci/qcom,pcie-ep.yaml      | 64 +++++++++++++++++++++-
>   arch/arm64/boot/dts/qcom/sa8775p.dtsi              | 46 ++++++++++++++++
>   drivers/pci/controller/dwc/pcie-qcom-ep.c          |  1 +
>   drivers/pci/endpoint/functions/pci-epf-mhi.c       | 21 ++++++-
>   4 files changed, 128 insertions(+), 4 deletions(-)
>
Krzysztof Kozlowski Nov. 20, 2023, 10:08 a.m. UTC | #2 
On 20/11/2023 11:06, Mrinmay Sarkar wrote:
> Some of the patches are reviewed. Please apply in linux-next.
> 

1 week for a ping, which included widely-known conference, is not really
enough.

Please relax, and help out by reviewing other patches on the mailing
lists in order to relieve the burden of maintainers and move your
patches higher up the list.

Best regards,
Krzysztof