Message ID | 168873724526.2687993.15242662075324919195.stgit@mhiramat.roam.corp.google.com |
---|---|
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f45:0:b0:3ea:f831:8777 with SMTP id v5csp3280363vqx; Fri, 7 Jul 2023 06:47:03 -0700 (PDT) X-Google-Smtp-Source: APBJJlHCgA3/VBrqWkaNI12Vlnk8QZAYIuvrgHjoYjKbrvKI9IrVOpYdeHcvJrR1shdVZI/5JhdZ X-Received: by 2002:a05:6830:1302:b0:6b8:6e4e:d12b with SMTP id p2-20020a056830130200b006b86e4ed12bmr5421204otq.9.1688737623187; Fri, 07 Jul 2023 06:47:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688737623; cv=none; d=google.com; s=arc-20160816; b=fg2hkUKgpG/+sOXs+uM9EpG/D3vidN8NKmv0D7x4kxi0W4KVwH+HOBNy8RsisAjBm6 gIJLEowzwlhyMuxZUBSteZvZ2gby7Zwkh6o7HHC4zNxecTiCVPukt+SO/fgk9fEhhbX8 BnmoSmVQD+QdsaNhEjj3QYm5Qb2IWgfqUzklVDLuIul+BjqWuReUOerpsoMyr2figaKH SJT3dKyJqpgjEIFg75zqpN3+cjkwIG48g6XSTGkKi0iN3846sy5SjsvVlfYOABvbbGb+ p/RTPgBUr/7uVjAHc75wynTYKACeDeuEox9L56idI15D/oURCkVbCJRxmFPqBGwWZTjC sWUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:message-id:date:subject:cc:to:from:dkim-signature; bh=mtOpPSZMubpjPh769HPB0yKoE1iDG8oOXnmwMpgrsD8=; fh=hf24JvveL55vCfzfv0agRHDWsuhzZqIeZ7dfs5kcUjQ=; b=0XnjRQFuqGFlMy6OVutWpd8sQvnLYYp1aGT+SE79ig6v/XSnnppOA42WOwiGiJvIp7 LDEHGtwJsnP/r4N3bZUx5GywBqyAkKK2X0nfo0RBnlN0ugSfCTNmZi62wh8Hm6Go5c12 sGnSYqiQSiSxYJOvXxoJBRN2kuUzDBz4ua1buU8fEjCOWE44Is3P7JMKMlDlEq0akqq8 bzVbb3XPEyiCpORvrmDTbUiL3LDHDoJczTRTCxCiNyZjsZtmx6NDFdPPiHP9n4r5g/X9 znWg2PPYYxLN2gJbesgceUGTTYYtNkSLl9N0MWbWb9IyPQpgydG89pyOnGTqGsI6Fmqj wz2g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hBIFJhQ1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bs193-20020a6328ca000000b0055bfb8a3f6esi3137644pgb.239.2023.07.07.06.46.48; Fri, 07 Jul 2023 06:47:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hBIFJhQ1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230041AbjGGNkv (ORCPT <rfc822;daweilics@gmail.com> + 99 others); Fri, 7 Jul 2023 09:40:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229740AbjGGNku (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 7 Jul 2023 09:40:50 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EED9F1FF7; Fri, 7 Jul 2023 06:40:49 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8CB6661961; Fri, 7 Jul 2023 13:40:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C4463C433C8; Fri, 7 Jul 2023 13:40:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1688737249; bh=nfU4BCuqJ0MrhHvJAT42oTBJtlqfuNiNGoro5pxyYNk=; h=From:To:Cc:Subject:Date:From; b=hBIFJhQ1YM9AiQcV/Bd0yUAWyh5+1BQDlx3F4AACjmSwvNrcEJsuhQ7AcBwKpheaU RoNxU/KpI5KwhEr5uHNdxf2PC0Beh+SQ9RBwMt3R/XCTYZ9PgbZdDSmo8mxOOTP41J IZT9YKr3k62rbMqEWOwA22PbUe2Qgumt9cqHW1AYyJWsyodY4wn7RmynNQyXsZJaNP dynt1rAL8lqlYej97VcptWXQUszJIViGXx1aSX590cddTYyzoeFaNAiXE9W8m3QiML O0VW9swaOWaP7jUWZwxAgjbXQWcHPIgutlL5SI/wkSg+fpj1iTKrPYYlZhK/EEZNsZ JZUly6tg5IKew== From: "Masami Hiramatsu (Google)" <mhiramat@kernel.org> To: Steven Rostedt <rostedt@goodmis.org> Cc: Dan Carpenter <dan.carpenter@linaro.org>, linux-trace-kernel@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>, Masami Hiramatsu <mhiramat@kernel.org> Subject: [PATCH v2 0/4] tracing/probes: Fix bugs in process_fetch_insn Date: Fri, 7 Jul 2023 22:40:45 +0900 Message-ID: <168873724526.2687993.15242662075324919195.stgit@mhiramat.roam.corp.google.com> X-Mailer: git-send-email 2.41.0.255.g8b1d071c50-goog User-Agent: StGit/0.19 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770769742245452427?= X-GMAIL-MSGID: =?utf-8?q?1770769742245452427?= |
Series |
tracing/probes: Fix bugs in process_fetch_insn
|
|
Message
Masami Hiramatsu (Google)
July 7, 2023, 1:40 p.m. UTC
Hi, Here are the 2nd version of fix bugs in process_fetch_insn_*(). The previous version is here; https://lore.kernel.org/all/168830922841.2278819.9165254236027770818.stgit@mhiramat.roam.corp.google.com/ The first patch [1/4] just updated the description. [2/4] has been changed because previous one did not consider to store the array data. So instead of exit, just clear the 'ret' if it has any error code. [3/4] reverts the patch which did not work. And [4/4] makes each fetch_store_string*() always updates the data_loc, instead of clearing it in store_trace_args(). Thank you, --- Masami Hiramatsu (Google) (4): tracing/probes: Fix to avoid double count of the string length on the array tracing/probes: Fix not to count error code to total length Revert "tracing: Add "(fault)" name injection to kernel probes" tracing/probes: Fix to record 0-length data_loc in fetch_store_string*() if fails kernel/trace/trace_events_synth.c | 2 +- kernel/trace/trace_probe_kernel.h | 29 ++++------------------------- kernel/trace/trace_probe_tmpl.h | 10 +++++----- kernel/trace/trace_uprobe.c | 3 ++- 4 files changed, 12 insertions(+), 32 deletions(-) -- Masami Hiramatsu (Google) <mhiramat@kernel.org>