mbox series

[RESEND,v5,0/6] Add resets for ADSP based audio clock controller driver

Message ID 1674322340-25882-1-git-send-email-quic_srivasam@quicinc.com
Headers
Series Add resets for ADSP based audio clock controller driver |

Message

Srinivasa Rao Mandadapu Jan. 21, 2023, 5:32 p.m. UTC 
  Add resets and remove qdsp6ss clcok controller for audioreach based platforms. 

Changes since v4:
    -- Update Fixes tag in Merge lpasscc into lpass_aon patch.
    -- Revert removal of clk_regmap structure in Merge lpasscc into lpass_aon patch.

Changes since v3:
    -- Remove duplicate clock resets patch.
    -- Add binding headers for q6 clocks.
    -- Create new patch for merging lpasscc q6 clocks into lpass_aon.
    -- Create new patches for handling conflicts of ADSP and bypass solution.

Changes since v2:
    -- Revert removing qdsp6ss clock control.
    -- Add Conditional check for qdsp6ss clock registration.
Changes since v1:
    -- Update commit message.
    -- Remove qdsp6ss clock control.

Srinivasa Rao Mandadapu (6):
  dt-bindings: clock: qcom,sc7280-lpasscc: Add qcom,adsp-pil-mode
    property
  dt-bindings: clock: lpassaudiocc-sc7280: Add binding headers for
    lpasscc
  clk: qcom: lpasscc-sc7280: Skip qdsp6ss clock registration
  clk: qcom: lpasscorecc-sc7280: Skip lpasscorecc registration
  clk: qcom: lpassaudiocc-sc7280: Merge lpasscc into lpass_aon
  clk: qcom: lpassaudiocc-sc7280: Skip lpass_aon_cc_pll config

 .../devicetree/bindings/clock/qcom,sc7280-lpasscc.yaml   |  7 +++++++
 drivers/clk/qcom/lpassaudiocc-sc7280.c                   | 16 +++++++++++-----
 drivers/clk/qcom/lpasscc-sc7280.c                        | 12 +++++++-----
 drivers/clk/qcom/lpasscorecc-sc7280.c                    |  3 +++
 include/dt-bindings/clock/qcom,lpassaudiocc-sc7280.h     |  2 ++
 5 files changed, 30 insertions(+), 10 deletions(-)

Comments

Krzysztof Kozlowski Jan. 22, 2023, 1:51 p.m. UTC | #1 
On 21/01/2023 18:32, Srinivasa Rao Mandadapu wrote:
> Add resets and remove qdsp6ss clcok controller for audioreach based platforms. 
> 
> Changes since v4:
>     -- Update Fixes tag in Merge lpasscc into lpass_aon patch.
>     -- Revert removal of clk_regmap structure in Merge lpasscc into lpass_aon patch.
> 

Your v5 before resend have build issues. Please fix.

Best regards,
Krzysztof
Srinivasa Rao Mandadapu Jan. 23, 2023, 5:13 a.m. UTC | #2 
On 1/22/2023 7:21 PM, Krzysztof Kozlowski wrote:
Thanks for Your time Krzysztof!!!
> On 21/01/2023 18:32, Srinivasa Rao Mandadapu wrote:
>> Add resets and remove qdsp6ss clcok controller for audioreach based platforms.
>>
>> Changes since v4:
>>      -- Update Fixes tag in Merge lpasscc into lpass_aon patch.
>>      -- Revert removal of clk_regmap structure in Merge lpasscc into lpass_aon patch.
>>
> Your v5 before resend have build issues. Please fix.

In v5, one commit missed to amend local changes.Hence resent it.

on Resent patch series no build issues.

>
> Best regards,
> Krzysztof
>
Krzysztof Kozlowski Jan. 23, 2023, 8:01 a.m. UTC | #3 
On 23/01/2023 06:13, Srinivasa Rao Mandadapu wrote:
> 
> On 1/22/2023 7:21 PM, Krzysztof Kozlowski wrote:
> Thanks for Your time Krzysztof!!!
>> On 21/01/2023 18:32, Srinivasa Rao Mandadapu wrote:
>>> Add resets and remove qdsp6ss clcok controller for audioreach based platforms.
>>>
>>> Changes since v4:
>>>      -- Update Fixes tag in Merge lpasscc into lpass_aon patch.
>>>      -- Revert removal of clk_regmap structure in Merge lpasscc into lpass_aon patch.
>>>
>> Your v5 before resend have build issues. Please fix.
> 
> In v5, one commit missed to amend local changes.Hence resent it.
> 
> on Resent patch series no build issues.

Resend means you send the same patches. If you change patches, it's not
resend but new version.

Best regards,
Krzysztof
Stephen Boyd Jan. 25, 2023, 11:05 p.m. UTC | #4 
Quoting Krzysztof Kozlowski (2023-01-23 00:01:02)
> On 23/01/2023 06:13, Srinivasa Rao Mandadapu wrote:
> > 
> > On 1/22/2023 7:21 PM, Krzysztof Kozlowski wrote:
> > Thanks for Your time Krzysztof!!!
> >> On 21/01/2023 18:32, Srinivasa Rao Mandadapu wrote:
> >>> Add resets and remove qdsp6ss clcok controller for audioreach based platforms.
> >>>
> >>> Changes since v4:
> >>>      -- Update Fixes tag in Merge lpasscc into lpass_aon patch.
> >>>      -- Revert removal of clk_regmap structure in Merge lpasscc into lpass_aon patch.
> >>>
> >> Your v5 before resend have build issues. Please fix.
> > 
> > In v5, one commit missed to amend local changes.Hence resent it.
> > 
> > on Resent patch series no build issues.
> 
> Resend means you send the same patches. If you change patches, it's not
> resend but new version.
> 

I'm waiting for a new version now.