mbox series

[0/3] selftests/tracing: Fix some testcases for recent change

Message ID 167309832823.640500.13244630381161014364.stgit@devnote3
Headers
Series selftests/tracing: Fix some testcases for recent change |

Message

Masami Hiramatsu (Google) Jan. 7, 2023, 1:32 p.m. UTC 
  This includes some patches to fix 2 issues on ftrace selftests.

- eprobe filter and eprobe syntax test case were introduced but it
  doesn't check whether the kernel supports eprobe filter. Thus the
  new test case fails on the kernel which has eprobe but not support
  eprobe filter. To solve this issue, add a filter description to
  README file [1/3] and run the filter syntax error test only if the
  description is found in the README file [2/3].

- Recently objtool adds prefix symbols for the function padding nops,
  and the probepoint test case fails because this probepoint test case
  tests whether the kprobe event can probe the target function and the
  functions next to the target function. But the prefix symbols can not
  be probed. Thus these prefix symbols must be skipped [3/3].

Thank you,

---

Masami Hiramatsu (Google) (3):
      tracing/eprobe: Fix to add filter on eprobe description in README file
      selftests/ftrace: Fix eprobe syntax test case to check filter support
      selftests/ftrace: Fix probepoint testcase to ignore __pfx_* symbols


 kernel/trace/trace.c                               |    2 +-
 .../test.d/dynevent/eprobes_syntax_errors.tc       |    4 +++-
 .../selftests/ftrace/test.d/kprobe/probepoint.tc   |    2 +-
 3 files changed, 5 insertions(+), 3 deletions(-)

--
Masami Hiramatsu (Google) <mhiramat@kernel.org>

Comments

Steven Rostedt Jan. 8, 2023, 9:31 p.m. UTC | #1 
On Sat,  7 Jan 2023 22:32:08 +0900
"Masami Hiramatsu (Google)" <mhiramat@kernel.org> wrote:

> This includes some patches to fix 2 issues on ftrace selftests.
> 
> - eprobe filter and eprobe syntax test case were introduced but it
>   doesn't check whether the kernel supports eprobe filter. Thus the
>   new test case fails on the kernel which has eprobe but not support
>   eprobe filter. To solve this issue, add a filter description to
>   README file [1/3] and run the filter syntax error test only if the
>   description is found in the README file [2/3].
> 
> - Recently objtool adds prefix symbols for the function padding nops,
>   and the probepoint test case fails because this probepoint test case
>   tests whether the kprobe event can probe the target function and the
>   functions next to the target function. But the prefix symbols can not
>   be probed. Thus these prefix symbols must be skipped [3/3].
> 
> Thank you,
> 
> ---
> 
> Masami Hiramatsu (Google) (3):
>       tracing/eprobe: Fix to add filter on eprobe description in README file
>       selftests/ftrace: Fix eprobe syntax test case to check filter support
>       selftests/ftrace: Fix probepoint testcase to ignore __pfx_* symbols
> 
>

Reviewed-by: Steven Rostedt (Google) <rostedt@goodmis.org>

-- Steve
Shuah Khan Jan. 26, 2023, 8:43 p.m. UTC | #2 
On 1/8/23 14:31, Steven Rostedt wrote:
> On Sat,  7 Jan 2023 22:32:08 +0900
> "Masami Hiramatsu (Google)" <mhiramat@kernel.org> wrote:
> 
>> This includes some patches to fix 2 issues on ftrace selftests.
>>
>> - eprobe filter and eprobe syntax test case were introduced but it
>>    doesn't check whether the kernel supports eprobe filter. Thus the
>>    new test case fails on the kernel which has eprobe but not support
>>    eprobe filter. To solve this issue, add a filter description to
>>    README file [1/3] and run the filter syntax error test only if the
>>    description is found in the README file [2/3].
>>
>> - Recently objtool adds prefix symbols for the function padding nops,
>>    and the probepoint test case fails because this probepoint test case
>>    tests whether the kprobe event can probe the target function and the
>>    functions next to the target function. But the prefix symbols can not
>>    be probed. Thus these prefix symbols must be skipped [3/3].
>>
>> Thank you,
>>
>> ---
>>
>> Masami Hiramatsu (Google) (3):
>>        tracing/eprobe: Fix to add filter on eprobe description in README file
>>        selftests/ftrace: Fix eprobe syntax test case to check filter support
>>        selftests/ftrace: Fix probepoint testcase to ignore __pfx_* symbols
>>
>>
> 
> Reviewed-by: Steven Rostedt (Google) <rostedt@goodmis.org>
> 
> -- Steve
> 

For selftest patches in the series: (Assuming patches 2&3 depend on patch 1.)

Acked-by: Shuah Khan <skhan@linuxfoundation.org>

thanks,
-- Shuah