From patchwork Thu Dec 1 15:35:53 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Moger, Babu" X-Patchwork-Id: 2491 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp329133wrr; Thu, 1 Dec 2022 07:36:27 -0800 (PST) X-Google-Smtp-Source: AA0mqf7uVmtCrY92bb0l/kXhx1S3vC5q6Pf4iyyGRUreEV3hCMX/Pm8SkbQnpm/7Niky2o06RRhv X-Received: by 2002:a17:90a:2ec5:b0:217:cdc4:afef with SMTP id h5-20020a17090a2ec500b00217cdc4afefmr77883287pjs.115.1669908987070; Thu, 01 Dec 2022 07:36:27 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1669908987; cv=pass; d=google.com; s=arc-20160816; b=gnVNNzTVpsT3Lr/9t02La8LUn5fN8uI3Qo/JVikFnD6khRXxV5lAqbW3f3VcNno5k9 2ryYOhmFK45Lx+yqyx5ib0G6mubqTqV+ebCIbmbYAJa7O99UYoqq8dLt8U42DCghzVNB tzt+rnGY44ylhymVU9Au4udkFFTOMiOmvb7tji2vCuoyZ+vw85NtGkD4FsQ38sLwbz3u 7w144Ey/g4Iaks9BPkXHRadyYZxo4O9M6dAyA4dJYOyYjMxxSStZHNmS/hT1DDO3aqRQ +gyelBx5mvk7hb4swbgqXd9QyRp3tEy7K00eqTG8rA4m1joC1Kk5qofh+UHvM6sVZEWr MfvQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:message-id:date:cc:to:from:subject:dkim-signature; bh=KxUQvFyJ9gYG3TLNi6xY905cZDc4s8wgJu3+LzyMdnI=; b=z5IuLhXkybKjEWOCe50/SX7/0V3OzuiROWkLWbSEhJTD/61zIL/4lfyCVAivfhcqWM MsOyRYV1BaqXJ/cb6/vE70r0Q0PFSQ///JrPMMmSjejWwVG4SJ75iuWJa2AQ+W05dAWv gu8UZnqlLRwFduIge5EPTUxtn2eW2qOkKXZU+MlvLIE6c70U46SPF1eJwejYk/KHQqnR oIaXl0EIg2kaLfvh1w2JCZZcu4wo9+7OFQ8ZGRa/sH5InT5jOrRL1vT4wZtvhbO5UxDM U+SkZuyEseMqtUc3rCF48q6M2chRoWz27XSAiuFh6VU4uk7ToFTYTSa+5GMlr2xaDeOE wYow== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amd.com header.s=selector1 header.b=WRrXnxcU; arc=pass (i=1 spf=pass spfdomain=amd.com dmarc=pass fromdomain=amd.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amd.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z11-20020a17090acb0b00b0021943a8de18si4691372pjt.62.2022.12.01.07.36.13; Thu, 01 Dec 2022 07:36:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@amd.com header.s=selector1 header.b=WRrXnxcU; arc=pass (i=1 spf=pass spfdomain=amd.com dmarc=pass fromdomain=amd.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amd.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231931AbiLAPgJ (ORCPT + 99 others); Thu, 1 Dec 2022 10:36:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43934 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231945AbiLAPgA (ORCPT ); Thu, 1 Dec 2022 10:36:00 -0500 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2044.outbound.protection.outlook.com [40.107.92.44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CEF68113D; Thu, 1 Dec 2022 07:35:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kVEYi2ojpYDpcnQ4jeC8zBmYMxIncDMmoleP4+FnWsIlu6cfIVHzBJrIU6Gh0I3JG1oNgm3xxeLFqTlcV1v3aahe1o3hV50ri5sdMYCR9wDKABdL3cKXts2/1YbvVp72GH+N2BsT27oARJcifKwDwELogPGZiv0bbmsWRd4uM8JDMdlbug+wpNX+/PKc0TojVosmxGTO/oWBNK3np+o+mLgMbVRuTeanLEBU97syS4X5JXxgk4NxHP8gTOboblX+o9kpD2RIG4OdqriV+Ir9itDz6wPNC9QZJy8DR/o/90ambforFf91iDVRrhfWpnpaVzSajS1l3Unqvm/WyrFdkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KxUQvFyJ9gYG3TLNi6xY905cZDc4s8wgJu3+LzyMdnI=; b=adcaMcB4TEBsO087Kw5LfsMqlASBUO4E2Jy8/dHqCdEDxIatlByvZPu6GKcBlulgijYYss+xbuadUste45nj6Qfxy/NElvqxKXtTjPRW294OM9GRwdL9yzY7odbZNkQncuFIw1o4Z2WOk92h7lvdCFwxkkrpqbB8o8nnVgJFlIMBQ7+Ig9SeL7JMrM3erE2X0BxSNk6l+uInYP83dE4mpm62cPE+VBsZoe62dYzlDgEmGb29nsNVjLeG1hcaqEHJR9yCtSr/MUIJiKLzO8VZlgKdNHQKYf/beWWQ+dZej9Di92O2m6+mHcwwO1aFLpHJP4/4DGMfz7SWRQPQBgUYfA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linutronix.de smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KxUQvFyJ9gYG3TLNi6xY905cZDc4s8wgJu3+LzyMdnI=; b=WRrXnxcURUec8g2drh5qgIB+RP6+J4JXS//kz8YWkbTUQ76I4zK5GRxFzkY2YdVHWz9a11P2WUp3/u+I+oo+h4XPL4fcB5Mr0AAA5QOmHKSzcy+skNexw3+AU4wOAPNj+QzVtxs0PNIMYLLu64HJ86CuazmXisA4OwFhmXvGaZ0= Received: from MW4PR03CA0169.namprd03.prod.outlook.com (2603:10b6:303:8d::24) by BN9PR12MB5114.namprd12.prod.outlook.com (2603:10b6:408:137::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Thu, 1 Dec 2022 15:35:56 +0000 Received: from CO1NAM11FT077.eop-nam11.prod.protection.outlook.com (2603:10b6:303:8d:cafe::c3) by MW4PR03CA0169.outlook.office365.com (2603:10b6:303:8d::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23 via Frontend Transport; Thu, 1 Dec 2022 15:35:56 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT077.mail.protection.outlook.com (10.13.175.55) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5834.8 via Frontend Transport; Thu, 1 Dec 2022 15:35:56 +0000 Received: from [127.0.1.1] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 1 Dec 2022 09:35:53 -0600 Subject: [PATCH v9 00/13] Support for AMD QoS new features From: Babu Moger To: , , , , CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Date: Thu, 1 Dec 2022 09:35:53 -0600 Message-ID: <166990882621.17806.16780480657453071426.stgit@bmoger-ubuntu> User-Agent: StGit/1.1.dev103+g5369f4c MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT077:EE_|BN9PR12MB5114:EE_ X-MS-Office365-Filtering-Correlation-Id: cf948a29-c2f3-438f-e7a0-08dad3b1bd29 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7ozzluzx0qiarnnXZNx42C3ULch8x5ZyJMR08EWyvUz2OrMbl61cQHUv8eq0VBRfQHGGcrKnuUyr22hej8/zW5eq5xiLXt5ZigyuXaUqgxh4vTEXTi8oPiZbZrB0sYtkjmDxGwfpzd1UAeRjQsoq81pJKh6WxnYknWanlQMw7BOBwuRAPv/rYqA0/0J9STEs1SPpqLK+Yx4fz7wb6HDqZlZDAXzsbR2ERa5gHmY/bVYzY3PJAWZFQtOnSPcjb6bbYZUnnfhYQk2mQb46ECyjw5/XZF/Y2moDnTqOQ5aEjvdsA5p3baRUpTFJ3kQHPDJhU4WvsTy0DHR4ScITBi8/UsWIczwA0QQHQ6Fly4dknAAL5SCTUrK7+mmbtijCLh6fKM+yKyONvRV90ZMq63ZiX9hwEp50Hd1pJpX55cc7lSv63EZEB2X73bKEqt0yXAodAXeu8c/Pgc8EUOnWSUGDKOJexJfRulOeT/DDKc9UkBAnF0DgMdXPsTdYRUfhDwr2DdxM+FfaNHMYw3d8wBy9gzTsSloKXG2f9Ll9KAQNLrvg/ueVLCElQLjRL3mObHPxoyl0Cb8vG9hJWpSPgstcMK9DdhyTUtGYxGISz3E1QPAWWbD/HHOjW3BFQ7emRpjh9pUDX40XR+T+4UQ+W3pQIaMWT4n7mr1urve7FABg3dTfPD+mxfrJ3bEi8yZyci3ELP3i0kgtV1ZMnOvHXg8EARlVohJtBOfX7l2abU6MyZAjasJGXeY/0vyt90FR/Ncz42v4wUJwpAWZGjGmoluzCd2zihbQIU18JE5EjZGJRyyjIuNK71X5S6KAP8eXd7Cd2S9KhIB7bENJTDBb3AC1OQ== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(7916004)(396003)(376002)(346002)(39860400002)(136003)(451199015)(46966006)(40470700004)(36840700001)(966005)(16526019)(186003)(36860700001)(2906002)(83380400001)(81166007)(356005)(33716001)(70206006)(8676002)(70586007)(40460700003)(41300700001)(9686003)(82740400003)(478600001)(26005)(40480700001)(82310400005)(47076005)(336012)(5660300002)(103116003)(316002)(426003)(86362001)(8936002)(54906003)(110136005)(7416002)(4326008)(7406005)(44832011)(16576012)(71626007)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2022 15:35:56.0940 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cf948a29-c2f3-438f-e7a0-08dad3b1bd29 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT077.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5114 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1751026486135509982?= X-GMAIL-MSGID: =?utf-8?q?1751026486135509982?= New AMD processors can now support following QoS features. 1. Slow Memory Bandwidth Allocation (SMBA) With this feature, the QOS enforcement policies can be applied to the external slow memory connected to the host. QOS enforcement is accomplished by assigning a Class Of Service (COS) to a processor and specifying allocations or limits for that COS for each resource to be allocated. Currently, CXL.memory is the only supported "slow" memory device. With the support of SMBA feature the hardware enables bandwidth allocation on the slow memory devices. 2. Bandwidth Monitoring Event Configuration (BMEC) The bandwidth monitoring events mbm_total_event and mbm_local_event are set to count all the total and local reads/writes respectively. With the introduction of slow memory, the two counters are not enough to count all the different types are memory events. With the feature BMEC, the users have the option to configure mbm_total_event and mbm_local_event to count the specific type of events. Following are the bitmaps of events supported. Bits Description 6 Dirty Victims from the QOS domain to all types of memory 5 Reads to slow memory in the non-local NUMA domain 4 Reads to slow memory in the local NUMA domain 3 Non-temporal writes to non-local NUMA domain 2 Non-temporal writes to local NUMA domain 1 Reads to memory in the non-local NUMA domain 0 Reads to memory in the local NUMA domain This series adds support for these features. Feature description is available in the specification, "AMD64 Technology Platform Quality of Service Extensions, Revision: 1.03 Publication # 56375 Revision: 1.03 Issue Date: February 2022". Link: https://www.amd.com/en/support/tech-docs/amd64-technology-platform-quality-service-extensions Link: https://bugzilla.kernel.org/show_bug.cgi?id=206537 --- v9: Summary of changes: 1. Rebased on top of lastest tip/master as of 11/30. 2. Most of the changes are result of the comments from Fenghua, Reinette and Peter Newman. 3. Fixed the cpuid dependancy. 4. Added the __init attribute to rdt_get_mon_l3_config and mbm_config_rftype_init. 5. Added new function resctrl_arch_reset_rmid_all to clear all rmid statues. 6. Changed mon_event_config_index_get based on Reinette's comments. 7. Changed mbm_config_rftype_init to take care of few extra error handling. 8. Few other minor changes and text changes. v8: https://lore.kernel.org/lkml/166759188265.3281208.11769277079826754455.stgit@bmoger-ubuntu/ Changes: 1. Removed init attribute for rdt_cpu_has to make it available for all the files. 2. Updated the change log for mon_features to correct the names of config files. 3. Changed configuration file name from mbm_total_config to mbm_total_bytes_config. This is more consistant with other changes. 4. Added lock protection while reading/writing the config file. 5. Other few minor text changes. I have been missing few comments in last couple of revisions. Hope I have addressed all of them this time. v7: https://lore.kernel.org/lkml/166604543832.5345.9696970469830919982.stgit@bmoger-ubuntu/ Changes: Not much of a change. Missed one comment from Reinette from v5. Corrected it now. Few format corrections from Sanjaya. v6: https://lore.kernel.org/lkml/166543345606.23830.3120625408601531368.stgit@bmoger-ubuntu/ Summary of changes: 1. Rebased on top of lastest tip tree. Fixed few minor conflicts. 2. Fixed format issue with scattered.c. 3. Removed config_name from the structure mon_evt. It is not required. 4. The read/write format for mbm_total_config and mbm_local_config will be same as schemata format "id0=val0;id1=val1;...". This is comment from Fenghua. 5. Added more comments MSR_IA32_EVT_CFG_BASE writng. 5. Few text changes in resctrl.rst v5: https://lore.kernel.org/lkml/166431016617.373387.1968875281081252467.stgit@bmoger-ubuntu/ Summary of changes. 1. Split the series into two. The first two patches are bug fixes. So, sent them separate. 2. The config files mbm_total_config and mbm_local_config are now under /sys/fs/resctrl/info/L3_MON/. Removed these config files from mon groups. 3. Ran "checkpatch --strict --codespell" on all the patches. Looks good with few known exceptions. 4. Few minor text changes in resctrl.rst file. v4: https://lore.kernel.org/lkml/166257348081.1043018.11227924488792315932.stgit@bmoger-ubuntu/ Got numerios of comments from Reinette Chatre. Addressed most of them. Summary of changes. 1. Removed mon_configurable under /sys/fs/resctrl/info/L3_MON/. 2. Updated mon_features texts if the BMEC is supported. 3. Added more explanation about the slow memory support. 4. Replaced smp_call_function_many with on_each_cpu_mask call. 5. Removed arch_has_empty_bitmaps 6. Few other text changes. 7. Removed Reviewed-by if the patch is modified. 8. Rebased the patches to latest tip. v3: https://lore.kernel.org/lkml/166117559756.6695.16047463526634290701.stgit@bmoger-ubuntu/ a. Rebased the patches to latest tip. Resolved some conflicts. https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git b. Taken care of feedback from Bagas Sanjaya. c. Added Reviewed by from Mingo. Note: I am still looking for comments from Reinette or Fenghua. v2: https://lore.kernel.org/lkml/165938717220.724959.10931629283087443782.stgit@bmoger-ubuntu/ a. Rebased the patches to latest stable tree (v5.18.15). Resolved some conflicts. b. Added the patch to fix CBM issue on AMD. This was originally discussed https://lore.kernel.org/lkml/20220517001234.3137157-1-eranian@google.com/ v1: https://lore.kernel.org/lkml/165757543252.416408.13547339307237713464.stgit@bmoger-ubuntu/ Babu Moger (13): x86/cpufeatures: Add Slow Memory Bandwidth Allocation feature flag x86/resctrl: Add a new resource type RDT_RESOURCE_SMBA x86/cpufeatures: Add Bandwidth Monitoring Event Configuration feature flag x86/resctrl: Include new features in command line options x86/resctrl: Detect and configure Slow Memory Bandwidth Allocation x86/resctrl: Add __init attribute to rdt_get_mon_l3_config() x86/resctrl: Introduce data structure to support monitor configuration x86/resctrl: Add sysfs interface to read mbm_total_bytes_config x86/resctrl: Add sysfs interface to read mbm_local_bytes_config x86/resctrl: Add sysfs interface to write mbm_total_bytes_config x86/resctrl: Add sysfs interface to write mbm_local_bytes_config x86/resctrl: Replace smp_call_function_many() with on_each_cpu_mask() Documentation/x86: Update resctrl.rst for new features .../admin-guide/kernel-parameters.txt | 2 +- Documentation/x86/resctrl.rst | 138 +++++++- arch/x86/include/asm/cpufeatures.h | 2 + arch/x86/include/asm/msr-index.h | 2 + arch/x86/kernel/cpu/cpuid-deps.c | 2 + arch/x86/kernel/cpu/resctrl/core.c | 54 ++- arch/x86/kernel/cpu/resctrl/ctrlmondata.c | 2 +- arch/x86/kernel/cpu/resctrl/internal.h | 28 ++ arch/x86/kernel/cpu/resctrl/monitor.c | 26 +- arch/x86/kernel/cpu/resctrl/rdtgroup.c | 309 ++++++++++++++++-- arch/x86/kernel/cpu/scattered.c | 2 + include/linux/resctrl.h | 10 + 12 files changed, 544 insertions(+), 33 deletions(-) --