From patchwork Mon Dec 12 16:53:48 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Jambor X-Patchwork-Id: 32458 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp2350799wrr; Mon, 12 Dec 2022 08:56:18 -0800 (PST) X-Google-Smtp-Source: AA0mqf6eUe+/i82ZkD5VVgbfW5qD2iCyOf+/9N81lkTNvAfYZhSY2/Ihm31D4/N800EFEqd/nyhR X-Received: by 2002:a05:6402:4442:b0:45c:835b:944f with SMTP id o2-20020a056402444200b0045c835b944fmr15143630edb.11.1670864178390; Mon, 12 Dec 2022 08:56:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670864178; cv=none; d=google.com; s=arc-20160816; b=eDWEOyCaa5CABM4mZ2Nk9QjtTgwDa03KdpN4cix08v89N9dvh7pYlupEfLOlLUzKGT au6+fCJRBUKJYr9y7+W2FUklWv8G5FGpRVLysJe5h/BMD+GbxAK4uTVyk+4G8fu6j1aT 5p6Pn7wZO6vep7vDDuXiMsfJ77tRox7hQhNtk4QANbvg0ep9hlRpTUtnsQ5tA17qWYRn xRBt1Hpzo/ncryctSSb1vmKYkAewQUVrH/idXtRArk7tRA9UtZBYP7E9PH5Wdj4j76wU u19owGY1JuFQGGp51cmwI4BMC0mI/nfzY0YT0UgOXDxnRv8uX0tKla4c+MiAb0U1e8nk QHOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:mime-version:message-id:date :user-agent:subject:cc:to:from:dkim-signature:dkim-signature :dmarc-filter:delivered-to; bh=p5DPHS+I9G6BlF5y2UdIJx4prSiA8jAM+o79QYv5QR0=; b=aj5rvMd67R0XLSDQUSIj70ILeFC+vf0IiCBwhhi8Ym4uIcflBDT60YgzFYIFb9wQ6t e31p0FX+hXUOcQPnbQmpwEigY9sOHHdRQ2aUSkcaM2j/6fgBkm7pCsk+57PnN6w0KQLw WbZciwvN2umZJCXdcPgRtWRgNry2u8fE+6bpUXWqPa3+1tf5vgZKejJ9Blf9w62WfpO4 ef38TM0fDpRBTZvi3Fq9wrdMXDPlTsk3OHLAr3mJEZcBuEKiJ//PuPOKyhHwDl4w+bHq DOM1DlQwkUORVxZ1ikIIvLXqYrLJ8++6j25StUr33enqVkfvBLfXv3WBloMwsGWKjXKz ++lg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=e2t6OiGT; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519 header.b=8Kfwn68g; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org" Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id sb28-20020a1709076d9c00b007c16fb7f176si2953666ejc.956.2022.12.12.08.56.18 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Dec 2022 08:56:18 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=e2t6OiGT; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519 header.b=8Kfwn68g; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org" Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C608F3864A0A for ; Mon, 12 Dec 2022 16:54:26 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id B79FC384F73F for ; Mon, 12 Dec 2022 16:53:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B79FC384F73F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.cz Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id F00523393D; Mon, 12 Dec 2022 16:53:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1670864028; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type; bh=p5DPHS+I9G6BlF5y2UdIJx4prSiA8jAM+o79QYv5QR0=; b=e2t6OiGTczvVc9XB7znNPIM5Sbxec6ZnXX++xPDLvAkvPLYh5xs/tvL8cdwDY+uFPAwKxN j1PKuEuCRNmOpsKXD8xoKVXLfZ63+aY69Y+xySGirJX4GORTM+AmACnTiG/nBOJ4VUas/9 +4VNGoDiJorBqU0KtNrBJZAQxH4SQZE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1670864028; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type; bh=p5DPHS+I9G6BlF5y2UdIJx4prSiA8jAM+o79QYv5QR0=; b=8Kfwn68gSZ+FvoSiQ7gE3Oq0228m5KNSN9KtGl0BROjaPWp6tKsVQ7QN5UCWIWr6EBnjv9 AGilPrhFUWOpanAQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D600013456; Mon, 12 Dec 2022 16:53:48 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id fRg6NJxcl2M5EwAAMHmgww (envelope-from ); Mon, 12 Dec 2022 16:53:48 +0000 From: Martin Jambor To: GCC Patches Cc: Jan Hubicka , Jan Hubicka Subject: [PATCH 8/9] ipa-sra: Make scan_expr_access bail out on uninteresting expressions User-Agent: Notmuch/0.37 (https://notmuchmail.org) Emacs/28.1 (x86_64-suse-linux-gnu) Date: Mon, 12 Dec 2022 17:53:48 +0100 Message-ID: MIME-Version: 1.0 X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1752028076721942662?= X-GMAIL-MSGID: =?utf-8?q?1752028076721942662?= Hi, I'm re-posting patches which I have posted at the end of stage 1 but which have not passed review yet. 8<-------------------------------------------------------------------- I have noticed that scan_expr_access passes all the expressions it gets to get_ref_base_and_extent even when we are really only interested in memory accesses. So bail out when the expression is something clearly uninteresting. Bootstrapped and tested individually when I originally posted it and now bootstrapped and LTO-bootstrapped and tested as part of the whole series. OK for master? gcc/ChangeLog: 2021-12-14 Martin Jambor * ipa-sra.c (scan_expr_access): Bail out early if expr is something we clearly do not need to pass to get_ref_base_and_extent. --- gcc/ipa-sra.cc | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/gcc/ipa-sra.cc b/gcc/ipa-sra.cc index 93fceeafc73..3646d71468c 100644 --- a/gcc/ipa-sra.cc +++ b/gcc/ipa-sra.cc @@ -1748,6 +1748,11 @@ scan_expr_access (tree expr, gimple *stmt, isra_scan_context ctx, || TREE_CODE (expr) == REALPART_EXPR) expr = TREE_OPERAND (expr, 0); + if (!handled_component_p (expr) + && !DECL_P (expr) + && TREE_CODE (expr) != MEM_REF) + return; + base = get_ref_base_and_extent (expr, &poffset, &psize, &pmax_size, &reverse); if (TREE_CODE (base) == MEM_REF)