Message ID | patch-16593-tamar@arm.com |
---|---|
State | Unresolved |
Headers |
Return-Path: <gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp2310376wru; Mon, 14 Nov 2022 11:01:19 -0800 (PST) X-Google-Smtp-Source: AA0mqf4fNA657T7hTT3TRAbIs/OSmyLqiD1MdFvPDtmXHlIanEwPIz7oBs2WxVTSA4dzPALtWqGl X-Received: by 2002:a05:6402:2947:b0:467:5e8a:bce3 with SMTP id ed7-20020a056402294700b004675e8abce3mr12086821edb.334.1668452479138; Mon, 14 Nov 2022 11:01:19 -0800 (PST) Received: from sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id n26-20020aa7c45a000000b00461a3438b24si8704406edr.182.2022.11.14.11.01.18 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Nov 2022 11:01:19 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=Dojk4N6P; arc=fail (signature failed); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0CB50382E50A for <ouuuleilei@gmail.com>; Mon, 14 Nov 2022 19:01:18 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0CB50382E50A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1668452478; bh=kwwwwgmNs2Rdp7ueOkieKrZwg5DkIVKKoMlo6nS/Vng=; h=Date:To:Cc:Subject:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=Dojk4N6PH5xTpBdPGkLELhqrhB6H52/YDbO+pWjleYiyei0eglxFry4UgGSrU9TM5 AiJ5fY2lVP4ph/fH2IOOstE3dW/iP2FKnbMv0mWeGJnABEeHMfEwcARswXafWoapGx kC7mGiUVuE7RgiAxA1GQ5XIDnTbNPgKOHbu/u4/w= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2056.outbound.protection.outlook.com [40.107.22.56]) by sourceware.org (Postfix) with ESMTPS id 8EA2338357A1 for <gcc-patches@gcc.gnu.org>; Mon, 14 Nov 2022 19:00:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8EA2338357A1 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Q3+azjt7GmtseRvBYeZhBgcFubbNSOvUDF4lyFVoYGPFc70lM43iFZzWXKiYmIxJEq3EVmQr3LTYq1yCXoILBmiklfnIIuClAJ37WjoDw7JyWsxePWaFCPrpvhQ6WXHfz0mwy/6XlXrkrdd5udtMO1TwasHdrubWjsFkMqhftCS8W0KAW9Diy2jH9WT6iUxVfP/sDyrpI7Ho4WUzKzJ6eGiiOSYKib0rB8a1SRN5Prc6TyjGExpfyDuXUTH5nn4iCvOIPKJd5oXGn53BVd/ftjOk2GWBq3JBX1AJfg/tgw5teGRgMK59dkKnEP5gS0xI1XcHQG+d0VAbUs3TBFQ7PQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kwwwwgmNs2Rdp7ueOkieKrZwg5DkIVKKoMlo6nS/Vng=; b=UzaTNW/s7ZX9+rJUlbvwU4HgLUDcT1y3bOMj5nJCDh9IZih98BfgJwtp1mFfyHFKOlyq+yqOz8P30DzKU98upzc+F8q89Fd1GqadELlYnXtBqsLm7Dh2vnxs0Pjjpx5J+0iRnXlg+8QmU1B40YyZSwQOF0IammdU5/ChhtOuGDacYTZ8bzXy5MIIA+KD5uL4mFXuJKGvVTFyEZ93kS2ZkDb2zIwMGby8qOIE5L0wzbbcHmthglyeMXswHajlBasPrlVi5qDE9NQcu2z6ZSGdtKDT1t/O3oZ+J0p93TWaffZ9PwIobp8IDu7bhE6vJSNjRqo/G2THjeuLRlAtwHu2dQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=gcc.gnu.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) Received: from AS9PR06CA0523.eurprd06.prod.outlook.com (2603:10a6:20b:49d::24) by DU0PR08MB9369.eurprd08.prod.outlook.com (2603:10a6:10:41d::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.6; Mon, 14 Nov 2022 19:00:29 +0000 Received: from AM7EUR03FT009.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:49d:cafe::6a) by AS9PR06CA0523.outlook.office365.com (2603:10a6:20b:49d::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.17 via Frontend Transport; Mon, 14 Nov 2022 19:00:29 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT009.mail.protection.outlook.com (100.127.140.130) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Mon, 14 Nov 2022 19:00:29 +0000 Received: ("Tessian outbound 6c699027a257:v130"); Mon, 14 Nov 2022 19:00:29 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: cb9deacb64defa48 X-CR-MTA-TID: 64aa7808 Received: from aea36c471845.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id E02E3784-9E54-4E9C-9969-953EDB40071F.1; Mon, 14 Nov 2022 19:00:22 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id aea36c471845.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 14 Nov 2022 19:00:22 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QipKqd33hVDTm0kcxBjSwWthw7bGVMKVB5YzPJzyKq/pNenQ3GzJkxAs7aeJUTQed2dvNUc6SjFhHyU8SEQ4UrsWMmyVmMEr/Dhm9xhFoBFIfrEjd5e0Cvvy8RR8nzYckb9noWY1PMzNgtDGrX6EUoDm92v8yFIY1DYUQ+NE/FoEL2Sd8tptEcuu348LkmYP9ZbX3CVON/cQ4oeQT7KxpBLR3PhPK/8u7tkLGAoc3Av2hThi7N2WIH4Isa5IjU9li3+PZqbrRJzIsly6ScfjuDVtY3OttRup++1aVtq7C4cRNpgbqJi64oMDvQycaQV5dS19h5k2qd/FqFhcdnRgdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kwwwwgmNs2Rdp7ueOkieKrZwg5DkIVKKoMlo6nS/Vng=; b=I+nmQ1Lj7NI6tKfi7MljeNF32FaoH/Bj2z3O6ldtzRv783xxdqHIIe7Nx1sB8Udn5ODOEPdGP6N/mwv155mpPG9F+gKWBKi8G8rjCcyptLRD9Vw+GiLLufoFk0iJy2NmITf1F+BtYiIUYVYNSQ5wVkhymxbOdHmKYYRCjXZXn8der3GfpokVsD/farS55Vrh3qDEs/b4V/bgBkNd9THWscBBYFHjbGerVLrmxUtZlT9gjAG4nBUFD+pSr8HdyGFPHQCqFo09mLQmClbXUkk30kvXZp7GZ5IgoDJ5fy5MQLI+xfZXKUdKDBKC32xrx3cX9VyT+xVSeSXUTr84rmnnLw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB5325.eurprd08.prod.outlook.com (2603:10a6:803:13e::17) by AS8PR08MB8016.eurprd08.prod.outlook.com (2603:10a6:20b:549::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.6; Mon, 14 Nov 2022 19:00:20 +0000 Received: from VI1PR08MB5325.eurprd08.prod.outlook.com ([fe80::bd2a:aff9:b1a0:2fc7]) by VI1PR08MB5325.eurprd08.prod.outlook.com ([fe80::bd2a:aff9:b1a0:2fc7%4]) with mapi id 15.20.5834.007; Mon, 14 Nov 2022 19:00:19 +0000 Date: Mon, 14 Nov 2022 19:00:14 +0000 To: gcc-patches@gcc.gnu.org Cc: nd@arm.com, rguenther@suse.de, jlaw@ventanamicro.com Subject: [PATCH][committed]middle-end: Fix can_special_div_by_const doc. Message-ID: <patch-16593-tamar@arm.com> Content-Type: multipart/mixed; boundary="IFVQQtZ7QoeP181K" Content-Disposition: inline X-ClientProxiedBy: LO4P123CA0175.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18a::18) To VI1PR08MB5325.eurprd08.prod.outlook.com (2603:10a6:803:13e::17) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB5325:EE_|AS8PR08MB8016:EE_|AM7EUR03FT009:EE_|DU0PR08MB9369:EE_ X-MS-Office365-Filtering-Correlation-Id: 074fc8ad-c123-4510-c171-08dac6727f74 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: DOoerdNsV+4MtEz8KJPIYYFYzUGvWrOTrsTam64p1j4Y71RyGWWdD30z6ZeQ/DdrBDWpZxobaRw3GbwwCLb5cqUXo3aeof8VlkjqQGVu8C4mhcAV44bwRFfag7XZlCvcxVWdBiTDleiWJguoQLBJvPyXc3p2oOTIX+vdRCf3RUX3PlM6jkEwot08A3AuUHPwrRjEC60BiIoHCxaa1koW6Oo+hbNhdADQ2441d/LYQq736aMIMCYgLxUtbDTSw5FGbBHLLEugM8pOXlyqiW/xJPgvLL7Y0va+AkwkuoE5evyjEQGVfnvdgm5qHdPOFsg8d3RUe3Tfub4sjpHh0VhsuXWpqEslNbBXpgRza5jyIzkY/DlIV+gatj/0gKNmzRYVaAI1XR/mKio+NjggKlnLdqqk1vwk32ql9n0N2GdLdUWL0eaiEhGiHvSHL+G9ysYNo6GyzF13xfHvQ4jXSMUTGIZFl7NyuE4s5SR5qgeUzbEJ3Bu1q8nCfNllbpmAM1uAz+wgGclPEZgRDE8nbPhXoPcyyaJfiIJyoKH2uSGJMMVvv0Hx0l143MXRj2ygSs+KzHt9JJ4vAFViItiRrrB0oG7sdIx9QthGvMquuL7PpWBl27CF5273Rgdvgo7fphg/Uy5QDiwWlWe48ksayNKhWkxLVMOBCy8BzgjHh0okodlLaNZ+w+Tn2Hr9wqZ+Aq+EaGevdSAPglq+XSRdBhf440miw5tE/rcf6rQ3el3yEOQvUMA0RXbJTXv0DcyGzkMIMWkco9IV8hoCOXY0+hU/4A== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB5325.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(39860400002)(396003)(366004)(376002)(136003)(346002)(451199015)(26005)(6512007)(44144004)(2616005)(33964004)(6506007)(6666004)(186003)(38100700002)(4743002)(235185007)(5660300002)(2906002)(8936002)(44832011)(41300700001)(66946007)(6486002)(478600001)(66476007)(8676002)(4326008)(66556008)(6916009)(316002)(36756003)(86362001)(4216001)(2700100001); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8016 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT009.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: ceda46b4-9104-4459-cf2a-08dac6727801 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7eew4ueVZwHtiicxl35Tt/VIK7hIfCkS3B02wp4BSaz9jQA9dTOG26lD5BQQB/4Rmb4bOIyw1iroAqubSCkOw91v3CSgT7IbTd00BtOKlhkh0UfkwOztrBDOvAjHRiMihMg8hlBkio0jGPTQRO7sS5cSaudVyEGB3xjdA7GWgI1qsAR7ObqkidW6swbyGPo5mST4zZ5gEirkQhqVb0prH5hu0LRe5M5Jf9qEjJeMpH+rtP90Goqu1wDqib9sJqD4gSLUTWF9+Ys0OWT56O9rPmrvQZS/rvbEwsTMR5mY7tFXabpJQYrJCYo1j51Jv0asbTVbUFAHRQy5iqeZY8Z2KcsZVWql8w61oFqMVe2jVbb7cGPo2gyLKcSNjZ0g2mzBZ6+ecvK9aPEf5Lf8xAocnx+Fh4RJ4+xGM1Y6fB/gSJ8DoX0pkbCoveV/TqJIS5IJPix9S+ONCcfCIoi8xxZEOLD73P2s2kG2voZ0enXdMFKUKLYjGanIeO5IEyU6VsGaZ2SEH0vy+mcJduiZAMT5taS1QoHuk7Objm4gHZUnwKFVN2KzipVpngG9wKBTMXwqV9P3oaWtepjUy+AZKSShL3y/ObypJOT9HpjKfMaN3GbuNe+CicFIIna34za/Go/7yB5ta5nPnpof0x+8QGmI0jtt9qPd3azPebDylxgcdhXc7kITsAUkyP0hi9q5z98LqGNT7XJy+uZTB57DxzZNVEr7gREgj694kqF/UIgq4SOClzEXA+qC3xpEJ2u/U/0115ASjhdEckhQ9fKvPgllZs3qXrzdRRFpspgfqKapQlwKCVGBX9uDYW9lOZ0X16uG X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230022)(4636009)(39860400002)(396003)(376002)(346002)(136003)(451199015)(36840700001)(40470700004)(46966006)(41300700001)(186003)(336012)(5660300002)(2616005)(47076005)(36756003)(82310400005)(235185007)(8936002)(44832011)(4326008)(316002)(6916009)(70206006)(8676002)(70586007)(36860700001)(2906002)(40480700001)(40460700003)(82740400003)(356005)(81166007)(478600001)(6666004)(26005)(4743002)(6506007)(6512007)(107886003)(33964004)(44144004)(6486002)(86362001)(4216001)(2700100001); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2022 19:00:29.2651 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 074fc8ad-c123-4510-c171-08dac6727f74 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT009.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9369 X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FORGED_SPF_HELO, GIT_PATCH_0, KAM_DMARC_NONE, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> From: Tamar Christina via Gcc-patches <gcc-patches@gcc.gnu.org> Reply-To: Tamar Christina <tamar.christina@arm.com> Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" <gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org> X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749499227097270485?= X-GMAIL-MSGID: =?utf-8?q?1749499227097270485?= |
Series |
[committed] middle-end: Fix can_special_div_by_const doc.
|
|
Checks
Context | Check | Description |
---|---|---|
snail/gcc-patch-check | warning | Git am fail log |
Commit Message
Tamar Christina
Nov. 14, 2022, 7 p.m. UTC
Hi All, This commits the typo fix so it matches the tm.texi file and fix the bootstrap. Committed under the obvious rule. Thanks, Tamar gcc/ChangeLog: * target.def: Fix typo. --- inline copy of patch -- diff --git a/gcc/target.def b/gcc/target.def index f491e2233cf18760631f148dacf18d0e0b133e4c..41c62a68f03a44aadbaa66ec5ad11ced3cc0801f 100644 -- diff --git a/gcc/target.def b/gcc/target.def index f491e2233cf18760631f148dacf18d0e0b133e4c..41c62a68f03a44aadbaa66ec5ad11ced3cc0801f 100644 --- a/gcc/target.def +++ b/gcc/target.def @@ -1907,7 +1907,7 @@ DEFHOOK "This hook is used to test whether the target has a special method of\n\ division of vectors of type @var{vectype} using the value @var{constant},\n\ and producing a vector of type @var{vectype}. The division\n\ -will then not be decomposed by the and kept as a div.\n\ +will then not be decomposed by the vectorizer and kept as a div.\n\ \n\ When the hook is being used to test whether the target supports a special\n\ divide, @var{in0}, @var{in1}, and @var{output} are all null. When the hook\n\
--- a/gcc/target.def +++ b/gcc/target.def @@ -1907,7 +1907,7 @@ DEFHOOK "This hook is used to test whether the target has a special method of\n\ division of vectors of type @var{vectype} using the value @var{constant},\n\ and producing a vector of type @var{vectype}. The division\n\ -will then not be decomposed by the and kept as a div.\n\ +will then not be decomposed by the vectorizer and kept as a div.\n\ \n\ When the hook is being used to test whether the target supports a special\n\ divide, @var{in0}, @var{in1}, and @var{output} are all null. When the hook\n\