diff mbox series

[testsuite,i386] enable sse2 for signbit-2.c

Message ID orr0r6paik.fsf@lxoliva.fsfla.org
State Accepted
Headers
Series [testsuite,i386] enable sse2 for signbit-2.c |

Checks

Context Check Description
snail/gcc-patch-check success Github commit url

Commit Message

Alexandre Oliva May 24, 2023, 5:24 a.m. UTC 
  The expected results for signbit-2 only arise on x86 with avx512f
disabled and sse2 enabled.  The patch already disables avx512f
explicitly, but it fails to enable sse2.

Bootstrapped on x86_64-linux-gnu.  Also tested on ppc- and x86-vx7r2
with gcc-12.

for  gcc/testsuite/ChangeLog

	* gcc.dg/signbit-2.c: Add -msse2 on x86.
---
 gcc/testsuite/gcc.dg/signbit-2.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Hongtao Liu May 24, 2023, 5:40 a.m. UTC | #1 
On Wed, May 24, 2023 at 1:24 PM Alexandre Oliva via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
>
> The expected results for signbit-2 only arise on x86 with avx512f
> disabled and sse2 enabled.  The patch already disables avx512f
> explicitly, but it fails to enable sse2.
>
> Bootstrapped on x86_64-linux-gnu.  Also tested on ppc- and x86-vx7r2
> with gcc-12.
>
> for  gcc/testsuite/ChangeLog
>
>         * gcc.dg/signbit-2.c: Add -msse2 on x86.
Ok.
> ---
>  gcc/testsuite/gcc.dg/signbit-2.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/testsuite/gcc.dg/signbit-2.c b/gcc/testsuite/gcc.dg/signbit-2.c
> index d7b406effc62d..62bb4047d7421 100644
> --- a/gcc/testsuite/gcc.dg/signbit-2.c
> +++ b/gcc/testsuite/gcc.dg/signbit-2.c
> @@ -2,7 +2,7 @@
>  /* { dg-options "-O3 -fdump-tree-optimized" } */
>
>  /* This test does not work when the truth type does not match vector type.  */
> -/* { dg-additional-options "-mno-avx512f" { target { i?86-*-* x86_64-*-* } } } */
> +/* { dg-additional-options "-msse2 -mno-avx512f" { target { i?86-*-* x86_64-*-* } } } */
>  /* { dg-additional-options "-march=armv8-a" { target aarch64_sve } } */
>  /* { dg-additional-options "-maltivec" { target powerpc_altivec_ok } } */
>  /* { dg-skip-if "no fallback for MVE" { arm_mve } } */
>
> --
> Alexandre Oliva, happy hacker                https://FSFLA.org/blogs/lxo/
>    Free Software Activist                       GNU Toolchain Engineer
> Disinformation flourishes because many people care deeply about injustice
> but very few check the facts.  Ask me about <https://stallmansupport.org>
diff mbox series

Patch

diff --git a/gcc/testsuite/gcc.dg/signbit-2.c b/gcc/testsuite/gcc.dg/signbit-2.c
index d7b406effc62d..62bb4047d7421 100644
--- a/gcc/testsuite/gcc.dg/signbit-2.c
+++ b/gcc/testsuite/gcc.dg/signbit-2.c
@@ -2,7 +2,7 @@ 
 /* { dg-options "-O3 -fdump-tree-optimized" } */
 
 /* This test does not work when the truth type does not match vector type.  */
-/* { dg-additional-options "-mno-avx512f" { target { i?86-*-* x86_64-*-* } } } */
+/* { dg-additional-options "-msse2 -mno-avx512f" { target { i?86-*-* x86_64-*-* } } } */
 /* { dg-additional-options "-march=armv8-a" { target aarch64_sve } } */
 /* { dg-additional-options "-maltivec" { target powerpc_altivec_ok } } */
 /* { dg-skip-if "no fallback for MVE" { arm_mve } } */