diff mbox series

[05/13] ssa-loop-niter: skip caching of null operands

Message ID	ork02dfpbv.fsf@lxoliva.fsfla.org
State	Accepted
Headers	Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1CACB3858416 To: gcc-patches@gcc.gnu.org Subject: [05/13] ssa-loop-niter: skip caching of null operands Organization: Free thinker, does not speak for AdaCore References: <or5ydxh4l4.fsf@lxoliva.fsfla.org> Date: Tue, 27 Dec 2022 01:22:28 -0300 In-Reply-To: <or5ydxh4l4.fsf@lxoliva.fsfla.org> (Alexandre Oliva's message of "Tue, 27 Dec 2022 01:07:35 -0300") Message-ID: <ork02dfpbv.fsf@lxoliva.fsfla.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: list From: Alexandre Oliva via Gcc-patches <gcc-patches@gcc.gnu.org> Reply-To: Alexandre Oliva <oliva@adacore.com> Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" <gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org> X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
Series	[01/13] scoped tables: insert before further lookups \| [01/13] scoped tables: insert before further lookups [02/13] varpool: do not add NULL vnodes to referenced [03/13] tree-inline decl_map: skip mapping NULL to itself [04/13,C++] constraint: insert norm entry once [05/13] ssa-loop-niter: skip caching of null operands [06/13] tree-inline decl_map: skip mapping result's NULL default def [07/13] postreload-gcse: no insert on mere lookup [08/13] tm: complete tm_restart insertion [09/13,C++] constexpr: request insert iff depth is ok [10/13] lto: drop dummy partition mapping [11/13] ada: don't map NULL decl to locus [12/13] hash set: reject attempts to add empty values [13/13] hash-map: reject empty-looking insertions [14/17] parloops: don't request insert that won't be completed [15/17] prevent hash set/map insertion of deleted entries [16/17] check hash table counts at expand [17/17] check hash table insertions

Checks

Context	Check	Description
snail/gcc-patch-check	success	Github commit url

Commit Message

Alexandre Oliva Dec. 27, 2022, 4:22 a.m. UTC

  When a TREE_OPERAND is NULL, do not cache it.

Regstrapped on x86_64-linux-gnu.  Ok to install?


for  gcc/ChangeLog

	* tree-ssa-loop-niter.cc (expand_simple_operands): Refrain
	from caching NULL TREE_OPERANDs.
---
 gcc/tree-ssa-loop-niter.cc |    2 ++
 1 file changed, 2 insertions(+)

Comments

Jeff Law Dec. 27, 2022, 3:19 p.m. UTC | #1

On 12/26/22 21:22, Alexandre Oliva via Gcc-patches wrote:
> 
> When a TREE_OPERAND is NULL, do not cache it.
> 
> Regstrapped on x86_64-linux-gnu.  Ok to install?
> 
> 
> for  gcc/ChangeLog
> 
> 	* tree-ssa-loop-niter.cc (expand_simple_operands): Refrain
> 	from caching NULL TREE_OPERANDs.
I must admit some curiosity about the NULL operand though.  Do you 
recall what kind of node had a NULL operand and whether or not that was 
a valid state or not?

I just want to make sure this isn't just papering over a deeper issue.

jeff

Alexandre Oliva Dec. 28, 2022, 4:03 a.m. UTC | #2

Hello, Jeff,

On Dec 27, 2022, Jeff Law <jeffreyalaw@gmail.com> wrote:

>> * tree-ssa-loop-niter.cc (expand_simple_operands): Refrain
>> from caching NULL TREE_OPERANDs.

> I must admit some curiosity about the NULL operand though.  Do you
> recall what kind of node had a NULL operand and whether or not that
> was a valid state or not?

I'm pretty sure the case I hit was a CALL_EXPR.

Thanks for the reviews!

Happy GNU Year!

diff mbox series

Patch

diff --git a/gcc/tree-ssa-loop-niter.cc b/gcc/tree-ssa-loop-niter.cc
index fece876099c16..17645648326e8 100644
--- a/gcc/tree-ssa-loop-niter.cc
+++ b/gcc/tree-ssa-loop-niter.cc
@@ -2325,6 +2325,8 @@  expand_simple_operations (tree expr, tree stop, hash_map<tree, tree> &cache)
       for (i = 0; i < n; i++)
 	{
 	  e = TREE_OPERAND (expr, i);
+	  if (!e)
+	    continue;
 	  /* SCEV analysis feeds us with a proper expression
 	     graph matching the SSA graph.  Avoid turning it
 	     into a tree here, thus handle tree sharing