From patchwork Wed Dec 20 02:32:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandre Oliva X-Patchwork-Id: 181422 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:24d3:b0:fb:cd0c:d3e with SMTP id r19csp2374530dyi; Tue, 19 Dec 2023 18:33:28 -0800 (PST) X-Google-Smtp-Source: AGHT+IGiMmJRLEoryFC/nmQ+eKrIQGRrbVdbt+vJ3wZp3SXg0cpmg7KAKfO7OVzbRjDoyi8x1n7x X-Received: by 2002:a05:6830:200e:b0:6d9:d9d2:fb3 with SMTP id e14-20020a056830200e00b006d9d9d20fb3mr18701281otp.73.1703039608172; Tue, 19 Dec 2023 18:33:28 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1703039608; cv=pass; d=google.com; s=arc-20160816; b=iQOI62fDN09EAleRFhSAdmZ1x2T6Hcpu9tfE75Jj3+gpC8KV0SZyfFCdvQOUYNkI+g 9sYlZFzy47v8Ij3YpDXQljOU4hBlQNQHkK45t+/ZWhCcA7qa4U2T9sJhGjrvwZUGvUkp 67NFmIvUSbFJ4rl3eofWGz+knoVKiyqHs95boUKz/3pCWOxggv61RqtqozqzGB7KBqFx X+eRy4+QDR/BYxrlmG01XRS1yMgW9jKX2h9FAIAejX7z1LEz4pOj+1I3BW1uzyACLi5W aTmaIQs0/OqyUuYL+lzZczqKrwgVflIPPXIywaQo7zJCxkTwFnmCHSZasfcfl9p6xGn2 eD/Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:mime-version:user-agent :message-id:in-reply-to:date:references:organization:subject:cc:to :from:arc-filter:dmarc-filter:delivered-to; bh=B/2TlftY/PNwHxraTEMq33E1rct2W7HO5iArb97WYLg=; fh=VFYKhycdV9LwdeSpfTSE1NY4uw7b1/hnBKNw9yjkSQM=; b=HCK31KVeaAQOmL4BN8hxo+thfeMkPwXOxdoVTQp1H3JaKA+MYbxmdiD/laZOfpstQ+ WVdsiWVkpai3amB+0JKAqJTK9/rCTVmktMZlP8PqUhFf7vAJjuIO6XPkPrnk2Kj4gsnR e7/zZcfTHMNQlRh5u7xZlyusq1Vluijqiy5NuYNO1fHP0M0QAXqUi9SFkxmUhbvdl3qA FuqQhHH4lJySgxrjDU5Ord6+T2xVWEKPw+oed1A2TOSPRVmOdnW4hlSGaH4t/2cb0SqE Ye6tY0Tyg2AxUEAMOGaVcgePQh2ht4p0U/iecpnzqHVF8V3dvvfG8/G99BUdWUOJX0ae fskQ== ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id bs25-20020ac86f19000000b00417f76c422fsi1145363qtb.380.2023.12.19.18.33.28 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Dec 2023 18:33:28 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DBBFE3857340 for ; Wed, 20 Dec 2023 02:33:27 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id B82593858439 for ; Wed, 20 Dec 2023 02:33:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B82593858439 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B82593858439 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703039585; cv=none; b=jO3DfxB/o005fFZWMuG9wxrxWlFBQqgcKVAi36ustljx+Z0Ayefa+6OKHd+gfjreycoojfbqjypvPj2wtGRoDEokwLQcaJravrB6E74xzSXoANddTdm8rGN15sxR/Q/fxLcgSd6m18wTQW2Y95Cr3j+Pr8/1aWAPimjpyIw3tTo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703039585; c=relaxed/simple; bh=vCDPpSv3aaOtf0RjRWaXTKi0S6MWWhA3QRxOsiMSGv0=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=mkeOjER4esSEqfnu5z55Kid//QFN9kGwfzSlhQ7NIqDycYwXfjrD1emyr/To7vP9ZZDpAwWilpqacU5ClNIeQ3x4q+APaLrPISr95EFbPcFI/rQ5JPPVXvePuRSEdGYp8E79mzn4owGvOiGrLbqEgRZ8r29WfBlTZ0iGZ7nFevw= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from linux-libre.fsfla.org ([2001:470:142:5::54] helo=free.home) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rFmON-0000Oi-0T; Tue, 19 Dec 2023 21:33:03 -0500 Received: from livre (livre.home [172.31.160.2]) by free.home (8.15.2/8.15.2) with ESMTPS id 3BK2Wq1V674129 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 19 Dec 2023 23:32:53 -0300 From: Alexandre Oliva To: Jeff Law Cc: gcc-patches@gcc.gnu.org Subject: [PATCH FYI] -finline-stringops: copy timeout factor from memcmp-1.c test Organization: Free thinker, not speaking for the GNU Project References: <3d8665b0-d9c0-4da6-bb92-194e2b68494c@ventanamicro.com> Date: Tue, 19 Dec 2023 23:32:52 -0300 In-Reply-To: <3d8665b0-d9c0-4da6-bb92-194e2b68494c@ventanamicro.com> (Jeff Law's message of "Sun, 17 Dec 2023 20:51:53 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 X-Spam-Status: No, score=-8.4 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785766459870495246 X-GMAIL-MSGID: 1785766459870495246 Hi, Jeff, On Dec 18, 2023, Jeff Law wrote: > These are timing sporadically on the embedded platforms. Given they > include a test that has a timeout factor, it seems to me you should > duplicate the timeout factor in the new tests. > Remember when you include another file, the dg- directives in the > other file aren't applied. Thanks for the reminder. Sorry I missed most of them. I added some -finline-stringops tests that included memcmp-1.c, but carried over the timeout factor onto only one such test. Jeff Law kindly pointed that out (thanks!), so here's the fix. Testing on x86_64-linux-gnu. I'll check this in as obvious once testing is done. for gcc/testsuite/ChangeLog * gcc.dg/torture/inline-mem-cmp-1.c: Copy timeout factor from mem-cmp-1.c. * gcc.dg/torture/inline-mem-cpy-1.c: Likewise. --- gcc/testsuite/gcc.dg/torture/inline-mem-cmp-1.c | 1 + gcc/testsuite/gcc.dg/torture/inline-mem-cpy-1.c | 1 + 2 files changed, 2 insertions(+) diff --git a/gcc/testsuite/gcc.dg/torture/inline-mem-cmp-1.c b/gcc/testsuite/gcc.dg/torture/inline-mem-cmp-1.c index a368f0741129d..4bc66597b35a6 100644 --- a/gcc/testsuite/gcc.dg/torture/inline-mem-cmp-1.c +++ b/gcc/testsuite/gcc.dg/torture/inline-mem-cmp-1.c @@ -1,5 +1,6 @@ /* { dg-do run } */ /* { dg-options "-finline-stringops=memcmp -save-temps -g0 -fno-lto" } */ +/* { dg-timeout-factor 2 } */ #include "../memcmp-1.c" diff --git a/gcc/testsuite/gcc.dg/torture/inline-mem-cpy-1.c b/gcc/testsuite/gcc.dg/torture/inline-mem-cpy-1.c index c98e903c1f169..f4952554dd011 100644 --- a/gcc/testsuite/gcc.dg/torture/inline-mem-cpy-1.c +++ b/gcc/testsuite/gcc.dg/torture/inline-mem-cpy-1.c @@ -1,5 +1,6 @@ /* { dg-do run } */ /* { dg-options "-finline-stringops=memcpy -save-temps -g0 -fno-lto" } */ +/* { dg-timeout-factor 2 } */ #include "../memcmp-1.c" /* Yeah, this memcmp test exercises plenty of memcpy, more than any of the