diff mbox series

[FYI] -finline-stringops: copy timeout factor from memcmp-1.c test

Message ID orh6kd38ob.fsf@lxoliva.fsfla.org
State Unresolved
Headers
Series [FYI] -finline-stringops: copy timeout factor from memcmp-1.c test |

Checks

Context Check Description
snail/gcc-patch-check warning Git am fail log

Commit Message

Alexandre Oliva Dec. 20, 2023, 2:32 a.m. UTC 
  Hi, Jeff,

On Dec 18, 2023, Jeff Law <jlaw@ventanamicro.com> wrote:

> These are timing sporadically on the embedded platforms.  Given they
> include a test that has a timeout factor, it seems to me you should 
> duplicate the timeout factor in the new tests.

> Remember when you include another file, the dg- directives in the
> other file aren't applied.

Thanks for the reminder.  Sorry I missed most of them.


I added some -finline-stringops tests that included memcmp-1.c, but
carried over the timeout factor onto only one such test.  Jeff Law
kindly pointed that out (thanks!), so here's the fix.

Testing on x86_64-linux-gnu.  I'll check this in as obvious once testing
is done.


for  gcc/testsuite/ChangeLog

	* gcc.dg/torture/inline-mem-cmp-1.c: Copy timeout factor from
	mem-cmp-1.c.
	* gcc.dg/torture/inline-mem-cpy-1.c: Likewise.
---
 gcc/testsuite/gcc.dg/torture/inline-mem-cmp-1.c |    1 +
 gcc/testsuite/gcc.dg/torture/inline-mem-cpy-1.c |    1 +
 2 files changed, 2 insertions(+)

Comments

Jeff Law Dec. 20, 2023, 3:51 a.m. UTC | #1 
On 12/19/23 19:32, Alexandre Oliva wrote:
> Hi, Jeff,
> 
> On Dec 18, 2023, Jeff Law <jlaw@ventanamicro.com> wrote:
> 
>> These are timing sporadically on the embedded platforms.  Given they
>> include a test that has a timeout factor, it seems to me you should
>> duplicate the timeout factor in the new tests.
> 
>> Remember when you include another file, the dg- directives in the
>> other file aren't applied.
> 
> Thanks for the reminder.  Sorry I missed most of them.
> 
> 
> I added some -finline-stringops tests that included memcmp-1.c, but
> carried over the timeout factor onto only one such test.  Jeff Law
> kindly pointed that out (thanks!), so here's the fix.
> 
> Testing on x86_64-linux-gnu.  I'll check this in as obvious once testing
> is done.
> 
> 
> for  gcc/testsuite/ChangeLog
> 
> 	* gcc.dg/torture/inline-mem-cmp-1.c: Copy timeout factor from
> 	mem-cmp-1.c.
> 	* gcc.dg/torture/inline-mem-cpy-1.c: Likewise.
Thanks.
jeff
diff mbox series

Patch

diff --git a/gcc/testsuite/gcc.dg/torture/inline-mem-cmp-1.c b/gcc/testsuite/gcc.dg/torture/inline-mem-cmp-1.c
index a368f0741129d..4bc66597b35a6 100644
--- a/gcc/testsuite/gcc.dg/torture/inline-mem-cmp-1.c
+++ b/gcc/testsuite/gcc.dg/torture/inline-mem-cmp-1.c
@@ -1,5 +1,6 @@ 
 /* { dg-do run } */
 /* { dg-options "-finline-stringops=memcmp -save-temps -g0 -fno-lto" } */
+/* { dg-timeout-factor 2 } */
 
 #include "../memcmp-1.c"
 
diff --git a/gcc/testsuite/gcc.dg/torture/inline-mem-cpy-1.c b/gcc/testsuite/gcc.dg/torture/inline-mem-cpy-1.c
index c98e903c1f169..f4952554dd011 100644
--- a/gcc/testsuite/gcc.dg/torture/inline-mem-cpy-1.c
+++ b/gcc/testsuite/gcc.dg/torture/inline-mem-cpy-1.c
@@ -1,5 +1,6 @@ 
 /* { dg-do run } */
 /* { dg-options "-finline-stringops=memcpy -save-temps -g0 -fno-lto" } */
+/* { dg-timeout-factor 2 } */
 
 #include "../memcmp-1.c"
 /* Yeah, this memcmp test exercises plenty of memcpy, more than any of the