Message ID | orbknpfp8w.fsf@lxoliva.fsfla.org |
---|---|
State | Accepted |
Headers |
Return-Path: <gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp1219866wrt; Mon, 26 Dec 2022 20:25:09 -0800 (PST) X-Google-Smtp-Source: AMrXdXtw5tbCDOWQt78+xEH5vhymIpDArHSZEcuZYEG5PMYxuA+ojLT1G6aEBeI9xsxYD8Xod5Uz X-Received: by 2002:a17:907:7da1:b0:7c0:d6b6:1ee9 with SMTP id oz33-20020a1709077da100b007c0d6b61ee9mr20173090ejc.11.1672115108945; Mon, 26 Dec 2022 20:25:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672115108; cv=none; d=google.com; s=arc-20160816; b=aSN90TyzQRYkDcybTYAge0s53HRsx1AXXbB/ILlQUpGGd5B3O9/C10fALshbzXYa6v yNKdl6DwizqjrwaRXdqiI4uezduEULnrWbEM+oUpC+yZGWRFyP58Xt9G7gdILXfA2Wj+ at4gkb8vr91HUq6jv/gcAsP81q47kiNvdCZUc7Dh6xj2io0pJvkVesrqbns1XjOqNbse mezwsBiX1g3mYqivmu1cQiuSQGT9geqcHjzgXLeShpWzkHcwaWP4r0wrck3EccZ8wZaZ gq6SJ/O555KVY3YM40V44F3it6xTz38Wc9kNOdNzQWqMn64bS421O7nI1qaTlq9xK47F F6ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:mime-version :user-agent:message-id:in-reply-to:date:references:organization :subject:to:dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=rUtBeNzUuCxSRz2rrUo14KS99/91mJRJ/SsIDlDURqc=; b=maL1eXkuQO0EXNTFDHsO8JoNmB7d74O8AxHu8wEB5EWtyFXU6wWEnnM+uQ8KAmEego PeLsK3+iLtuFTiwgt0aDVPIDNSa7unMTYZbjOP66UVRLMqaEKyYTZIvbddfSZZuqPpcg oGqdLeaTgdPUaMl1HSELZzczvsKo+WM91mPPasNe999x04LvnoZpD70tqKfZOakZnfd+ 5GTBcGBnM502K4lQ1zL1+BdtX0ypP2PU3mgaR71Zseio2XV42NG4j1vbGCZDQPBTYrMy AtpD5lWWfyHNQWAZ8/zthJYAwDm47OmHkdOkwEH8IULBIX9WnYwTMXsXBp39RXoyjxQH jB2Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=AanYDbSX; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id q8-20020a50cc88000000b0047039339346si10017205edi.550.2022.12.26.20.25.08 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Dec 2022 20:25:08 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=AanYDbSX; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 067403858C1F for <ouuuleilei@gmail.com>; Tue, 27 Dec 2022 04:25:08 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 067403858C1F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1672115108; bh=rUtBeNzUuCxSRz2rrUo14KS99/91mJRJ/SsIDlDURqc=; h=To:Subject:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=AanYDbSXBS4GCQbFD9MK0uOG4YFn4i4AjZPyqp6aFbRLothA6RStKASXH8l6xXiao 3z6OE3sapCBlqXV/EvMdsojhz+k8/1Lclh1vsYPgkbOed9ct8TYrrbDJBglAJjrYuc 5WZ7NvPcX7dueA2QJ3VUtWeRNX3tt3pbj5B4cq60= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from rock.gnat.com (rock.gnat.com [205.232.38.15]) by sourceware.org (Postfix) with ESMTPS id 1AC7C3858D32 for <gcc-patches@gcc.gnu.org>; Tue, 27 Dec 2022 04:24:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1AC7C3858D32 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id E3F361162AC; Mon, 26 Dec 2022 23:24:24 -0500 (EST) X-Virus-Scanned: Debian amavisd-new at gnat.com Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 4vPr7Z8F8lnN; Mon, 26 Dec 2022 23:24:24 -0500 (EST) Received: from free.home (tron.gnat.com [IPv6:2620:20:4000:0:46a8:42ff:fe0e:e294]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by rock.gnat.com (Postfix) with ESMTPS id 978801162AB; Mon, 26 Dec 2022 23:24:23 -0500 (EST) Received: from livre (livre.home [172.31.160.2]) by free.home (8.15.2/8.15.2) with ESMTPS id 2BR4OFS9712192 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 27 Dec 2022 01:24:16 -0300 To: gcc-patches@gcc.gnu.org Subject: [07/13] postreload-gcse: no insert on mere lookup Organization: Free thinker, does not speak for AdaCore References: <or5ydxh4l4.fsf@lxoliva.fsfla.org> Date: Tue, 27 Dec 2022 01:24:15 -0300 In-Reply-To: <or5ydxh4l4.fsf@lxoliva.fsfla.org> (Alexandre Oliva's message of "Tue, 27 Dec 2022 01:07:35 -0300") Message-ID: <orbknpfp8w.fsf@lxoliva.fsfla.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.84 X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> From: Alexandre Oliva via Gcc-patches <gcc-patches@gcc.gnu.org> Reply-To: Alexandre Oliva <oliva@adacore.com> Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" <gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org> X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1753339772562959612?= X-GMAIL-MSGID: =?utf-8?q?1753339772562959612?= |
Series |
[01/13] scoped tables: insert before further lookups
|
|
Checks
Context | Check | Description |
---|---|---|
snail/gcc-patch-check | success | Github commit url |
Commit Message
Alexandre Oliva
Dec. 27, 2022, 4:24 a.m. UTC
lookup_expr_in_table is not used for insertions, but it mistakenly used INSERT rather than NO_INSERT. Regstrapped on x86_64-linux-gnu. Ok to install? for gcc/ChangeLog * postreload-gcse.cc (lookup_expr_in_table): Use NO_INSERT. --- gcc/postreload-gcse.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On 12/26/22 21:24, Alexandre Oliva via Gcc-patches wrote: > > lookup_expr_in_table is not used for insertions, but it mistakenly > used INSERT rather than NO_INSERT. > > Regstrapped on x86_64-linux-gnu. Ok to install? > > > for gcc/ChangeLog > > * postreload-gcse.cc (lookup_expr_in_table): Use NO_INSERT. OK jeff
diff --git a/gcc/postreload-gcse.cc b/gcc/postreload-gcse.cc index 1c795b43ca36b..2818f54dedd29 100644 --- a/gcc/postreload-gcse.cc +++ b/gcc/postreload-gcse.cc @@ -447,7 +447,7 @@ lookup_expr_in_table (rtx pat) tmp_expr->hash = hash; tmp_expr->avail_occr = NULL; - slot = expr_table->find_slot_with_hash (tmp_expr, hash, INSERT); + slot = expr_table->find_slot_with_hash (tmp_expr, hash, NO_INSERT); obstack_free (&expr_obstack, tmp_expr); if (!slot)