From patchwork Wed Feb 1 09:55:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Sandiford X-Patchwork-Id: 51260 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp182423wrn; Wed, 1 Feb 2023 01:56:18 -0800 (PST) X-Google-Smtp-Source: AK7set89/AC0ZM49mSpY2pAXQi/LD7Puyr1E0UbBsG1l/QDjPwBKrQE46Xz9fFq5nPW71u48f7R+ X-Received: by 2002:aa7:d343:0:b0:4a2:3118:b02b with SMTP id m3-20020aa7d343000000b004a23118b02bmr6474025edr.40.1675245378467; Wed, 01 Feb 2023 01:56:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675245378; cv=none; d=google.com; s=arc-20160816; b=idgAQYShjdsLDhatnW1u91d5LthCuT/GoM5Z04Q5RUYVYwDNX0FdKCC5pw1dN3E1F4 +iI6fE/ehfhV4G3BI0+yoLkege9q+qVWAqKZQWYPa4ITIyYMAkQNDQxd+yEcixnGJSku YSq+D5LhpiXFzWhns8NIAnW5QEGE8Z+4vOjBWio8TZ+iWOO50DIzy9n0VJqRzajYNsmk xTEoIQyZ39w40JRVd2santnLZ5lC2rWCLc9Ichp0zMQOE/MwHF4D7LZUHZwz2s+i9QZe jbeP+wdYTYb9cwtTRWUdrrI18C4EaROIMiXvGyF4ekozoZ0HWMK9xsp1y5QDQYDVoczS LIBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:mime-version :user-agent:message-id:date:subject:mail-followup-to:to:dmarc-filter :delivered-to:dkim-signature:dkim-filter; bh=CteN3tia6l60xFpZgwLDVDVhqhawa47MVvFH8plmA2w=; b=QXL0wLTfK4/CQxnb5QAk/9EWkz1qWJ09y6lys6VRuI6+/U5ovvx+ccNuNSfxmd5M5W b3oifFvKXzTLtMuCSSGm7ovm09dfPQloDtIN5IOdofOpfPBVmW0PGjoq1qCi68B6+Rq4 hCWifaae7DibYh3W8SfEw19tFdhseVN8YmogOaH2gAWUHIR/yotzjreeGS2U68OkwJMH sntNcC4GFrxJ2UW6cnZR0bSh75KgaLqGfReon3fxESm6siZecHQ4rCrH5+kJJNvUyir5 3E3bKaqZdk6ROc/Pt4gZr1p3M5N/bXzoo1EkIQLnfHHTKTCNydXZZ25DWt0WngedUhj9 7OKw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=q5RipJp+; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id ay14-20020a056402202e00b004a246b0e915si9253690edb.83.2023.02.01.01.56.18 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Feb 2023 01:56:18 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=q5RipJp+; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 868F03858005 for ; Wed, 1 Feb 2023 09:56:17 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 868F03858005 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1675245377; bh=CteN3tia6l60xFpZgwLDVDVhqhawa47MVvFH8plmA2w=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=q5RipJp+GCZ5NlnPqBWRUsUS26SIuQX1hF6Y/UIloFekc9/z9SlOkqmGtIlqN2r5l 2lTyyRx5cArCw2PpgveV6RlSAUIONsiZ0ldixHrVfIxnYMj4d+d0fx1b+VijXMSHca 8O/OTnsx/1brWxcCNqfLnk6JZQY3hO6ac7hKShBk= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id ECA353858005 for ; Wed, 1 Feb 2023 09:55:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org ECA353858005 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B91222F4 for ; Wed, 1 Feb 2023 01:56:13 -0800 (PST) Received: from localhost (e121540-lin.manchester.arm.com [10.32.99.50]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4B06A3F882 for ; Wed, 1 Feb 2023 01:55:31 -0800 (PST) To: gcc-patches@gcc.gnu.org Mail-Followup-To: gcc-patches@gcc.gnu.org, richard.sandiford@arm.com Subject: [pushed] compare-elim: Fix an RTL checking failure Date: Wed, 01 Feb 2023 09:55:30 +0000 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Spam-Status: No, score=-36.3 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_NONE, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Richard Sandiford via Gcc-patches From: Richard Sandiford Reply-To: Richard Sandiford Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756622097920778587?= X-GMAIL-MSGID: =?utf-8?q?1756622097920778587?= find_flags_uses_in_insn used SET_SRC without first checking for a SET. This showed up as an RTL checking failure in g++.dg/torture/pr90994.C on aarch64. Tested on aarch64-linux-gnu & pushed as obvious. Richard gcc/ * compare-elim.cc (find_flags_uses_in_insn): Guard use of SET_SRC. --- gcc/compare-elim.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gcc/compare-elim.cc b/gcc/compare-elim.cc index 5cbd2c027b1..c59dc0cf5a5 100644 --- a/gcc/compare-elim.cc +++ b/gcc/compare-elim.cc @@ -254,7 +254,8 @@ find_flags_uses_in_insn (struct comparison *cmp, rtx_insn *insn) x = PATTERN (insn); if (GET_CODE (x) == PARALLEL) x = XVECEXP (x, 0, 0); - x = SET_SRC (x); + if (GET_CODE (x) == SET) + x = SET_SRC (x); if (GET_CODE (x) == IF_THEN_ELSE) x = XEXP (x, 0); if (COMPARISON_P (x)