From 409fc68cd85953c77e02588057a9eb0d21991475 Mon Sep 17 00:00:00 2001
From: Andrew MacLeod <amacleod@redhat.com>
Date: Tue, 17 Jan 2023 11:14:41 -0500
Subject: [PATCH 2/4] Utilize op1 == op2 when invoking range-ops folding.
If there exists an equivalence relationship between op1 and op2,
any binary operation can be broken into individual operations and
unioned if there are sufficently few elements in the set.
PR tree-optimization/108359
gcc/
* range-op.cc (range_operator::wi_fold_in_parts_equiv): New.
(range_operator::fold_range): If op1 is equivalent to op2 then
invoke new fold_in_parts_equiv to operate on sub-components.
* range-op.h (wi_fold_in_parts_equiv): New prototype.
gcc/testsuite/
* gcc.dg/pr108359.c: New.
---
gcc/range-op.cc | 54 +++++++++++++++++++++++++++++++++
gcc/range-op.h | 6 ++++
gcc/testsuite/gcc.dg/pr108359.c | 52 +++++++++++++++++++++++++++++++
3 files changed, 112 insertions(+)
create mode 100644 gcc/testsuite/gcc.dg/pr108359.c
@@ -160,6 +160,38 @@ range_operator::wi_fold (irange &r, tree type,
r.set_varying (type);
}
+// Call wi_fold when both op1 and op2 are equivalent. Further split small
+// subranges into constants. This can provide better precision.
+// For x + y, when x == y with a range of [0,4] instead of [0, 8] produce
+// [0,0][2, 2][4,4][6, 6][8, 8]
+// LIMIT is the maximum number of elements in range allowed before we
+// do not processs them individually.
+
+void
+range_operator::wi_fold_in_parts_equiv (irange &r, tree type,
+ const wide_int &lh_lb,
+ const wide_int &lh_ub,
+ unsigned limit) const
+{
+ int_range_max tmp;
+ widest_int lh_range = wi::sub (widest_int::from (lh_ub, TYPE_SIGN (type)),
+ widest_int::from (lh_lb, TYPE_SIGN (type)));
+ // if there are 1 to 8 values in the LH range, split them up.
+ r.set_undefined ();
+ if (lh_range >= 0 && lh_range < limit)
+ {
+ for (unsigned x = 0; x <= lh_range; x++)
+ {
+ wide_int val = lh_lb + x;
+ wi_fold (tmp, type, val, val, val, val);
+ r.union_ (tmp);
+ }
+ }
+ // Otherwise just call wi_fold.
+ else
+ wi_fold (r, type, lh_lb, lh_ub, lh_lb, lh_ub);
+}
+
// Call wi_fold, except further split small subranges into constants.
// This can provide better precision. For something 8 >> [0,1]
// Instead of [8, 16], we will produce [8,8][16,16]
@@ -234,6 +266,28 @@ range_operator::fold_range (irange &r, tree type,
unsigned num_lh = lh.num_pairs ();
unsigned num_rh = rh.num_pairs ();
+ // If op1 and op2 are equivalences, then we don't need a complete cross
+ // product, just pairs of matching elements.
+ if (relation_equiv_p (rel) && lh == rh)
+ {
+ int_range_max tmp;
+ r.set_undefined ();
+ for (unsigned x = 0; x < num_lh; ++x)
+ {
+ // If the number of subranges is too high, limit subrange creation.
+ unsigned limit = (r.num_pairs () > 32) ? 0 : 8;
+ wide_int lh_lb = lh.lower_bound (x);
+ wide_int lh_ub = lh.upper_bound (x);
+ wi_fold_in_parts_equiv (tmp, type, lh_lb, lh_ub, limit);
+ r.union_ (tmp);
+ if (r.varying_p ())
+ break;
+ }
+ op1_op2_relation_effect (r, type, lh, rh, rel);
+ update_known_bitmask (r, m_code, lh, rh);
+ return true;
+ }
+
// If both ranges are single pairs, fold directly into the result range.
// If the number of subranges grows too high, produce a summary result as the
// loop becomes exponential with little benefit. See PR 103821.
@@ -109,6 +109,12 @@ protected:
const wide_int &rh_lb,
const wide_int &rh_ub) const;
+ // Called by fold range to split small subranges into parts when op1 == op2
+ void wi_fold_in_parts_equiv (irange &r, tree type,
+ const wide_int &lb,
+ const wide_int &ub,
+ unsigned limit) const;
+
// Tree code of the range operator or ERROR_MARK if unknown.
tree_code m_code;
};
new file mode 100644
@@ -0,0 +1,52 @@
+/* { dg-do compile } */
+/* { dg-options "-O2 -fdump-tree-optimized" } */
+
+/* PR test case. */
+int b = 10;
+int c;
+char e;
+void foo();
+static char(a)(char f, char g) { return f && g == 1 ? 0 : f % g; }
+short(d)(short f, short g) { return f * g; }
+int main() {
+ short h;
+ int i;
+ unsigned j;
+ h = d(b && c, 5);
+ j = h;
+ i = a(h, 237);
+ unsigned k = i;
+ e = i < 0 || k >= 32 ? 0 : i >> k;
+ if (e) {
+ c = 0;
+ foo();
+ }
+}
+
+
+/* Also Check that small ranges are broken down and optimized properly
+ This function should never call foo (). */
+
+int otherfunc (int x, int z) {
+ if (x < 1 || x > 6 )
+ return 0;
+
+ if (x == z)
+ {
+ if (x >> z > 0)
+ foo ();
+ if (x * z > 26 && x * z < 35)
+ foo ();
+ if (x + z == 5)
+ foo ();
+ if ((x + z) % 2 == 1)
+ foo ();
+ if (x / z != 1)
+ foo ();
+
+ }
+ return 0;
+}
+
+
+/* { dg-final { scan-tree-dump-not "foo" "optimized" } } */
--
2.39.0