From patchwork Mon Oct 24 16:38:23 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Stubbs X-Patchwork-Id: 9730 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp548044wru; Mon, 24 Oct 2022 09:40:39 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6FD3ESLZVvP9kUWnxPkp30L/nxTysyeiBuHEIZBIbFvdHrgCFLFMsb+wOvGfqT5za3ntVJ X-Received: by 2002:a17:907:2723:b0:79f:9f1f:2fed with SMTP id d3-20020a170907272300b0079f9f1f2fedmr12365100ejl.188.1666629639186; Mon, 24 Oct 2022 09:40:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666629639; cv=none; d=google.com; s=arc-20160816; b=TRkNrq+F2BqsSoUfxlOf0SBgb87Qn/EYoyFDUwq5a0TMmtmM9Q8M2HBxu0vtTF2tHF glsZ7aMJSxDVuBlQbrUYGmhoUpYUKYIDxyKXVqAN2+6pqVpklW10EUoBGRV1RpFsbW18 RkNrCGyK/Nh66RRnGNgTqBxXBR8elfLg07GJcJtHBrwMkTdbNgBA077nNbLENpa+z8Ii WAxynDH6tf+9catNnb2SGrtbV3mcKUzs6SSSs7LbI3vL++4Ub9NGu8vMqj9NZ+mW4wOK ahkbDv+5fFwvBbXqu090chu8xlhnzMzqLtf2K3CEQ75S6m96NIJI8SkkJcfCsuWa82W8 +5AQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:to:subject:from :content-language:user-agent:mime-version:date:message-id :ironport-sdr:dmarc-filter:delivered-to; bh=VyUvSa45q+aokhypeN4sx6k1afGwnQTWouDkkiZDd00=; b=0dQ9tIqX9iZ1PkqAaJipFgp2M7YLxq+ALroDWwwN0Z7fNTjgFJncNAoFaL6Dszhtvr /UPSSIReOD47j+qCc3SZhFT2caTITofZS4tXHM2yT6RW4eCGTAsC/lb4X1m1vpt9dN5j bjmy2FPnenoJ/tBqy2d5P2L+i4fwcBwJJaUTy34eSppGbYifGT8eH78LP/1UYheowSsG YdD64UIDnRXUXkWMlS2Z43xp5uukam3I5aO2Yu46RvQiGoN3uXgQOj5D3F+AWx3HZ45y +7IJ8Z9F1TrAZmmOqcwFhHKvpPqRERdLbEe+FgDSKoiTfm6izJZ6iOL7WVKApqFKUbL4 NRLA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org" Received: from sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id a24-20020a50c318000000b00458264c2df2si250349edb.164.2022.10.24.09.40.39 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Oct 2022 09:40:39 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org" Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E8A083857B93 for ; Mon, 24 Oct 2022 16:40:37 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from esa1.mentor.iphmx.com (esa1.mentor.iphmx.com [68.232.129.153]) by sourceware.org (Postfix) with ESMTPS id 23FAC3858421 for ; Mon, 24 Oct 2022 16:38:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 23FAC3858421 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.95,209,1661846400"; d="scan'208";a="88141506" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa1.mentor.iphmx.com with ESMTP; 24 Oct 2022 08:38:27 -0800 IronPort-SDR: ZlyGWYItOLe4AfD26D0YVvh3HygIKb3Fjp/SI6BUb5L68brGxAf4BECsqQtOnu3L7CD+1I+ALC hsStWVcBhslBqv1rPXXjCZCOJAyHKBDSJrOenCczxa5b0Jut7Rs1zN8Ea5ItkMSLWQC1pw5mWf +X39Bgx575seG+eJl/MwUDOgRBUrMHmOzeamakCoRiDARINUJ5fdXem1IEY2mWo/vh47B4EwVQ XBiTMuvJQT/zpBjMu4DSzBbu9QajLDpjITLP2Q7/OTNxACMzokujr1roA2wUgE65O7rPQAv5FM G+8= Message-ID: Date: Mon, 24 Oct 2022 17:38:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Content-Language: en-GB From: Andrew Stubbs Subject: [OG12 commit] amdgcn: disallow USM on gfx908 To: "gcc-patches@gcc.gnu.org" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-11.mgc.mentorg.com (139.181.222.11) To svr-ies-mbx-11.mgc.mentorg.com (139.181.222.11) X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, KAM_NUMSUBJECT, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747587841052589456?= X-GMAIL-MSGID: =?utf-8?q?1747587841052589456?= I've committed this patch to the devel/omp/gcc-12 branch. I will have to fold it into my previous OpenMP memory management patch series when I repost it. The GFX908 (MI100) devices only partially support the Unified Shared Memory model that we have, and only then with additional kernel boot parameters. Without that there are unexplained memory access faults at runtime, and it's generally not a good user experience. For this reason we have decided not to support USM on gfx908 in the toolchain. The gfx90a (MI200) devices are still supported. Andrew amdgcn: disallow USM on gfx908 It does work, but not well and only with the amdgpu.noreply=0 kernel boot option. gcc/ChangeLog: * config/gcn/gcn.cc (gcn_init_cumulative_args): Disallow gfx908. diff --git a/gcc/config/gcn/gcn.cc b/gcc/config/gcn/gcn.cc index 9c2fd4c5b8a..720c0a08a13 100644 --- a/gcc/config/gcn/gcn.cc +++ b/gcc/config/gcn/gcn.cc @@ -2905,6 +2905,7 @@ gcn_init_cumulative_args (CUMULATIVE_ARGS *cum /* Argument info to init */ , case PROCESSOR_FIJI: case PROCESSOR_VEGA10: case PROCESSOR_VEGA20: + case PROCESSOR_GFX908: error ("GPU architecture does not support Unified Shared Memory"); default: ;