From patchwork Wed May 24 12:42:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Andrew MacLeod X-Patchwork-Id: 98470 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp2817297vqo; Wed, 24 May 2023 05:43:38 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5NEVjJajMoZEP95GnW2SSj4aQ8EwsxJceYYVlcToybnF7Nb+enQz+02RicvTachwVdt/eV X-Received: by 2002:a17:907:9449:b0:969:cbf4:98fa with SMTP id dl9-20020a170907944900b00969cbf498famr16257922ejc.65.1684932218601; Wed, 24 May 2023 05:43:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684932218; cv=none; d=google.com; s=arc-20160816; b=CnXnHnsjIGGBPbM618MidKWcNDzUSQss8cMERO0X/D9rUqnAAoHc5ypWm+eDQbDdSP wU+/jgGuHClwMF4mn5DP+Vp3CdFD0oZTHyHespw/Sdcn2G8Ek0iMAoS5yAxBIa2RA3ZW OIh8u9ALcYayYcmRFhQD3Aq9rhWjO7WOpQ9l7WtTbYk7Yv4aBQ3V14WDt2yWQLVPAN8U SPBlthcXN0EPltqbujFbxSBKOwCWgJdyzysL4Bzww3B+ur4OtXVkYl5VuUIYuFcyCkcf QZqhHJhatS0H96/00WyGjE0Y82hKJAfcekuEnmbk+cO5Rq95zkGCnN6e6s5eYY36qFjk kjXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:content-language :subject:cc:to:user-agent:mime-version:date:message-id:dmarc-filter :delivered-to:dkim-signature:dkim-filter; bh=EGwPH5mhTVEVuIzrzdqIOvS+XsGfV9clRz43Z80MRqc=; b=ZNSnw7xBuUKkk1j5fSzWV30e4RLnopuouHuYJ2/PW/+CNnxaw6Ywh1ug2Hc0AIMnR3 k+khSj2gHbAxzzoUPP3m9R9gK0g6ABz9VOHfzoBjGEX8Qmvwgx87kAjRYe8c9eRnE6QY rdNCj/Qw4Qyg/3ycKIsBTj9BR1XHTvpuRuXjI72WLe7ey4tg874R9XFFevJnpOgaO2fb BnLL9JqDgmBUxpDGvv3qs2aNfaDUPaF7FCJpx0XeHRCBBXchk/iRPyWNaBTzfSobtdRA MhmV1DkW6Z9tJfzjZ3LwWzrA6YF8OUzLxHw6Cy9Y6t3mVaWWlqnnbqSby1L8dg+08Suh kV5w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=n7obAXF6; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id w20-20020a056402129400b004fbbd7bee7csi6418802edv.58.2023.05.24.05.43.38 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 May 2023 05:43:38 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=n7obAXF6; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 60A7D383906F for ; Wed, 24 May 2023 12:42:58 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 60A7D383906F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1684932178; bh=EGwPH5mhTVEVuIzrzdqIOvS+XsGfV9clRz43Z80MRqc=; h=Date:To:Cc:Subject:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=n7obAXF65hnxEPma4pvY6Jdjdb8oYbKvnnEj7iw/kuYrdXnDuCtRxEBRBOc3XbybD JT0jkbMUxrrMecq44PGfX6kr0zttQP/K3xCOb38/LMDmOkp7uy0ysaLvck9/ID1soF S+TDFZy6JBZXpnKk2P5FEFJTfWg9prKNefhGiO1I= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 2DF44385700C for ; Wed, 24 May 2023 12:42:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2DF44385700C Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-266-Pd-_rXrXMd-tTlNLHiekrw-1; Wed, 24 May 2023 08:42:10 -0400 X-MC-Unique: Pd-_rXrXMd-tTlNLHiekrw-1 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-621257e86daso12524576d6.1 for ; Wed, 24 May 2023 05:42:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684932129; x=1687524129; h=subject:from:cc:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KxIwf/DD6d2C8iJHuUPOlF06DU+m7d+4zc2rTKf2qcg=; b=lUVIaRCIKeDfthlvR2orLhvZphJibAaAC2SgubuGz5byQzRXnt0b77KaZh8IsBQ/zs 8Iw/Pw7myPQTh1+RqbMYS14mXM5qTO+APQ0DhKqz2sTsys1TDaKORZ7FapDBywXmxCis b32twFq+WgLVYWXl8Pt9i1z8grMOD0GqQkZrcQ2KUW0dOKsRgjGjOzV/0q9ZqRRYW4st NUwv8gzhGY4jJ4Akb2Wigp8a0gCUL719tqYtleszqJTB+ZjoxA/ZfauApCjJDrVgZHyr CgzQ9coixtAUrCc76Jv/+fePTPtzP3hKmm/0pwA+mLerop+r4IQG+xMsGisU9kWrNCxT A+Bg== X-Gm-Message-State: AC+VfDwEYu6xHdHZw2+ikrnVyUP4191QeDXHmblO3a5BHQApEaeKoL6Y IVnR7jDneTsBb+VNJnbu8DswExaXpnEEGTb7VzMI23wBOZjBWuOjtj8ijZskfHfF6fZpO/seLrP LqpbEPcophOMWB1x+K/LkjAz/C2Huh7CYzQieQuF9sfxge6gqeLAisgdZI9mcCTeEb5UVMzrsnR fsTQ== X-Received: by 2002:ad4:5d4e:0:b0:623:690c:3ce6 with SMTP id jk14-20020ad45d4e000000b00623690c3ce6mr29737228qvb.32.1684932129072; Wed, 24 May 2023 05:42:09 -0700 (PDT) X-Received: by 2002:ad4:5d4e:0:b0:623:690c:3ce6 with SMTP id jk14-20020ad45d4e000000b00623690c3ce6mr29737209qvb.32.1684932128708; Wed, 24 May 2023 05:42:08 -0700 (PDT) Received: from ?IPV6:2607:fea8:51df:4200::933? ([2607:fea8:51df:4200::933]) by smtp.gmail.com with ESMTPSA id et4-20020a056214176400b005fdbcab3065sm3537243qvb.72.2023.05.24.05.42.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 May 2023 05:42:08 -0700 (PDT) Message-ID: Date: Wed, 24 May 2023 08:42:07 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 To: gcc-patches Cc: "hernandez, aldy" Subject: [COMMITTED 1/3] PR tree-optimization/109695 - Choose better initial values for ranger. X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Andrew MacLeod via Gcc-patches From: Andrew MacLeod Reply-To: Andrew MacLeod Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766779485969463790?= X-GMAIL-MSGID: =?utf-8?q?1766779485969463790?= Instead of defaulting to an initial value of VARYING before resolving cycles, try folding the statement using available global values instead.  THis can give us a much better initial approximation, especially in cases where there are no dependencies, ie    f_45 = 77 This implements suggestion 2) in comment 22 of the PR: 2) The initial value we choose is simply VARYING. This is why 1) alone won't solve this problem.  when we push _1947 on the stack, we set it to VARYING..  then proceed down along chain of other dependencies Driven by _1011 which are resolved first. When we get back to _1947 finally, we see:   _1947 = 77; which evaluated to [77, 77], and is this different than VARYING, and thus would cause a new timestamp to be created even if (1) were implemented. TODO: When setting the initial value in the cache, rather than being lazy and using varying, we should invoke fold_stmt using get_global_range_query ().   This will fold the stmt and produce a result which resolved any ssa-names just using known global values. THis should not be expensive, and gives us a reasonable first approximation.  And for cases like _1947, the final result as well. I stop doing this after inlining because there are some statements which change their evaluation (ie, BUILTIN_IN_CONSTANT)  which causes headaches... and then we  just default to VARYING again or anything which doesn't have a  global SSA range set.. There is a 2.7% hit to VRP to evaluate each statement this additional time, but only 0.09% to overall compile time. Besides, we get it back later in the patch set.. :-) Bootstraps on x86_64-pc-linux-gnu with no regressions.   Pushed. Andrew From 3a20e1a33277bcb16d681b4f3633fcf8cce5a852 Mon Sep 17 00:00:00 2001 From: Andrew MacLeod Date: Tue, 23 May 2023 15:11:44 -0400 Subject: [PATCH 1/3] Choose better initial values for ranger. Instead of defaulting to VARYING, fold the stmt using just global ranges. PR tree-optimization/109695 * gimple-range-cache.cc (ranger_cache::get_global_range): Call fold_range with global query to choose an initial value. --- gcc/gimple-range-cache.cc | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/gcc/gimple-range-cache.cc b/gcc/gimple-range-cache.cc index 07c69ef858a..8ddfd9426c0 100644 --- a/gcc/gimple-range-cache.cc +++ b/gcc/gimple-range-cache.cc @@ -951,7 +951,22 @@ ranger_cache::get_global_range (vrange &r, tree name, bool ¤t_p) || m_temporal->current_p (name, m_gori.depend1 (name), m_gori.depend2 (name)); else - m_globals.set_range (name, r); + { + // If no global value has been set and value is VARYING, fold the stmt + // using just global ranges to get a better initial value. + // After inlining we tend to decide some things are constant, so + // so not do this evaluation after inlining. + if (r.varying_p () && !cfun->after_inlining) + { + gimple *s = SSA_NAME_DEF_STMT (name); + if (gimple_get_lhs (s) == name) + { + if (!fold_range (r, s, get_global_range_query ())) + gimple_range_global (r, name); + } + } + m_globals.set_range (name, r); + } // If the existing value was not current, mark it as always current. if (!current_p) -- 2.40.1