From patchwork Fri Jan 27 17:44:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinath Parvathaneni X-Patchwork-Id: 49551 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp959818wrn; Fri, 27 Jan 2023 09:46:02 -0800 (PST) X-Google-Smtp-Source: AK7set9XyoIMI2wnLD80PDACmCWbs/nzJMFlVvRCWgZPeY2/oc0DQBj1s1ZwvOej2gBzXl7lnlTE X-Received: by 2002:a17:906:1814:b0:87e:a412:589a with SMTP id v20-20020a170906181400b0087ea412589amr1138970eje.65.1674841562704; Fri, 27 Jan 2023 09:46:02 -0800 (PST) Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id 17-20020a170906015100b0086e4e761d7esi6001970ejh.393.2023.01.27.09.46.02 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Jan 2023 09:46:02 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=EqFqKqQl; arc=fail (signature failed); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 52755385B50D for ; Fri, 27 Jan 2023 17:46:01 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 52755385B50D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1674841561; bh=Gtxu6z5QFFGuykgnK8YIHcO++gziVvBcph5bYNVt6lA=; h=To:CC:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=EqFqKqQlVuNz0S17AyROUD4SJhIRtihCTybODllvz+y0y9JbqzGnU8rcGe16yFFRN MZoam4Y5VUOmR8uO92wGInl+X7HEFW88/p83PplnltidlOj+qY03c7AvKMcUDi1Lvl 9EWL5chez8kfJrrZrl7xgo6J1uCCy/j+ABi1PW2c= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on2060.outbound.protection.outlook.com [40.107.241.60]) by sourceware.org (Postfix) with ESMTPS id B7F403858C00 for ; Fri, 27 Jan 2023 17:45:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B7F403858C00 Received: from AS9PR05CA0026.eurprd05.prod.outlook.com (2603:10a6:20b:488::31) by DB9PR08MB9802.eurprd08.prod.outlook.com (2603:10a6:10:45d::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.23; Fri, 27 Jan 2023 17:45:09 +0000 Received: from AM7EUR03FT040.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:488:cafe::4d) by AS9PR05CA0026.outlook.office365.com (2603:10a6:20b:488::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.23 via Frontend Transport; Fri, 27 Jan 2023 17:45:09 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT040.mail.protection.outlook.com (100.127.140.128) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.21 via Frontend Transport; Fri, 27 Jan 2023 17:45:08 +0000 Received: ("Tessian outbound 8038f0863a52:v132"); Fri, 27 Jan 2023 17:45:08 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 49b28c3137efa5ca X-CR-MTA-TID: 64aa7808 Received: from b1ecaa221746.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id AE5ADADB-5145-4A30-88EB-CA803350D561.1; Fri, 27 Jan 2023 17:45:01 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b1ecaa221746.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 27 Jan 2023 17:45:01 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LcZiz/NljJuyrkD4yp3+LBfXLAr/ndqqDUbpL0QYq46QHnN1TMybplsg8ns94r4rj1yOlcRQoVjsVG0TdMpoGkfN5A3/CvSB0h37HTfyrU83Bc5fGfBGR/5BAHYCJXgJZw6Rg1cFZie79RHAAMWz1CyNLCpeKwmL1V+O4sI+yWVyKdSXCbrACMYx1tZbJhliiqFWzCcdteCsS63LYOYfF/rW2gp74MT+tOzyE1gOf9Cax19xnuSWNV8W4jblQpIRvvHmhj6MGMR5df6UhB+RfdzsWP0xITac/7kccYNFVabVslJcJ1AVa89grSR+wbB6jzowTwi0h16fN8+kDi3U9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Gtxu6z5QFFGuykgnK8YIHcO++gziVvBcph5bYNVt6lA=; b=dS9CnKYQs8PuQzyNz+f0mRkI4Df/glPF071eHKNk0YY3+gS010cVHAPXRNaIrZXDH2EFuz5jMJxK7G+IOj5ATEAXKHQNwT9tL+MIw9DogsrJI/5nMLZNQu9qzED1oZyDaCBxNBgSGfSfd4OnA5P7iRuiUP7euG9zmwLgx0tBQMrDR7jGwknGJYiGaY7+ADFZsJTSTISNTZPBoNhIQd+mIUnp0ZbJICW/X5y0TMkjErv7hlR+4sl3VC839fWv02KjUf60LrN3StH5wvAhrfrhk1UvTM6l4+2GJp1MkHlpA0nYuU1vSfo0yMRM276cJ2UWY8sMq1zEemLocTgD9L41mA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=gcc.gnu.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none Received: from AM5PR0202CA0011.eurprd02.prod.outlook.com (2603:10a6:203:69::21) by DB9PR08MB6476.eurprd08.prod.outlook.com (2603:10a6:10:258::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.23; Fri, 27 Jan 2023 17:45:00 +0000 Received: from AM7EUR03FT053.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:69:cafe::b7) by AM5PR0202CA0011.outlook.office365.com (2603:10a6:203:69::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.34 via Frontend Transport; Fri, 27 Jan 2023 17:45:00 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C Received: from nebula.arm.com (40.67.248.234) by AM7EUR03FT053.mail.protection.outlook.com (100.127.140.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6043.22 via Frontend Transport; Fri, 27 Jan 2023 17:44:59 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Fri, 27 Jan 2023 17:44:59 +0000 Received: from e120703.arm.com (10.2.81.20) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Fri, 27 Jan 2023 17:44:59 +0000 MIME-Version: 1.0 To: CC: , , Subject: [PATCH][GCC] arm: Optimize arm-mlib.h header inclusion (pr108505). Date: Fri, 27 Jan 2023 17:44:59 +0000 Message-ID: X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: AM7EUR03FT053:EE_|DB9PR08MB6476:EE_|AM7EUR03FT040:EE_|DB9PR08MB9802:EE_ X-MS-Office365-Filtering-Correlation-Id: 9f4e39d0-0829-4046-fd2f-08db008e3ba3 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: +FLGcBrXZw/2m4U0PeQY8CzuAH8PsBCUPP4kLOx5EVoswuLrb7H7l/HmaRMC5bWAl0pm73TQGr1Rm061Dhb4WnKGBQiHumzdWyxZzZ9JPb7kBKMrtPN/aDkXuKmIWlzsJhbGh7Rb0tzhAyfmJMP4knHX2DlRXGF2ZdxoSwgImcBWoKYAs0E0aK4G7DacAllPflIGxPGFuMOW6imBVB4MtyiqIv40Arll944umTXdwpZoVADm/MxPFh2xoIU5Lygg2oi0d+wziTuBQWKbKbYdTZwR1fny/3QcvHM9PJYwgeC6xJUSNhghJ4ZtcJpNREGWNCsnEbrFvOdw6JcxsfUrdX19T2w2+2JGH11CZU9ncKTLMuy7hqO3QSd2zrhFL2ATF0W8xPJdH3io5it0822efmUfqmbUQ9FIKOoKARVSLRd0OAsCpWbcMg684DrrZQVYG0JfaxbLRvdcKYdnhgNVqBEOSJZOQxJECinHeKaXswDfViqbe/bl+nelEI2hE0KPHFtIyUzpWNav6fbmSI8v4wZ+fUxOnMZQ5a4k6aoxd06Es7SCumxkQCbigGNcXQ6aEU245PXNBownYH/h/LFrVls6x6G4heDZCD3h+jzdvqlJ+RrXDh5ouOhcBCgHaajKAx+kCxTgf6qgQnhVxk1scmP3MSRG0NNkGbCwY3svKk23uh1ppNpqgn0V/DVa6SLIQ/myMc97jv0TsKa4Jnxiu8aBYbjG9Hj97ujLAG/ispZehK8gw4Q3y8tl27QR0kEl4mJVV2bkpZqidyuisONzPw== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:nebula.arm.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230025)(4636009)(376002)(396003)(136003)(346002)(39860400002)(451199018)(46966006)(40470700004)(36840700001)(70206006)(4326008)(41300700001)(8676002)(70586007)(6916009)(31686004)(8936002)(316002)(5660300002)(235185007)(81166007)(40460700003)(40480700001)(44832011)(54906003)(2906002)(356005)(426003)(36860700001)(31696002)(47076005)(336012)(86362001)(478600001)(82740400003)(33964004)(26005)(966005)(186003)(82310400005)(36900700001); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6476 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT040.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: f9ab2109-1104-42b5-16be-08db008e3657 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FhhYyW+SPfO2cF7JU4rjyhjmg/BxodpA9fHu1R2ydj+cyoXTnJKy0GRXDn7WUxr0ghfb/bk0ofxQEC8EI0MoCxze8AbIOI5wFy+mC5U4r95gCdkPVkXkloersXA5WuQPhwtxBHPJtJapRixvBMWFbZSpe6hkrPrVFeCYSBPJiPfEXpyCY/wzkhvh8hMQTmSR8TE5LWSOwlFbOxwSajqqfnZUm4hUsV2lb7aSRtlC6wd/hrJFNWCTuqWmOcEAMP2Z5/nskYXMYMuXroKCFuFEUutkVL8xNoyNXZeLqqxGxUokOUJ3KphUL4nmwMKra/5+FObJqvpbadgssk9gLkvQmjxtqKYNQjZ0dnJu8ZbwOYkdSSThQ9ckSwIDlsvZeZXL6HU9esUf5RHiU4UnDk8aq333XHKgTkJq1Ss+UcauW9B2rDd9aM2lckN1OEY9m/Ql2gsy7m4fgsKQMGlj3XArfBTSkjAgTWY75WLbJVc2edYHm+fPW6cbRQOGcvocjPtytHCmd9P1l9A6ZX8mdCMwUA+bIGz244i+tFgiXmM6IgsQL4vB/Kp8d29IlYZxKycN9+hMG9HHag5pkVrMHYHYPprxmczpt0EVrLyyJQaDQ8shVxHrXxvJT8J11+DkOH8ZGfrurMYtNhECPv1Gj7humJC48rlqZf0wXfGNI3fQbyeEoo0e18n7WV8nCd4G2ErWrhKIsZfulLypvNRIUp4va6wiSqLV/THcFjNOifhgLIBxxVmInZ7LjOvSN6bunZoOfGwVEkOOITqhfp7u2Nszxd9JL+hhEefIfxn+h9LYG4s= X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230025)(4636009)(136003)(39860400002)(376002)(346002)(396003)(451199018)(40470700004)(46966006)(36840700001)(82740400003)(186003)(26005)(31686004)(36860700001)(5660300002)(235185007)(44832011)(81166007)(336012)(33964004)(2906002)(8936002)(40460700003)(41300700001)(47076005)(8676002)(478600001)(86362001)(82310400005)(6916009)(4326008)(966005)(316002)(70206006)(70586007)(40480700001)(31696002)(54906003)(426003); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jan 2023 17:45:08.8391 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9f4e39d0-0829-4046-fd2f-08db008e3ba3 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT040.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB9802 X-Spam-Status: No, score=-12.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FORGED_SPF_HELO, GIT_PATCH_0, KAM_DMARC_NONE, KAM_SHORT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Srinath Parvathaneni via Gcc-patches From: Srinath Parvathaneni Reply-To: Srinath Parvathaneni Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756198666399077730?= X-GMAIL-MSGID: =?utf-8?q?1756198666399077730?= Hello, I have committed a fix [1] into gcc trunk for a build issue mentioned in pr108505 and latter received few upstream comments proposing more robust fix for this issue. In this patch I'm addressing those comments and sending this as a followup patch. Regression tested on arm-none-eabi target and found no regressions. Ok for master? [1] https://gcc.gnu.org/pipermail/gcc-patches/2023-January/610513.html Regards, Srinath. gcc/ChangeLog: 2023-01-27 Srinath Parvathaneni PR target/108505 * config.gcc (tm_mlib_file): Define new variable. ############### Attachment also inlined for ease of reply ############### diff --git a/gcc/config.gcc b/gcc/config.gcc index 89f56047cfe3126bc6c8e90c8b4840dea13538f9..2aab92bbfd8b4088259ebf9b565af8e8bbef1122 100644 --- a/gcc/config.gcc +++ b/gcc/config.gcc @@ -4355,6 +4355,7 @@ case "${target}" in case ${arm_multilib} in aprofile|rmprofile) tmake_profile_file="arm/t-multilib" + tm_mlib_file="arm/arm-mlib.h" ;; @*) ml=`echo "X$arm_multilib" | sed '1s,^X@,,'` @@ -4393,7 +4394,7 @@ case "${target}" in # through to the multilib selector with_float="soft" tmake_file="${tmake_file} ${tmake_profile_file}" - tm_file="$tm_file arm/arm-mlib.h" + tm_file="$tm_file $tm_mlib_file" TM_MULTILIB_CONFIG="$with_multilib_list" fi fi diff --git a/gcc/config.gcc b/gcc/config.gcc index 89f56047cfe3126bc6c8e90c8b4840dea13538f9..2aab92bbfd8b4088259ebf9b565af8e8bbef1122 100644 --- a/gcc/config.gcc +++ b/gcc/config.gcc @@ -4355,6 +4355,7 @@ case "${target}" in case ${arm_multilib} in aprofile|rmprofile) tmake_profile_file="arm/t-multilib" + tm_mlib_file="arm/arm-mlib.h" ;; @*) ml=`echo "X$arm_multilib" | sed '1s,^X@,,'` @@ -4393,7 +4394,7 @@ case "${target}" in # through to the multilib selector with_float="soft" tmake_file="${tmake_file} ${tmake_profile_file}" - tm_file="$tm_file arm/arm-mlib.h" + tm_file="$tm_file $tm_mlib_file" TM_MULTILIB_CONFIG="$with_multilib_list" fi fi