diff mbox series

[GCC] arm: Optimize arm-mlib.h header inclusion (pr108505).

Message ID e6ca16d1-28d9-463e-bbed-ce6dfad7a887@AZ-NEU-EX04.Arm.com
State Not Applicable
Headers
Series [GCC] arm: Optimize arm-mlib.h header inclusion (pr108505). |

Checks

Context Check Description
snail/gcc-patch-check fail Git am fail log

Commit Message

Srinath Parvathaneni Jan. 27, 2023, 5:44 p.m. UTC 
  Hello,

I have committed a fix [1] into gcc trunk for a build issue mentioned in pr108505 and
latter received few upstream comments proposing more robust fix for this issue.

In this patch I'm addressing those comments and sending this as a followup patch.

Regression tested on arm-none-eabi target and found no regressions.

Ok for master?

[1] https://gcc.gnu.org/pipermail/gcc-patches/2023-January/610513.html

Regards,
Srinath.

gcc/ChangeLog:

2023-01-27  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>

        PR target/108505
        * config.gcc (tm_mlib_file): Define new variable.


###############     Attachment also inlined for ease of reply    ###############
diff --git a/gcc/config.gcc b/gcc/config.gcc
index 89f56047cfe3126bc6c8e90c8b4840dea13538f9..2aab92bbfd8b4088259ebf9b565af8e8bbef1122 100644
--- a/gcc/config.gcc
+++ b/gcc/config.gcc
@@ -4355,6 +4355,7 @@ case "${target}" in
 					case ${arm_multilib} in
 					aprofile|rmprofile)
 						tmake_profile_file="arm/t-multilib"
+						tm_mlib_file="arm/arm-mlib.h"
 						;;
 					@*)
 						ml=`echo "X$arm_multilib" | sed '1s,^X@,,'`
@@ -4393,7 +4394,7 @@ case "${target}" in
 				# through to the multilib selector
 				with_float="soft"
 				tmake_file="${tmake_file} ${tmake_profile_file}"
-				tm_file="$tm_file arm/arm-mlib.h"
+				tm_file="$tm_file $tm_mlib_file"
 				TM_MULTILIB_CONFIG="$with_multilib_list"
 			fi
 		fi

Comments

Srinath Parvathaneni Feb. 2, 2023, 12:16 p.m. UTC | #1 
Ping!!
Richard Earnshaw Feb. 8, 2023, 9:45 a.m. UTC | #2 
On 27/01/2023 17:44, Srinath Parvathaneni via Gcc-patches wrote:
> Hello,
> 
> I have committed a fix [1] into gcc trunk for a build issue mentioned in pr108505 and
> latter received few upstream comments proposing more robust fix for this issue.
> 
> In this patch I'm addressing those comments and sending this as a followup patch.
> 
> Regression tested on arm-none-eabi target and found no regressions.
> 
> Ok for master?
> 

OK.  But please correct the syntax for the PR in the subject.  It should 
be "[PR...]" not "(PR...)".

R.

> [1] https://gcc.gnu.org/pipermail/gcc-patches/2023-January/610513.html
> 
> Regards,
> Srinath.
> 
> gcc/ChangeLog:
> 
> 2023-01-27  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
> 
>          PR target/108505
>          * config.gcc (tm_mlib_file): Define new variable.
> 
> 
> ###############     Attachment also inlined for ease of reply    ###############
> 
> 
> diff --git a/gcc/config.gcc b/gcc/config.gcc
> index 89f56047cfe3126bc6c8e90c8b4840dea13538f9..2aab92bbfd8b4088259ebf9b565af8e8bbef1122 100644
> --- a/gcc/config.gcc
> +++ b/gcc/config.gcc
> @@ -4355,6 +4355,7 @@ case "${target}" in
>   					case ${arm_multilib} in
>   					aprofile|rmprofile)
>   						tmake_profile_file="arm/t-multilib"
> +						tm_mlib_file="arm/arm-mlib.h"
>   						;;
>   					@*)
>   						ml=`echo "X$arm_multilib" | sed '1s,^X@,,'`
> @@ -4393,7 +4394,7 @@ case "${target}" in
>   				# through to the multilib selector
>   				with_float="soft"
>   				tmake_file="${tmake_file} ${tmake_profile_file}"
> -				tm_file="$tm_file arm/arm-mlib.h"
> +				tm_file="$tm_file $tm_mlib_file"
>   				TM_MULTILIB_CONFIG="$with_multilib_list"
>   			fi
>   		fi
> 
> 
>
diff mbox series

Patch

diff --git a/gcc/config.gcc b/gcc/config.gcc
index 89f56047cfe3126bc6c8e90c8b4840dea13538f9..2aab92bbfd8b4088259ebf9b565af8e8bbef1122 100644
--- a/gcc/config.gcc
+++ b/gcc/config.gcc
@@ -4355,6 +4355,7 @@  case "${target}" in
 					case ${arm_multilib} in
 					aprofile|rmprofile)
 						tmake_profile_file="arm/t-multilib"
+						tm_mlib_file="arm/arm-mlib.h"
 						;;
 					@*)
 						ml=`echo "X$arm_multilib" | sed '1s,^X@,,'`
@@ -4393,7 +4394,7 @@  case "${target}" in
 				# through to the multilib selector
 				with_float="soft"
 				tmake_file="${tmake_file} ${tmake_profile_file}"
-				tm_file="$tm_file arm/arm-mlib.h"
+				tm_file="$tm_file $tm_mlib_file"
 				TM_MULTILIB_CONFIG="$with_multilib_list"
 			fi
 		fi