diff mbox series

configure: deprecate --enable-link-mutex option

Message ID e114ac92-17fe-a0c0-b68a-3585910b70e4@suse.cz
State Accepted
Headers
Series configure: deprecate --enable-link-mutex option |

Checks

Context Check Description
snail/gcc-patch-check success Github commit url

Commit Message

Martin Liška March 29, 2023, 12:55 p.m. UTC 
  Ready to be installed?
Thanks,
Martin

	PR bootstrap/109310

gcc/ChangeLog:

	* configure.ac: Emit a warning for deprecated option
	--enable-link-mutex.
	* configure: Regenerate.
---
 gcc/configure    | 1 +
 gcc/configure.ac | 1 +
 2 files changed, 2 insertions(+)

Comments

Jakub Jelinek March 29, 2023, 1 p.m. UTC | #1 
On Wed, Mar 29, 2023 at 02:55:01PM +0200, Martin Liška wrote:
> Ready to be installed?
> Thanks,
> Martin
> 
> 	PR bootstrap/109310
> 
> gcc/ChangeLog:
> 
> 	* configure.ac: Emit a warning for deprecated option
> 	--enable-link-mutex.
> 	* configure: Regenerate.

LGTM.

> diff --git a/gcc/configure b/gcc/configure
> index 15086578533..09ae93ade1a 100755
> --- a/gcc/configure
> +++ b/gcc/configure
> @@ -31468,6 +31468,7 @@ $as_echo "$do_link_mutex" >&6; }
>  
>  if test "$do_link_mutex" = "yes"; then
>     DO_LINK_MUTEX=true
> +   echo gcc/configure: WARNING: --enable-link-mutex is deprecated and will be removed in the next release, use --enable-link-serialization instead 1>&2
>  else
>     DO_LINK_MUTEX=false
>  fi
> diff --git a/gcc/configure.ac b/gcc/configure.ac
> index 120151c474a..13c1a85851c 100644
> --- a/gcc/configure.ac
> +++ b/gcc/configure.ac
> @@ -7013,6 +7013,7 @@ AC_MSG_RESULT($do_link_mutex)
>  
>  if test "$do_link_mutex" = "yes"; then
>     DO_LINK_MUTEX=true
> +   echo gcc/configure: WARNING: --enable-link-mutex is deprecated and will be removed in the next release, use --enable-link-serialization instead 1>&2
>  else
>     DO_LINK_MUTEX=false
>  fi
> -- 
> 2.40.0

	Jakub
Andreas Schwab March 29, 2023, 1:02 p.m. UTC | #2 
On Mär 29 2023, Martin Liška wrote:

> diff --git a/gcc/configure.ac b/gcc/configure.ac
> index 120151c474a..13c1a85851c 100644
> --- a/gcc/configure.ac
> +++ b/gcc/configure.ac
> @@ -7013,6 +7013,7 @@ AC_MSG_RESULT($do_link_mutex)
>  
>  if test "$do_link_mutex" = "yes"; then
>     DO_LINK_MUTEX=true
> +   echo gcc/configure: WARNING: --enable-link-mutex is deprecated and will be removed in the next release, use --enable-link-serialization instead 1>&2

Please use AC_MSG_WARN.
Martin Liška March 29, 2023, 1:05 p.m. UTC | #3 
On 3/29/23 15:02, Andreas Schwab wrote:
> On Mär 29 2023, Martin Liška wrote:
> 
>> diff --git a/gcc/configure.ac b/gcc/configure.ac
>> index 120151c474a..13c1a85851c 100644
>> --- a/gcc/configure.ac
>> +++ b/gcc/configure.ac
>> @@ -7013,6 +7013,7 @@ AC_MSG_RESULT($do_link_mutex)
>>  
>>  if test "$do_link_mutex" = "yes"; then
>>     DO_LINK_MUTEX=true
>> +   echo gcc/configure: WARNING: --enable-link-mutex is deprecated and will be removed in the next release, use --enable-link-serialization instead 1>&2
> 
> Please use AC_MSG_WARN.
> 

Good point Andreas, installed as 8b2766e87db.

Thanks,
Martin
Richard Biener March 29, 2023, 1:05 p.m. UTC | #4 
On Wed, Mar 29, 2023 at 3:01 PM Jakub Jelinek via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> On Wed, Mar 29, 2023 at 02:55:01PM +0200, Martin Liška wrote:
> > Ready to be installed?
> > Thanks,
> > Martin
> >
> >       PR bootstrap/109310
> >
> > gcc/ChangeLog:
> >
> >       * configure.ac: Emit a warning for deprecated option
> >       --enable-link-mutex.
> >       * configure: Regenerate.
>
> LGTM.

I wonder if we can simply alias --enable-link-mutex to
--enable-link-serialization though.

> > diff --git a/gcc/configure b/gcc/configure
> > index 15086578533..09ae93ade1a 100755
> > --- a/gcc/configure
> > +++ b/gcc/configure
> > @@ -31468,6 +31468,7 @@ $as_echo "$do_link_mutex" >&6; }
> >
> >  if test "$do_link_mutex" = "yes"; then
> >     DO_LINK_MUTEX=true
> > +   echo gcc/configure: WARNING: --enable-link-mutex is deprecated and will be removed in the next release, use --enable-link-serialization instead 1>&2
> >  else
> >     DO_LINK_MUTEX=false
> >  fi
> > diff --git a/gcc/configure.ac b/gcc/configure.ac
> > index 120151c474a..13c1a85851c 100644
> > --- a/gcc/configure.ac
> > +++ b/gcc/configure.ac
> > @@ -7013,6 +7013,7 @@ AC_MSG_RESULT($do_link_mutex)
> >
> >  if test "$do_link_mutex" = "yes"; then
> >     DO_LINK_MUTEX=true
> > +   echo gcc/configure: WARNING: --enable-link-mutex is deprecated and will be removed in the next release, use --enable-link-serialization instead 1>&2
> >  else
> >     DO_LINK_MUTEX=false
> >  fi
> > --
> > 2.40.0
>
>         Jakub
>
Martin Liška March 29, 2023, 1:09 p.m. UTC | #5 
On 3/29/23 15:05, Richard Biener wrote:
> I wonder if we can simply alias --enable-link-mutex to
> --enable-link-serialization though.

Sure, we can. Do you want it for gcc-13 as well?

Cheers,
Martin
diff mbox series

Patch

diff --git a/gcc/configure b/gcc/configure
index 15086578533..09ae93ade1a 100755
--- a/gcc/configure
+++ b/gcc/configure
@@ -31468,6 +31468,7 @@  $as_echo "$do_link_mutex" >&6; }
 
 if test "$do_link_mutex" = "yes"; then
    DO_LINK_MUTEX=true
+   echo gcc/configure: WARNING: --enable-link-mutex is deprecated and will be removed in the next release, use --enable-link-serialization instead 1>&2
 else
    DO_LINK_MUTEX=false
 fi
diff --git a/gcc/configure.ac b/gcc/configure.ac
index 120151c474a..13c1a85851c 100644
--- a/gcc/configure.ac
+++ b/gcc/configure.ac
@@ -7013,6 +7013,7 @@  AC_MSG_RESULT($do_link_mutex)
 
 if test "$do_link_mutex" = "yes"; then
    DO_LINK_MUTEX=true
+   echo gcc/configure: WARNING: --enable-link-mutex is deprecated and will be removed in the next release, use --enable-link-serialization instead 1>&2
 else
    DO_LINK_MUTEX=false
 fi