Message ID | ddd7f9cd-994e-0baf-33a3-34c27539f2b1@arm.com |
---|---|
State | Accepted |
Headers |
Return-Path: <gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a6b2:0:b0:3e4:2afc:c1 with SMTP id c18csp379999vqm; Tue, 11 Jul 2023 03:38:10 -0700 (PDT) X-Google-Smtp-Source: APBJJlEQJCTRVLqwNnUY3Hhzl5l2wiEF/sesgCeRhjcXbpbs3HF1gP0cbmsPJCTr6LEudD877Ipj X-Received: by 2002:a17:906:39da:b0:98d:ef34:c0c8 with SMTP id i26-20020a17090639da00b0098def34c0c8mr11914606eje.67.1689071890045; Tue, 11 Jul 2023 03:38:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689071890; cv=none; d=google.com; s=arc-20160816; b=fMOUpjmif2nRPO6V/bFcrKVJHNaW1VRxT8FI6O2o53A7HCCbx2jluU7sbbLhV+8zN/ RiyXOInGWrDmQQl0qLZuyqTR27fVIft8ElL0tfTXpw+yeKJ8hK97fgzOMj0TePLzVzsl fHNORi4yWFJ//4Bqfgi52wx58Bu5mqlJZ4VVUBe0Vy6HIyMhmsVnpuO6HwEv3RSTIMo6 dKKYp4i+N+x76tBAssH/dbRe3TR8hXt32UxSAUq27bfjZ0VbeVEM2+2ki7vrFtsZB24B fKEOux8xK3saFRmNMrmcb5KGdA9s/0HLAfq4FDv3Vmsdx+R09t7Jy+khmE4aDAJSBS6V lx+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:cc:subject:to :content-language:user-agent:mime-version:date:message-id :dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=1BRuwu/C1ij5pWkjByFr/9CwOvg5ORpLVPhPUjAZHEA=; fh=XBkaWjUp/BVetsRHRBAXTD09KAwxV8odwxJbWV+Nunk=; b=yj6BeN664jXaHIVo+aJvSaxvmwfqZiQgyJUijj0sl7r4IjHTskft14FchLXWARZAQ0 U2gX530/+y83IR7DcjyMLOybVCRqjRUVNIqEo2FPcbRTh8eyWaVTpS8q8aMhKPFiE/R7 RJezUCnvVqSh2wh1PBu8NK0gMaaoGkfY0feLJ0gzrU9vliveGv3q9TGg3bIzL8JEy/1E W1w6+CXMbMXwuz3FxtXoYwo1oHsX0yAet50K4a8xUXepPqM0DCgaEctuatEXU0PzfdCT AnhKhSXH7lvfhr8PldZr+q8PHMQbY0LRuM19YoFJbT8AekUXIpa/LmUH7gM3R/9ZSTOW ojgQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=iLiWdfG8; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id gl13-20020a170906e0cd00b00988b6ffa850si1636846ejb.1028.2023.07.11.03.38.09 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jul 2023 03:38:10 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=iLiWdfG8; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B7E2E3857704 for <ouuuleilei@gmail.com>; Tue, 11 Jul 2023 10:38:08 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B7E2E3857704 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1689071888; bh=1BRuwu/C1ij5pWkjByFr/9CwOvg5ORpLVPhPUjAZHEA=; h=Date:To:Subject:Cc:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=iLiWdfG8p2/wU99sI7vwRUqHsF1skrfxghQ7NwWXIetCpnX9LM9jeueDPOz4uylTS aj9mWDbSvjAohDxBLKcVL7AAOm1raE3pOBAfdmPmh8nGhw2iqAw/YD7PqIPsrhDh0J VodHY7Xizced9mokyOYobDiUNgjq64NBfQX8rDLw= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id EC3533858408 for <gcc-patches@gcc.gnu.org>; Tue, 11 Jul 2023 10:37:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EC3533858408 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8E09B2B; Tue, 11 Jul 2023 03:38:07 -0700 (PDT) Received: from [10.1.35.190] (E121495.Arm.com [10.1.35.190]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E47263F67D; Tue, 11 Jul 2023 03:37:24 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------l5kGqEhH4GmIKTetUZmTxGIZ" Message-ID: <ddd7f9cd-994e-0baf-33a3-34c27539f2b1@arm.com> Date: Tue, 11 Jul 2023 11:37:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Content-Language: en-US To: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org> Subject: [PATCH] Include insn-opinit.h in PLUGIN_H [PR110610] Cc: "jakub@redhat.com" <jakub@redhat.com>, Andrew Pinski <pinskia@gmail.com> X-Spam-Status: No, score=-14.3 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_NONE, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> From: "Andre Vieira \(lists\) via Gcc-patches" <gcc-patches@gcc.gnu.org> Reply-To: "Andre Vieira \(lists\)" <andre.simoesdiasvieira@arm.com> Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" <gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org> X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771120246377412502 X-GMAIL-MSGID: 1771120246377412502 |
Series |
Include insn-opinit.h in PLUGIN_H [PR110610]
|
|
Checks
Context | Check | Description |
---|---|---|
snail/gcc-patch-check | success | Github commit url |
Commit Message
Andre Vieira (lists)
July 11, 2023, 10:37 a.m. UTC
Hi, This patch fixes PR110610 by including OPTABS_H in the INTERNAL_FN_H list, as insn-opinit.h is now required by internal-fn.h. This will lead to insn-opinit.h, among the other OPTABS_H header files, being installed in the plugin directory. Bootstrapped aarch64-unknown-linux-gnu. @Jakub: could you check to see if it also addresses PR 110284? gcc/ChangeLog: PR 110610 * Makefile.in (INTERNAL_FN_H): Add OPTABS_H.
Comments
On 7/11/23 04:37, Andre Vieira (lists) via Gcc-patches wrote: > Hi, > > This patch fixes PR110610 by including OPTABS_H in the INTERNAL_FN_H > list, as insn-opinit.h is now required by internal-fn.h. This will lead > to insn-opinit.h, among the other OPTABS_H header files, being installed > in the plugin directory. > > Bootstrapped aarch64-unknown-linux-gnu. > > @Jakub: could you check to see if it also addresses PR 110284? > > > gcc/ChangeLog: > > PR 110610 > * Makefile.in (INTERNAL_FN_H): Add OPTABS_H. Why use OPTABS_H here? Isn't the new dependency just on insn-opinit.h and insn-codes.h and neither of those #include other headers do they? Jeff
On 11/07/2023 23:28, Jeff Law wrote: > > > On 7/11/23 04:37, Andre Vieira (lists) via Gcc-patches wrote: >> Hi, >> >> This patch fixes PR110610 by including OPTABS_H in the INTERNAL_FN_H >> list, as insn-opinit.h is now required by internal-fn.h. This will >> lead to insn-opinit.h, among the other OPTABS_H header files, being >> installed in the plugin directory. >> >> Bootstrapped aarch64-unknown-linux-gnu. >> >> @Jakub: could you check to see if it also addresses PR 110284? >> >> >> gcc/ChangeLog: >> >> PR 110610 >> * Makefile.in (INTERNAL_FN_H): Add OPTABS_H. > Why use OPTABS_H here? Isn't the new dependency just on insn-opinit.h > and insn-codes.h and neither of those #include other headers do they? > > Yeah, there was no particular reason other than I just felt the Makefile structure sort of lend itself that way. I checked genopinit.cc and it seems insn-opinit.h doesn't include any other header files, only the sources do, so I've changed the patch to only add insn-opinit.h to INTERNAL_FN_H. ------------------- This patch fixes PR110610 by including insn-opinit.h in the INTERNAL_FN_H list, as insn-opinit.h is now required by internal-fn.h. This will lead to insn-opinit.h, among the other OPTABS_H header files, being installed in the plugin directory. Bootstrapped aarch64-unknown-linux-gnu. gcc/ChangeLog: PR 110610 * Makefile.in (INTERNAL_FN_H): Add insn-opinit.h. diff --git a/gcc/Makefile.in b/gcc/Makefile.in index c478ec852013eae65b9f3ec0a443e023c7d8b452..683774ad446d545362644d2dbdc37723eea55bc3 100644 --- a/gcc/Makefile.in +++ b/gcc/Makefile.in @@ -976,7 +976,7 @@ READ_MD_H = $(OBSTACK_H) $(HASHTAB_H) read-md.h BUILTINS_DEF = builtins.def sync-builtins.def omp-builtins.def \ gtm-builtins.def sanitizer.def INTERNAL_FN_DEF = internal-fn.def -INTERNAL_FN_H = internal-fn.h $(INTERNAL_FN_DEF) +INTERNAL_FN_H = internal-fn.h $(INTERNAL_FN_DEF) insn-opinit.h TREE_CORE_H = tree-core.h $(CORETYPES_H) all-tree.def tree.def \ c-family/c-common.def $(lang_tree_files) \ $(BUILTINS_DEF) $(INPUT_H) statistics.h \
On 7/17/23 05:55, Andre Vieira (lists) wrote: > > > On 11/07/2023 23:28, Jeff Law wrote: >> >> >> On 7/11/23 04:37, Andre Vieira (lists) via Gcc-patches wrote: >>> Hi, >>> >>> This patch fixes PR110610 by including OPTABS_H in the INTERNAL_FN_H >>> list, as insn-opinit.h is now required by internal-fn.h. This will >>> lead to insn-opinit.h, among the other OPTABS_H header files, being >>> installed in the plugin directory. >>> >>> Bootstrapped aarch64-unknown-linux-gnu. >>> >>> @Jakub: could you check to see if it also addresses PR 110284? >>> >>> >>> gcc/ChangeLog: >>> >>> PR 110610 >>> * Makefile.in (INTERNAL_FN_H): Add OPTABS_H. >> Why use OPTABS_H here? Isn't the new dependency just on insn-opinit.h >> and insn-codes.h and neither of those #include other headers do they? >> >> > > Yeah, there was no particular reason other than I just felt the Makefile > structure sort of lend itself that way. I checked genopinit.cc and it > seems insn-opinit.h doesn't include any other header files, only the > sources do, so I've changed the patch to only add insn-opinit.h to > INTERNAL_FN_H. > > ------------------- > > This patch fixes PR110610 by including insn-opinit.h in the > INTERNAL_FN_H list, as insn-opinit.h is now required by internal-fn.h. > This will lead to insn-opinit.h, among the other OPTABS_H header files, > being installed in the plugin directory. > > Bootstrapped aarch64-unknown-linux-gnu. > > gcc/ChangeLog: > PR 110610 > * Makefile.in (INTERNAL_FN_H): Add insn-opinit.h. OK jeff
diff --git a/gcc/Makefile.in b/gcc/Makefile.in index c478ec852013eae65b9f3ec0a443e023c7d8b452..d3ff210ee04414f4e238c087400dd21e1cb0fc18 100644 --- a/gcc/Makefile.in +++ b/gcc/Makefile.in @@ -976,7 +976,7 @@ READ_MD_H = $(OBSTACK_H) $(HASHTAB_H) read-md.h BUILTINS_DEF = builtins.def sync-builtins.def omp-builtins.def \ gtm-builtins.def sanitizer.def INTERNAL_FN_DEF = internal-fn.def -INTERNAL_FN_H = internal-fn.h $(INTERNAL_FN_DEF) +INTERNAL_FN_H = internal-fn.h $(INTERNAL_FN_DEF) $(OPTABS_H) TREE_CORE_H = tree-core.h $(CORETYPES_H) all-tree.def tree.def \ c-family/c-common.def $(lang_tree_files) \ $(BUILTINS_DEF) $(INPUT_H) statistics.h \