[PATCH-2,rs6000] Add ppc_cpu_supports_hw into proc is-effective-target-keyword [PR108728]

Message ID d92ff30f-759a-2a1a-8086-511b3c0738b0@linux.ibm.com
State Accepted
Headers
Series [PATCH-2,rs6000] Add ppc_cpu_supports_hw into proc is-effective-target-keyword [PR108728] |

Checks

Context Check Description
snail/gcc-patch-check success Github commit url

Commit Message

HAO CHEN GUI April 18, 2023, 3:13 a.m. UTC
  Hi,
  This patch adds ppc_cpu_supports_hw into explicit name checking in
proc is-effective-target-keyword. So ppc_cpu_supports_hw can be used
as a target selector in test directives.

  The patch passed regression test on Power Linux platforms.

Thanks
Gui Haochen

ChangeLog
rs6000: Add ppc_cpu_supports_hw into proc is-effective-target-keyword.

gcc/testsuite/
	PR target/108728
	* lib/target-supports.exp (is-effective-target-keyword): Add
	ppc_cpu_supports_hw.


patch.diff
  

Comments

Kewen.Lin April 19, 2023, 2:42 a.m. UTC | #1
Hi Haochen,

on 2023/4/18 11:13, HAO CHEN GUI via Gcc-patches wrote:
> Hi,
>   This patch adds ppc_cpu_supports_hw into explicit name checking in
> proc is-effective-target-keyword. So ppc_cpu_supports_hw can be used
> as a target selector in test directives.

I think this is the prerequisite of the one "xfail float128 comparison
test case that fails on powerpc64", so this should be PATCH 1/2 and that
one would be 2/2.  For the subject, maybe something like "testsuite: Make
ppc_cpu_supports_hw as effective target keyword [PR108728]" can be clearer.

OK for trunk, thanks.

BR,
Kewen

> 
>   The patch passed regression test on Power Linux platforms.
> 
> Thanks
> Gui Haochen
> 
> ChangeLog
> rs6000: Add ppc_cpu_supports_hw into proc is-effective-target-keyword.
> 
> gcc/testsuite/
> 	PR target/108728
> 	* lib/target-supports.exp (is-effective-target-keyword): Add
> 	ppc_cpu_supports_hw.
> 
> 
> patch.diff
> diff --git a/gcc/testsuite/lib/target-supports.exp b/gcc/testsuite/lib/target-supports.exp
> index 1d6cc6f8d88..e65b447663f 100644
> --- a/gcc/testsuite/lib/target-supports.exp
> +++ b/gcc/testsuite/lib/target-supports.exp
> @@ -9170,6 +9170,7 @@ proc is-effective-target-keyword { arg } {
>  	  "named_sections" { return 1 }
>  	  "gc_sections"    { return 1 }
>  	  "cxa_atexit"     { return 1 }
> +	  "ppc_cpu_supports_hw" { return 1 }
>  	  default          { return 0 }
>  	}
>      }
  

Patch

diff --git a/gcc/testsuite/lib/target-supports.exp b/gcc/testsuite/lib/target-supports.exp
index 1d6cc6f8d88..e65b447663f 100644
--- a/gcc/testsuite/lib/target-supports.exp
+++ b/gcc/testsuite/lib/target-supports.exp
@@ -9170,6 +9170,7 @@  proc is-effective-target-keyword { arg } {
 	  "named_sections" { return 1 }
 	  "gc_sections"    { return 1 }
 	  "cxa_atexit"     { return 1 }
+	  "ppc_cpu_supports_hw" { return 1 }
 	  default          { return 0 }
 	}
     }