From patchwork Tue Feb 20 17:56:41 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Carl Love X-Patchwork-Id: 203726 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:693c:2685:b0:108:e6aa:91d0 with SMTP id mn5csp570083dyc; Tue, 20 Feb 2024 10:00:49 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCU01mqK5VS1bAkRjjozvR63CoKO4odJuwXwGfSlqHCEtyRItXu7OQSw2tSMYbHgxBDrU7ynar0TSWpox0drrTW2OYU4Fw== X-Google-Smtp-Source: AGHT+IEOlNQUClr1DenU0nyOHAemIxI+gJHQXP4SJH4g6yLKkZzTcS90BRJRjrbmNIDs/ubZpFN6 X-Received: by 2002:a0d:eb12:0:b0:604:c8e7:9dcf with SMTP id u18-20020a0deb12000000b00604c8e79dcfmr15739136ywe.35.1708452049020; Tue, 20 Feb 2024 10:00:49 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708452049; cv=pass; d=google.com; s=arc-20160816; b=p0qEtwTcRhBDeAFyynJ2wvFzn34CKBdxBctjWA0N33ZwbrVcWnlHyuJZkGVXm1ll40 d2dMy6pCkSC4q/GWjNp3bQ398ajR8GoVMKEbJKakMKxbw2ZtKrJjKcITkFTcrhyJ1s14 yLkNzmaowyJPnEFWGzBqVd7OveJ1h3hZHz8TEN7s7v4nHXGvWprqyrT2EJhaPuYqzPX/ lAOGKjB8vYHXKtOHNvGc3S/SgVak6nlqXcvoc1qdgeEMaPfrucFLucEhyulMOpbW5HiK oKIWBN6usPsDVn5EEM1huNwSnGjh5QS9NjS7qjFI+DILdTS477UUVktq5csISNsuynMt HFwA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :in-reply-to:from:references:to:content-language:subject:user-agent :mime-version:date:message-id:dkim-signature:arc-filter:dmarc-filter :delivered-to; bh=PvhhdHgLhg2kcH2G0Gfla6fJRnRhkMIodZfWrzUbeTk=; fh=U4Oxu8wVnBRVc+7Z2YdxYnccRaEmehXwfih2gvmyKwI=; b=P+nz3Ugrx/YbIEKcd3FtR3uTNPrln02KZ+BT8xNzWN3gu1O3tDDZdicRoQPlivKwD/ ryHkmkS5QZ3DnKyLuZVttz5EG82APyNnXVaumWQ36Lm32FuehXTo2GKELuxkFbHA0YJe eyL5TYjQU2m2VWcCVVp8MT5SUG9MHXumLG6Lq+YSnqYYo/M+OlQjy2JVCCu9HY7X90cn 5TZVzlxmMnXR5W1KrosGgNrApgl4P9EA5m29gjrlSwZEg5WC5U2bftOtArxy0MsrjR/7 kw8Ajvip6rjeOTZNMHtBW/JDWTAhz/m0y5QGmZSyH3b6LdcFSeDPFNcQwomQDJt2UHh8 XYYA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=p4d4Hx15; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id e22-20020a05622a111600b0042dd6756c13si9865264qty.255.2024.02.20.10.00.47 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Feb 2024 10:00:48 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=p4d4Hx15; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C328D385841B for ; Tue, 20 Feb 2024 18:00:12 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 1B0FE3858C54 for ; Tue, 20 Feb 2024 17:56:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1B0FE3858C54 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1B0FE3858C54 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708451809; cv=none; b=HJmKRwNpkZGRZcTsaVPqbt4A21hgfHODeH2RtF3ahoq5ojaseyl7HSYYzDhqfa11DNLdNwd6W54yTZCOnqeHx5XBbDILRck+9uhf5chQ0c1H5tTE45QfqpoLT0DP6wZmhrToqs/A/sVe29olY2BFPk9gOUvqNZvSmzdCiBqSgLY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708451809; c=relaxed/simple; bh=4f+U4wvCMfZQa4GoUUisfoBBsxxiAv4/cpTRGzFRHPQ=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=bmkWleZDvVrlL/D9C7sbckfzNXKKmK3VNXtPtrp+5csAEyav60ZJdXbia0owM8mtQZ64NXX/+3T7r5dgdHvNdrNav4QuXn3JByIi6d8AOtZzLO8iXxInJgZ7kSadvXgBpCMVjFnx14vQ2Hb00pBUlA9bcCxUyQX8wHR/LPA/fuY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 41KHuGla024684; Tue, 20 Feb 2024 17:56:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=PvhhdHgLhg2kcH2G0Gfla6fJRnRhkMIodZfWrzUbeTk=; b=p4d4Hx15JL/tBfLvAWt+HY9aNAcGLMkSU2r9PndjUjSegnEG4p1lx0+7/0X+NLar49zs SbQknAKpBuqmrsyuZNAy7trpUl9eGJKkTyClV+qniBjqoz0NBu9Fq1vpql/zMMSdoj28 TUpbK0FHQQoRDydVErRQxe5sKIyddxeSNkzSiCbev9vvSrl/2++6hcirKENTFF2BIb3C XjImvqyFwnb87NL+V8XH/7rPSHhn+r58XP0Y6SkQ1VHUcwNc+s8QlQJE6VA6R6QKg0Ec 80+Cbu9rFnuSZOXW8LnH/rksc/tuxjHeBLUH0Z4J3gg1RqzFl0+tBi/MF7QA2NE7CPUm Pg== Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3wcv3r13qm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 20 Feb 2024 17:56:46 +0000 Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 41KGUi49013532; Tue, 20 Feb 2024 17:56:45 GMT Received: from smtprelay07.dal12v.mail.ibm.com ([172.16.1.9]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3wb7h0a1n8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 20 Feb 2024 17:56:45 +0000 Received: from smtpav04.wdc07v.mail.ibm.com (smtpav04.wdc07v.mail.ibm.com [10.39.53.231]) by smtprelay07.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 41KHug0t51642880 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 20 Feb 2024 17:56:44 GMT Received: from smtpav04.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 202C65805F; Tue, 20 Feb 2024 17:56:42 +0000 (GMT) Received: from smtpav04.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6181258045; Tue, 20 Feb 2024 17:56:41 +0000 (GMT) Received: from [9.67.96.239] (unknown [9.67.96.239]) by smtpav04.wdc07v.mail.ibm.com (Postfix) with ESMTP; Tue, 20 Feb 2024 17:56:41 +0000 (GMT) Message-ID: Date: Tue, 20 Feb 2024 09:56:41 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 04/11] rs6000, Update comment for the __builtin_vsx_vper*, built-ins. Content-Language: en-US To: gcc-patches@gcc.gnu.org, "bergner@linux.ibm.com" , Segher Boessenkool , "Kewen.Lin" References: <41290fb1-e2e8-4779-b76f-2208c2dadedd@linux.ibm.com> From: Carl Love In-Reply-To: <41290fb1-e2e8-4779-b76f-2208c2dadedd@linux.ibm.com> X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: KewKT0F8h8it-ngqsEy0F1cJxWGSPULD X-Proofpoint-GUID: KewKT0F8h8it-ngqsEy0F1cJxWGSPULD X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-20_06,2024-02-20_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0 adultscore=0 spamscore=0 bulkscore=0 lowpriorityscore=0 mlxscore=0 suspectscore=0 malwarescore=0 impostorscore=0 mlxlogscore=657 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2402200129 X-Spam-Status: No, score=-9.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791441814927967842 X-GMAIL-MSGID: 1791441814927967842 GCC maintainers: The patch expands an existing comment to document that the duplicates are covered by an overloaded built-in. I am wondering if we should just go ahead and remove the duplicates? The patch has been tested on Power 10 with no regressions. Please let me know if this patch is acceptable for mainline. Thanks. Carl ----------------------------------------------------- rs6000, Update comment for the __builtin_vsx_vper* built-ins. There is a comment about the __builtin_vsx_vper* built-ins being duplicates of the __builtin_altivec_* built-ins. The note says we should consider deprecation/removeal of the __builtin_vsx_vper*. Add a note that the _builtin_vsx_vper* built-ins are covered by the overloaded vec_perm built-ins which use the __builtin_altivec_* built-in definitions. gcc/ChangeLog: * config/rs6000/rs6000-builtins.def ( __builtin_vsx_vperm_*): Add comment to existing comment about the built-ins. --- gcc/config/rs6000/rs6000-builtins.def | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/gcc/config/rs6000/rs6000-builtins.def b/gcc/config/rs6000/rs6000-builtins.def index 96d095da2cb..4c95429f137 100644 --- a/gcc/config/rs6000/rs6000-builtins.def +++ b/gcc/config/rs6000/rs6000-builtins.def @@ -1556,6 +1556,14 @@ ; These are duplicates of __builtin_altivec_* counterparts, and are being ; kept for backwards compatibility. The reason for their existence is ; unclear. TODO: Consider deprecation/removal at some point. +; Note, __builtin_vsx_vperm_16qi, __builtin_vsx_vperm_16qi_uns, +; __builtin_vsx_vperm_1ti, __builtin_vsx_vperm_v1ti_uns, +; __builtin_vsx_vperm_2df, __builtin_vsx_vperm_2di, __builtin_vsx_vperm_2di, +; __builtin_vsx_vperm_2di_uns, __builtin_vsx_vperm_4sf, +; __builtin_vsx_vperm_4si, __builtin_vsx_vperm_4si_uns, +; __builtin_vsx_vperm_8hi, __builtin_altivec_vperm_8hi_uns +; are all covered by the overloaded vec_perm built-in which uses the +; __builtin_altivec_* built-in definitions. const vsc __builtin_vsx_vperm_16qi (vsc, vsc, vuc); VPERM_16QI_X altivec_vperm_v16qi {}