From patchwork Wed Jun 7 06:17:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: jeevitha X-Patchwork-Id: 104258 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp44362vqr; Tue, 6 Jun 2023 23:23:20 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5je+LOP1l1od1caG8yWBHdZnAhCpu8u3ZJI8DPqK0yaXcrH+T0gBniXHBXflB/9zkcuV3z X-Received: by 2002:a17:907:9702:b0:965:6199:cf60 with SMTP id jg2-20020a170907970200b009656199cf60mr4630629ejc.42.1686119000184; Tue, 06 Jun 2023 23:23:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686119000; cv=none; d=google.com; s=arc-20160816; b=g8LyObO7CvbLGlZ28QGPd2RRZIEhsDkEUFcBNe43yLRBryBUYcSmz+M92iz0nIZ0iC xCYeWbe/h4SSr1/3qtECYnw5mnAuTOl8Gf9g3hcQX3AnfDMP9P5HIgH/DXdwnKNGsDK/ X/UKJWRjXSYexSiNhanXhBdi/IoDTWU+l2/J4tqWGs0/vEBZtwdOB6AUqDthJQba7fTF j1iQ755Ssrq3LZpIiX4vGI7B/8lBtjqBLFP1zz0VmljOHyzQ6/PsJ+WnxCcEWFRjkPp4 +ZQI7oBrV6r0zwHjEVmZj+GLkjmGkcQmTkQ5QWCtAsPsUJx92rmwYLbN3P4P7E5lLObz 7swA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:in-reply-to:to:references :content-language:subject:user-agent:mime-version:date:message-id :dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=tN6y87BSCpcCPfASGydLLOkSbChaDbyrB/yW9vPAhzU=; b=YwxXtPnnvFMr4U07xJoO/zYKuYZeElA/iz62qIECIP5Pj4bdRZskTiYFuzNvSIM6CL qhQTYJ1eQcFAnIKF2/5SYUM1w+cAfHMt+b3WjKj4XSCZN7Eq90HvYH9ji/a4eo+0Otax cNancbbelbPYDrRad3ScbaEPzQH+RDTtq1iXHYf0Hg5CgUoZyQzBghdKgjVbID15Xt96 a5BS8ugL+jf9L/G5w6ezdVEKUqrlz1/t11msKAQSCeg3SqwLV7YC52+0lm3WSAdaEl// PBvmUD4iEln4mRSafUE0ediMPBIGfjKSf30qz4Ub42GszX5UOkrdfaRb5Dpw5t30137O 4Azg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=cVVmDkie; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id go18-20020a1709070d9200b00977ead30c92si4126469ejc.559.2023.06.06.23.23.19 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Jun 2023 23:23:20 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=cVVmDkie; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0C6EE3858025 for ; Wed, 7 Jun 2023 06:23:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0C6EE3858025 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1686118999; bh=tN6y87BSCpcCPfASGydLLOkSbChaDbyrB/yW9vPAhzU=; h=Date:Subject:References:To:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=cVVmDkieJqL/gdlM1W8AAEHHDdcDXMPPmoUSKjA+mymis8Nz7OFBxVQhc031XW09M a08dqOlLrLfDJ0jt5dzMC+MjpOYUzcicWU8ZF2iHLmInZ47Q3qpOG4bTaLzOUHoTDB X3Q+QB/+uwKRyFyvfSuZ7PGqO59gxToMH51y8N58= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id C93D43858C54 for ; Wed, 7 Jun 2023 06:22:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C93D43858C54 Received: from pps.filterd (m0353723.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3576Egth015238 for ; Wed, 7 Jun 2023 06:22:35 GMT Received: from ppma04wdc.us.ibm.com (1a.90.2fa9.ip4.static.sl-reverse.com [169.47.144.26]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3r2mf185a0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 07 Jun 2023 06:22:35 +0000 Received: from pps.filterd (ppma04wdc.us.ibm.com [127.0.0.1]) by ppma04wdc.us.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 3573F4rZ032737 for ; Wed, 7 Jun 2023 06:17:31 GMT Received: from smtprelay02.wdc07v.mail.ibm.com ([9.208.129.120]) by ppma04wdc.us.ibm.com (PPS) with ESMTPS id 3r2a76ja12-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 07 Jun 2023 06:17:31 +0000 Received: from smtpav06.wdc07v.mail.ibm.com (smtpav06.wdc07v.mail.ibm.com [10.39.53.233]) by smtprelay02.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 3576HTaq36372796 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 7 Jun 2023 06:17:29 GMT Received: from smtpav06.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CC13958054; Wed, 7 Jun 2023 06:17:29 +0000 (GMT) Received: from smtpav06.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C522E5803F; Wed, 7 Jun 2023 06:17:28 +0000 (GMT) Received: from [9.109.208.172] (unknown [9.109.208.172]) by smtpav06.wdc07v.mail.ibm.com (Postfix) with ESMTP; Wed, 7 Jun 2023 06:17:28 +0000 (GMT) Message-ID: Date: Wed, 7 Jun 2023 11:47:27 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: [PATCH] Add parentheses to clarify precedence between operators [PR106907] Content-Language: en-US References: To: gcc-patches@gcc.gnu.org, Peter Bergner In-Reply-To: X-Forwarded-Message-Id: X-TM-AS-GCONF: 00 X-Proofpoint-GUID: LpuiVpcDezDIYjU3dN7f7mOQc2Z598po X-Proofpoint-ORIG-GUID: LpuiVpcDezDIYjU3dN7f7mOQc2Z598po X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26 definitions=2023-06-07_03,2023-06-06_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 spamscore=0 mlxscore=0 suspectscore=0 adultscore=0 impostorscore=0 mlxlogscore=992 phishscore=0 malwarescore=0 lowpriorityscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306070049 X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: P Jeevitha via Gcc-patches From: jeevitha Reply-To: P Jeevitha Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768023916840549546?= X-GMAIL-MSGID: =?utf-8?q?1768023916840549546?= PR106907 has few warnings spotted from cppcheck. Inorder to clarify the order of precedence between operators added parentheses to explicitly group operations based on desired order of evaluation. 2023-06-07 Jeevitha Palanisamy gcc/ PR target/106907 * config/gcn/gcn.cc (gcn_hsa_declare_function_name): Add parentheses to group the operations. diff --git a/gcc/config/gcn/gcn.cc b/gcc/config/gcn/gcn.cc index efb7211d54e..d2b5cb74204 100644 --- a/gcc/config/gcn/gcn.cc +++ b/gcc/config/gcn/gcn.cc @@ -6300,7 +6300,7 @@ gcn_hsa_declare_function_name (FILE *file, const char *name, tree) fprintf (file, "\t .amdhsa_system_vgpr_workitem_id\t%i\n", (cfun->machine->args.requested & (1 << WORK_ITEM_ID_Z_ARG)) ? 2 - : cfun->machine->args.requested & (1 << WORK_ITEM_ID_Y_ARG) + : (cfun->machine->args.requested & (1 << WORK_ITEM_ID_Y_ARG)) ? 1 : 0); fprintf (file, "\t .amdhsa_next_free_vgpr\t%i\n"