From patchwork Mon Oct 17 13:25:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Andrew MacLeod X-Patchwork-Id: 3456 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp1445842wrs; Mon, 17 Oct 2022 06:25:57 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6DIwx37QlqxTrX7Nb5rWXpmq6l/FoFjjTFczX+q5mbojwuweCc4XLcdndIkIlgMcsyksRv X-Received: by 2002:a05:6402:3547:b0:45d:1578:9424 with SMTP id f7-20020a056402354700b0045d15789424mr10013723edd.281.1666013157686; Mon, 17 Oct 2022 06:25:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666013157; cv=none; d=google.com; s=arc-20160816; b=p13RvIW79kFoQ63znk5cb4jQmpG9IQ29uqFTLCStsuYLBv/l/diVULNj1ljh5/7mG8 gkF7phzpK9fN3CnfwewNJKC+xXrto3OKU6HRmom0176DeWUO3IkIR7k+pJCkAHOI6nkS NExbnaid7/H0JVLdhyWJC72ZSOHcZmrxXzYFJZLSX7K3EFC9XTCXNqAREwgv0fuWDghM f3pb4Sf2Qyz/nChg6JlFrPnk5SA6NAsAYx3l+WENCsM4naujKv28bWDoV8FV2NjNz4Ro CGc6drIBMCinlCeYnnkkVoVjsTotEkpdD1oyXZQYmhfGqGoXhFCapuWU1001JIihSESe ow2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:content-language :subject:to:user-agent:mime-version:date:message-id:dmarc-filter :delivered-to:dkim-signature:dkim-filter; bh=3AGbmxUhDJfBz+tv1yDy58etSTE+Wkihayhq0GgbB+s=; b=kwkGATgvaKxnJeLNW3ch8BA0vcjXJB0yZtum6TzbXSDX6Y5SHJ0gXIsBBo0UTBuGAm w5rKUnbEj7+FE1LUes6jnrbIeaeG57C+mdOfX14+yXcY51yEoJi3g65ob7x8+4ArnnUU vdgNArqOaTxJrwQEEvtagwMfPAM6AGb4P1wIgn19qeol9mg2rEaMf62MpCeCAC3vCa2V 3QCHnfOEely4zKqQYWUB9O8pL0MqVt6SERjpNUI8Ua3TX/ywfNkaX0mLQha3DkeXkzdG YZozK92Cb9+2j7i2QCEzf/r2JPu/Iy0ibTmCSai2S4lXPM7ObNgxfy5es9ziA+wSUU5c BAWw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=vc1vK3vM; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id x11-20020a05640226cb00b0045d46f28533si7374204edd.377.2022.10.17.06.25.57 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Oct 2022 06:25:57 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=vc1vK3vM; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 42FB43857BB7 for ; Mon, 17 Oct 2022 13:25:53 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 42FB43857BB7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1666013153; bh=3AGbmxUhDJfBz+tv1yDy58etSTE+Wkihayhq0GgbB+s=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=vc1vK3vMQnkh3jAStKQCiwTHg2wfayYeo5TDLVH5vALp148c3B8IV7LrZTYYGKivx psizvp2kYCknHts7ievcTChGSRpHrbM9YyB9sYyd3spCSh17q+pJHGlpGecoTAuXoa Q/Xh5cDE+O/ZwIzcy8mhT3jLmIPaHfDh1Yzd+ycg= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id D3E5438582AF for ; Mon, 17 Oct 2022 13:25:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D3E5438582AF Received: from mail-io1-f69.google.com (mail-io1-f69.google.com [209.85.166.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-453-EbbFRbR2Oe67F-2UNctoGQ-1; Mon, 17 Oct 2022 09:25:08 -0400 X-MC-Unique: EbbFRbR2Oe67F-2UNctoGQ-1 Received: by mail-io1-f69.google.com with SMTP id w6-20020a6bd606000000b006bcd951c261so4705713ioa.2 for ; Mon, 17 Oct 2022 06:25:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=subject:from:cc:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dQ2qwGK1M1T06XVSc5nFeXz22eypKAqMaJHVEs+XTBo=; b=vKer5zz072odU/MhhcZe/JcqR9cmrrJ2fYY9vDuEagMb2TP+Ok/MTFX7J18I/YygS/ IUO6YkTcgOuMbvZM8CtbB3DF/Of6XEQNXPzFJmraMCGbSCgUFMna7nmcgfUiRsQPX9Fp /MJtnCa4v6aaa+xOcwZrn3gfi3uBgBfUB/SZqAGoqs1YrJZHyJ7qB+Td4HWDA4WbHKJd iWFZlzMuMvZ0tazg1Sqq2D3rzA96y4KU0+iE52G6lWBi9O21mQdcJaBNRgKp2xUoUb/9 bbYZqXFO+8j2PpEOGZ8NFFsCbuUg6K9bpt/TggTN/FJNrk57CynfUCRRwyw+LVHPzuSQ v7SA== X-Gm-Message-State: ACrzQf2Jh5oTakOsdDkufMIJFgzqV+OD+GWSEFBe6oZiVucuzykAX8zN Jd/LHzdrA4neyLz7lSVYNZkcWEc29ZmwrxuuhzcnYg+dnSCIjvRjl03r9F+4qLwk2q2hk5/vXcj EOmOMuMgSgst7deWCHoXkc43tQTIofYE5KhHLBc5ohQg7p/XMYKn/24ZsY4jlEO6YcxHoyQ== X-Received: by 2002:a05:6e02:1e02:b0:2fc:6288:e6e6 with SMTP id g2-20020a056e021e0200b002fc6288e6e6mr4814931ila.172.1666013106909; Mon, 17 Oct 2022 06:25:06 -0700 (PDT) X-Received: by 2002:a05:6e02:1e02:b0:2fc:6288:e6e6 with SMTP id g2-20020a056e021e0200b002fc6288e6e6mr4814922ila.172.1666013106656; Mon, 17 Oct 2022 06:25:06 -0700 (PDT) Received: from ?IPV6:2607:fea8:a263:f600::50d4? ([2607:fea8:a263:f600::50d4]) by smtp.gmail.com with ESMTPSA id k4-20020a02a704000000b00363a11b0b44sm4464700jam.9.2022.10.17.06.25.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Oct 2022 06:25:05 -0700 (PDT) Message-ID: Date: Mon, 17 Oct 2022 09:25:04 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 To: gcc-patches Subject: [COMMITTED] Don't set useless relations. X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Andrew MacLeod via Gcc-patches From: Andrew MacLeod Reply-To: Andrew MacLeod Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1746941412576513487?= X-GMAIL-MSGID: =?utf-8?q?1746941412576513487?= The oracle will not register nonsense/useless relations, (basically X op X).  Symbolically,  x == x  is implied, and x != x, x< x, etc are all nonsense. Now that we are using class value_relation in a couple of other places, it shouldn't either. Bootstrapped on  x86_64-pc-linux-gnu with no regressions. Pushed. Andrew From fca529517484bf19098ca9efa77e95534086abdc Mon Sep 17 00:00:00 2001 From: Andrew MacLeod Date: Fri, 14 Oct 2022 14:31:02 -0400 Subject: [PATCH 1/4] Don't set useless relations. The oracle will not register nonssense/useless relations, class value_relation shouldn't either. * value-relation.cc (value_relation::dump): Change message. * value-relation.h (value_relation::set_relation): If op1 is the same as op2 do not create a relation. --- gcc/value-relation.cc | 2 +- gcc/value-relation.h | 7 +++++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/gcc/value-relation.cc b/gcc/value-relation.cc index 50fc190a36b..3fb7b96c9e0 100644 --- a/gcc/value-relation.cc +++ b/gcc/value-relation.cc @@ -891,7 +891,7 @@ value_relation::dump (FILE *f) const { if (!name1 || !name2) { - fprintf (f, "uninitialized"); + fprintf (f, "no relation registered"); return; } fputc ('(', f); diff --git a/gcc/value-relation.h b/gcc/value-relation.h index a3bbe1e8157..fa9097a8069 100644 --- a/gcc/value-relation.h +++ b/gcc/value-relation.h @@ -349,6 +349,13 @@ value_relation::set_relation (relation_kind r, tree n1, tree n2) { gcc_checking_assert (TREE_CODE (n1) == SSA_NAME && TREE_CODE (n2) == SSA_NAME); + if (n1 == n2) + { + related = VREL_VARYING; + name1 = NULL_TREE; + name2 = NULL_TREE; + return; + } related = r; name1 = n1; name2 = n2; -- 2.37.3