diff mbox series

rs6000: Fix test gc.target/powerpc/rs600-fpint.c test options

Message ID c7e61083e9a2a8154a18a6c4ffe22ae8751ad3f0.camel@us.ibm.com
State Accepted
Headers
Series rs6000: Fix test gc.target/powerpc/rs600-fpint.c test options |

Checks

Context Check Description
snail/gcc-patch-check success Github commit url

Commit Message

Carl Love April 13, 2023, 7:42 p.m. UTC 
  GCC maintainers:

The following patch fixes the dg-options for test powerpc/rs600-
fpint.c.  The test now works correctly on Power 10.  The patch has been
tested on Power10 with no regressions.

Please let me know if the patch is acceptable for mainline.  Thanks.

            Carl 

---------------------------------
rs6000: Fix test gc.target/powerpc/rs600-fpint.c test options

The test compile option rs6000-*-* is outdated and no longer supported.
The powerpc*-*-* is the defualt, so it doesn't need to be specified.
The dg-options needs to specify an older processor to get the desired
behavior on recent processors.

This patch updates the test specifications so the test will run properly on
Power10LE.  Tested on Power10 LE system with no regression test failures.

gcc/testsuite/:
	* gcc.target/powerpc/rs6000-fpint.c: Update dg-options, drop dg-do
	compile specifier.
---
 gcc/testsuite/gcc.target/powerpc/rs6000-fpint.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Kewen.Lin May 15, 2023, 6:46 a.m. UTC | #1 
Hi Carl,

on 2023/4/14 03:42, Carl Love via Gcc-patches wrote:
> 
> GCC maintainers:
> 
> The following patch fixes the dg-options for test powerpc/rs600-
> fpint.c.  The test now works correctly on Power 10.  The patch has been
> tested on Power10 with no regressions.
> 
> Please let me know if the patch is acceptable for mainline.  Thanks.

OK for trunk with one more comment added in commit log ...

> 
>             Carl 
> 
> ---------------------------------
> rs6000: Fix test gc.target/powerpc/rs600-fpint.c test options
> 
> The test compile option rs6000-*-* is outdated and no longer supported.
> The powerpc*-*-* is the defualt, so it doesn't need to be specified.
> The dg-options needs to specify an older processor to get the desired
> behavior on recent processors.

... such as: ", since gfxopt is only off for very old CPUs, we don't guard
stfiwx under it for recent processors and don't want to."  Thanks for fixing!

BR,
Kewen

> 
> This patch updates the test specifications so the test will run properly on
> Power10LE.  Tested on Power10 LE system with no regression test failures.
> 
> gcc/testsuite/:
> 	* gcc.target/powerpc/rs6000-fpint.c: Update dg-options, drop dg-do
> 	compile specifier.
> ---
>  gcc/testsuite/gcc.target/powerpc/rs6000-fpint.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/gcc/testsuite/gcc.target/powerpc/rs6000-fpint.c b/gcc/testsuite/gcc.target/powerpc/rs6000-fpint.c
> index 410f780de8b..fdb0a371929 100644
> --- a/gcc/testsuite/gcc.target/powerpc/rs6000-fpint.c
> +++ b/gcc/testsuite/gcc.target/powerpc/rs6000-fpint.c
> @@ -1,5 +1,4 @@
> -/* { dg-do compile { target powerpc*-*-* rs6000-*-* } } */
> -/* { dg-options "-mno-powerpc-gfxopt" } */
> +/* { dg-options "-mno-powerpc-gfxopt -mdejagnu-cpu=power6" } */
>  /* { dg-final { scan-assembler-not "stfiwx" } } */
>  
>  /* A basic test of the old-style (not stfiwx) fp -> int conversion.  */
diff mbox series

Patch

diff --git a/gcc/testsuite/gcc.target/powerpc/rs6000-fpint.c b/gcc/testsuite/gcc.target/powerpc/rs6000-fpint.c
index 410f780de8b..fdb0a371929 100644
--- a/gcc/testsuite/gcc.target/powerpc/rs6000-fpint.c
+++ b/gcc/testsuite/gcc.target/powerpc/rs6000-fpint.c
@@ -1,5 +1,4 @@ 
-/* { dg-do compile { target powerpc*-*-* rs6000-*-* } } */
-/* { dg-options "-mno-powerpc-gfxopt" } */
+/* { dg-options "-mno-powerpc-gfxopt -mdejagnu-cpu=power6" } */
 /* { dg-final { scan-assembler-not "stfiwx" } } */
 
 /* A basic test of the old-style (not stfiwx) fp -> int conversion.  */