From patchwork Mon Aug 14 08:52:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Kewen.Lin" X-Patchwork-Id: 135238 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b824:0:b0:3f2:4152:657d with SMTP id z4csp2608560vqi; Mon, 14 Aug 2023 01:53:28 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFsYyXftSFbas7tkz6w0Qf5OA4B5Suc+m9u+6BtevB3LAtN2w019D/Ox09sbXoujRdw7nDW X-Received: by 2002:a17:907:16a6:b0:99b:f42d:b3f6 with SMTP id hc38-20020a17090716a600b0099bf42db3f6mr13532035ejc.32.1692003208101; Mon, 14 Aug 2023 01:53:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1692003208; cv=none; d=google.com; s=arc-20160816; b=j8rFMcJVWztAKHrDspV0IRtV9e6gwDqEujfXe+iPPvsvKtHniJQSq6dJSQPqJbEX6p bwvzL2jX8ZB0Rluy2P+pax4diDEzIwARu6BVsY7AbxLmiyU6uXkbrNpZRRFVY3aLvg9G D78yyTzA5/bW7s0FSTU+Q/Jvkihoq7IPGN+or2imWjdZE7f1KDw6FEw0twm8s/kLFMB3 EnOTfRTjB51B7qGco7zJjI3b/0d8tCSvnJsMrx2KdI5qL1E0OFMBESxsL8EywH3vWkTM nYJr2pJlmWpo4U5PX/3PhxM6P/G+u0ptEv+Em8qbS4qFvK/9ORMujVYpIhv9C8OTQGkQ I/gw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:cc:to:subject:content-language:user-agent :mime-version:date:message-id:dmarc-filter:delivered-to :dkim-signature:dkim-filter; bh=vK4thGLtEhrappx/fBxi0CHvOybjmIXov418rW3+BAY=; fh=igBTPjHNdy5qHek4vewG2hwX+gxODq9WIce1cDBLf4Y=; b=qEDclujHRYuKks2dGH/LG9UK6v7Qj+d0ZH0b28RT+cdUYUliMlSwmTaHZDzlIw7hOr MAgM2X8nAVhL7lAmTUSNV6+K2190CH1i85Lt+JY2wvCi0jSFU+1POO+Oqnow2tMw97gK ENjf5aH+KfOaOSGAaqHrnJyUvJhKCBCg/6e2lstbVmdKmeufH9AYl9D9vCnn0zQBiXcl 0S+G6ri2NbegH4Aej4EQYO6CTR8ZTb5/oP7Nf87lj11ZS0njxD1J02eVnmkD6UFAehKP lL9Md3b0+F8RqfOtgeratqryCkW+nNaLAY6q1Txp420/OIjg1Ontn05IwoRm6oByRt0/ poKQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=L4ZDnXpv; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id kk16-20020a170907767000b00991e6951c1bsi7610308ejc.423.2023.08.14.01.53.27 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Aug 2023 01:53:28 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=L4ZDnXpv; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 719BC3858C2D for ; Mon, 14 Aug 2023 08:53:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 719BC3858C2D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1692003206; bh=vK4thGLtEhrappx/fBxi0CHvOybjmIXov418rW3+BAY=; h=Date:Subject:To:Cc:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=L4ZDnXpvW4DyTe1LlNwA4qAswGOgMY6gv3K1TUzj4NKQWQY+1Nmbxk7lOHIZNQUIl uIxyRcJwFL6xjJQkdFYSOHePDZ/iAR0Afd5yYO60pdtcqWzknBVZJGVl/Yer1wZ1Lm Wt0Z6JptGLEjpG58B4+r0T8XLWPbyel7WuzBdsp8= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id C5D813858416 for ; Mon, 14 Aug 2023 08:52:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C5D813858416 Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 37E8STws009825; Mon, 14 Aug 2023 08:52:40 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3sfgshrhtw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 14 Aug 2023 08:52:40 +0000 Received: from m0356516.ppops.net (m0356516.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 37E8qd6c006412; Mon, 14 Aug 2023 08:52:39 GMT Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3sfgshrhtk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 14 Aug 2023 08:52:39 +0000 Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 37E7JZJw013228; Mon, 14 Aug 2023 08:52:08 GMT Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 3sepmja9qt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 14 Aug 2023 08:52:07 +0000 Received: from smtpav04.fra02v.mail.ibm.com (smtpav04.fra02v.mail.ibm.com [10.20.54.103]) by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 37E8q62919989218 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 14 Aug 2023 08:52:06 GMT Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4D3A32004D; Mon, 14 Aug 2023 08:52:06 +0000 (GMT) Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0703820043; Mon, 14 Aug 2023 08:52:05 +0000 (GMT) Received: from [9.200.51.201] (unknown [9.200.51.201]) by smtpav04.fra02v.mail.ibm.com (Postfix) with ESMTP; Mon, 14 Aug 2023 08:52:04 +0000 (GMT) Message-ID: Date: Mon, 14 Aug 2023 16:52:03 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Content-Language: en-US Subject: [PATCH] vect: Remove several useless VMAT_INVARIANT checks To: GCC Patches Cc: Richard Biener , Richard Sandiford X-TM-AS-GCONF: 00 X-Proofpoint-GUID: FGNMxVt5K0I7EdBZ1FudXV5ypNo8cAem X-Proofpoint-ORIG-GUID: mErGL56jiNVYWWr1NBq7qPf0eumIc6mX X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-08-14_03,2023-08-10_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 phishscore=0 clxscore=1015 lowpriorityscore=0 malwarescore=0 priorityscore=1501 impostorscore=0 mlxscore=0 adultscore=0 spamscore=0 mlxlogscore=377 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000 definitions=main-2308140078 X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: "Kewen.Lin via Gcc-patches" From: "Kewen.Lin" Reply-To: "Kewen.Lin" Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1774193955638638369 X-GMAIL-MSGID: 1774193955638638369 Hi, In function vectorizable_load, there is one hunk which is dedicated for the handlings on VMAT_INVARIANT and return early, it means we shouldn't encounter any cases with memory_access_type VMAT_INVARIANT in the following code after that. This patch is to clean up several useless checks on VMAT_INVARIANT. There should be no functional changes. Bootstrapped and regtested on x86_64-redhat-linux, aarch64-linux-gnu and powerpc64{,le}-linux-gnu. gcc/ChangeLog: * tree-vect-stmts.cc (vectorizable_load): Remove some useless checks on VMAT_INVARIANT. --- gcc/tree-vect-stmts.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.31.1 diff --git a/gcc/tree-vect-stmts.cc b/gcc/tree-vect-stmts.cc index 89607a98f99..d4e781531fd 100644 --- a/gcc/tree-vect-stmts.cc +++ b/gcc/tree-vect-stmts.cc @@ -10499,7 +10499,7 @@ vectorizable_load (vec_info *vinfo, tree bias = NULL_TREE; if (!costing_p) { - if (loop_masks && memory_access_type != VMAT_INVARIANT) + if (loop_masks) final_mask = vect_get_loop_mask (loop_vinfo, gsi, loop_masks, vec_num * ncopies, vectype, @@ -10729,7 +10729,7 @@ vectorizable_load (vec_info *vinfo, bias = build_int_cst (intQI_type_node, biasval); } - if (final_len && memory_access_type != VMAT_INVARIANT) + if (final_len) { tree ptr = build_int_cst (ref_type, align * BITS_PER_UNIT);