diff mbox series

libstdc++ testsuite/20_util/hash/quality.cc: Increase timeout 3x

Message ID alpine.BSF.2.20.16.2312292020210.28105@arjuna.pair.com
State Accepted
Headers
Series libstdc++ testsuite/20_util/hash/quality.cc: Increase timeout 3x |

Checks

Context Check Description
snail/gcc-patch-check success Github commit url

Commit Message

Hans-Peter Nilsson Dec. 30, 2023, 1:23 a.m. UTC 
  Tested for mmix and observing the increased timeout in the .log 
file - and the test passing.

Ok to commit?  Or better suggestions?

-- >8 --
Testing for mmix (a 64-bit target using Knuth's simulator).  The test
is largely pruned for simulators, but still needs 5m57s on my laptop
from 3.5 years ago to run to successful completion.  Perhaps slow
hosted targets could also have problems so increasing the timeout
limit, not just for simulators but for everyone, and by more than a
factor 2.

	* testsuite/20_util/hash/quality.cc: Increase timeout by a factor 3.
---
 libstdc++-v3/testsuite/20_util/hash/quality.cc | 1 +
 1 file changed, 1 insertion(+)

Comments

Jonathan Wakely Dec. 30, 2023, 9:29 a.m. UTC | #1 
On Sat, 30 Dec 2023, 01:24 Hans-Peter Nilsson, <hp@bitrange.com> wrote:

> Tested for mmix and observing the increased timeout in the .log
> file - and the test passing.
>
> Ok to commit?  Or better suggestions?
>

OK to commit, thanks.



> -- >8 --
> Testing for mmix (a 64-bit target using Knuth's simulator).  The test
> is largely pruned for simulators, but still needs 5m57s on my laptop
> from 3.5 years ago to run to successful completion.  Perhaps slow
> hosted targets could also have problems so increasing the timeout
> limit, not just for simulators but for everyone, and by more than a
> factor 2.
>
>         * testsuite/20_util/hash/quality.cc: Increase timeout by a factor
> 3.
> ---
>  libstdc++-v3/testsuite/20_util/hash/quality.cc | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/libstdc++-v3/testsuite/20_util/hash/quality.cc
> b/libstdc++-v3/testsuite/20_util/hash/quality.cc
> index 7d4208ed6d21..811110efc026 100644
> --- a/libstdc++-v3/testsuite/20_util/hash/quality.cc
> +++ b/libstdc++-v3/testsuite/20_util/hash/quality.cc
> @@ -1,5 +1,6 @@
>  // { dg-options "-DNTESTS=1 -DNSTRINGS=100 -DSTRSIZE=21" { target
> simulator } }
>  // { dg-do run { target c++11 } }
> +// { dg-timeout-factor 3 }
>
>  // Copyright (C) 2010-2023 Free Software Foundation, Inc.
>  //
> --
> 2.30.2
>
>
diff mbox series

Patch

diff --git a/libstdc++-v3/testsuite/20_util/hash/quality.cc b/libstdc++-v3/testsuite/20_util/hash/quality.cc
index 7d4208ed6d21..811110efc026 100644
--- a/libstdc++-v3/testsuite/20_util/hash/quality.cc
+++ b/libstdc++-v3/testsuite/20_util/hash/quality.cc
@@ -1,5 +1,6 @@ 
 // { dg-options "-DNTESTS=1 -DNSTRINGS=100 -DSTRSIZE=21" { target simulator } }
 // { dg-do run { target c++11 } }
+// { dg-timeout-factor 3 }
 
 // Copyright (C) 2010-2023 Free Software Foundation, Inc.
 //