Message ID | ac026cce-3bc1-49fc-8f29-7303c8943286@linux.ibm.com |
---|---|
State | Accepted |
Headers |
Return-Path: <gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:693c:2685:b0:108:e6aa:91d0 with SMTP id mn5csp74551dyc; Mon, 19 Feb 2024 14:39:33 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXSBVzVC7ZnsrzLj4XnSGdyOQRky2858kQ8Mjn/qHggeIxmly6/I/DCNFFCMLuY1gbbjD0jfEVtGi0ibWzlAw/9GeyAPg== X-Google-Smtp-Source: AGHT+IEaoOxVYLx30H9oAqoUG3pnpdGkM1jIZACo2O+gBIwsVePNDI0aAO0YPY1q8XwmTTLWkuQU X-Received: by 2002:a05:622a:446:b0:42d:c407:b084 with SMTP id o6-20020a05622a044600b0042dc407b084mr15371430qtx.12.1708382372817; Mon, 19 Feb 2024 14:39:32 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708382372; cv=pass; d=google.com; s=arc-20160816; b=r5+NUTLhS7hAnf0YRz/xHgQ3nmxKy8U+iNgYRSJI4I18etpFbCFchuzG1bBfj+rSH5 hupS88+nQLRx0XTiMQhyBdhXh36EyOkXVtucNE9S7Dfj6ren0tdrtXIms1pE5Idk18F2 douoVB56AQ3Jg1ABksbIbKRCwXOHO0cq/5SHdUMmaCDtWhFv9d+pkSof6sVidHezCoyi vtX/xrGrFmWcLi2MoboGMdZIG0pS9HcxUbT/cZYL6qGOn2X7eSUpg6U2fMv/w/jff27r hWotk17eo+dM+M48VOmxJ2T/CWUsrcMhD3ojIXDO9KdutwULuwDIwdLL25U2zIEgNFzy ThQw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :subject:from:cc:to:content-language:user-agent:mime-version:date :message-id:dkim-signature:arc-filter:dmarc-filter:delivered-to; bh=MxkrV2QdIp0f165KtqRXFqaUfHEDjD26YI9oUe564Vw=; fh=u3U7SD3SKrLN9dLTde0Tu9kn0HYcwKNAZjvil+SbJkQ=; b=CT5Z09tpr7i2Y6S1Kz1iUdr9IE8YJgMMmkkULYdJy2A/1prVBfwZLudT7/6xI2eXT2 +Nof7BoQfQ5Lp4WfRFGKNs/4XmPWX6DIb+ye6z7Unrew84czC/FWe3w/mhHz1DmYvk1I PKcgVOQwe+tTS3XB9gQDNqCq37bNy4bWisj1m9UpE1pWXSLMTa0Y05pAUK/saeaNDK07 X9hEqht46ZSnCbPvbLT/vMcBulm0TsKkQ+4yNZ55BE1YRfBkoGDVqqy5Rgjo7sQsm9ir cIL+y1iutmaJNBKP6+cvbRgg5KMOC7yE439dz8Wh4OyX7sV3/4O7FWha1oHLGHFKk9Dw Q7Og==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b="ONBV/Rr0"; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id h10-20020ac8568a000000b0042c4c1d935esi6952504qta.353.2024.02.19.14.39.32 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Feb 2024 14:39:32 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b="ONBV/Rr0"; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6B1BC3858C74 for <ouuuleilei@gmail.com>; Mon, 19 Feb 2024 22:39:32 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id E02513858D20 for <gcc-patches@gcc.gnu.org>; Mon, 19 Feb 2024 22:38:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E02513858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E02513858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708382335; cv=none; b=j8lg4c0x/3h13pbz3+q59YOSfPbOhVCgxchKGAe/9+IuWiHqjhLsDwaWCDBZjwI+hJpxFqpIhHdoJ4OHQR/QZ6YyQ+jMC28eiiiTpCZlkfCqGcGkJR/V1uWhTHLs3Mc9ies84Ov55TRPvHUsSlrPZopTTsmVSOE71Ta/5yRp6pE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708382335; c=relaxed/simple; bh=uCr17t4VYp37on0rtyUF4TQsS+j7J3liAsII6mY5emk=; h=DKIM-Signature:Message-ID:Date:MIME-Version:To:From:Subject; b=Nqe8VD2M2RAocJfMLYdr61kYy8s9pXHuJb2Xh0mI6M6g8qgnpxggepGzXd8An0gV5GeyNBQytu6ui8uodIeQx82aU3qtkAw3Z3Nulz1X/ZGwVvQakleK7VgPUoXnjAEFZaE0Tyow1xD9/vjxRvAExe08xjuvllQKWTuikKbCBqI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 41JM64jM023819; Mon, 19 Feb 2024 22:38:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : to : cc : from : subject : content-type : content-transfer-encoding; s=pp1; bh=MxkrV2QdIp0f165KtqRXFqaUfHEDjD26YI9oUe564Vw=; b=ONBV/Rr04zfwejUa/0nIpsdxs4Nxv6bHVU6LgOOKLcekJZYJdGTe8g4w5HXAPnIAchbN dRkIw+7xQM/W1ja+RxPVp1NYVntb8TD03pvhRmbAVTptI0al/taE6vWCxxSIsLCm5uod MH12FWe+bE3WCH78qUoq4BUVrVuofMAvyjsDx0VlTqDH4nO42MH1gsfAMFA5xNx+6z2Z 6FOizCtsPzrEaXj3UzMqUctST5rQVs8bg25vs7v42fmB2AzqLY4hM7MwKX+AnitL3sv4 A77AokIUHJO1YN1mxK5WyMQZdApOOSmgvjpHDiQAbHJtr3Y8u70ILjYpUuXZr09S5xyB ow== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3wce8nad8u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 19 Feb 2024 22:38:51 +0000 Received: from m0360083.ppops.net (m0360083.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 41JMWwIB007471; Mon, 19 Feb 2024 22:35:42 GMT Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3wce8nad8e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 19 Feb 2024 22:35:42 +0000 Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 41JKoOR7031187; Mon, 19 Feb 2024 22:35:41 GMT Received: from smtprelay05.wdc07v.mail.ibm.com ([172.16.1.72]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 3wb9bkkyjs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 19 Feb 2024 22:35:41 +0000 Received: from smtpav03.dal12v.mail.ibm.com (smtpav03.dal12v.mail.ibm.com [10.241.53.102]) by smtprelay05.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 41JMZbdm9568834 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 19 Feb 2024 22:35:39 GMT Received: from smtpav03.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9796958283; Mon, 19 Feb 2024 22:35:37 +0000 (GMT) Received: from smtpav03.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 37FBC58275; Mon, 19 Feb 2024 22:35:37 +0000 (GMT) Received: from [9.61.137.147] (unknown [9.61.137.147]) by smtpav03.dal12v.mail.ibm.com (Postfix) with ESMTP; Mon, 19 Feb 2024 22:35:37 +0000 (GMT) Message-ID: <ac026cce-3bc1-49fc-8f29-7303c8943286@linux.ibm.com> Date: Mon, 19 Feb 2024 16:35:36 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Segher Boessenkool <segher@kernel.crashing.org>, "Kewen.Lin" <linkw@linux.ibm.com>, David Edelsohn <dje.gcc@gmail.com> Cc: GCC Patches <gcc-patches@gcc.gnu.org> From: Peter Bergner <bergner@linux.ibm.com> Subject: [PATCH] rs6000: Update instruction counts due to combine changes [PR112103] Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: Aff0rLZSmkaag0cqVMiydiLr3lIpz-aP X-Proofpoint-ORIG-GUID: GkLkLG4YLwvwtw6mq6pxqU0Fgy7bYh9e X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-19_20,2024-02-19_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 spamscore=0 mlxlogscore=899 clxscore=1011 adultscore=0 malwarescore=0 phishscore=0 priorityscore=1501 lowpriorityscore=0 mlxscore=0 suspectscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2402190170 X-Spam-Status: No, score=-10.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791368754515834151 X-GMAIL-MSGID: 1791368754515834151 |
Series |
rs6000: Update instruction counts due to combine changes [PR112103]
|
|
Checks
Context | Check | Description |
---|---|---|
snail/gcc-patch-check | success | Github commit url |
Commit Message
Peter Bergner
Feb. 19, 2024, 10:35 p.m. UTC
rs6000: Update instruction counts due to combine changes [PR112103] The PR91865 combine fix changed instruction counts slightly for rlwinm-0.c. Adjust expected instruction counts accordingly. This passed on both powerpc64le-linux and powerpc64-linux running the testsuite in both 32-bit and 64-bit modes. Ok for trunk? FYI, I will open a new bug to track the removing of the superfluous insns detected in PR112103. Peter gcc/testsuite/ PR target/112103 * gcc.target/powerpc/rlwinm-0.c: Adjust expected instruction counts.
Comments
Hi Peter, on 2024/2/20 06:35, Peter Bergner wrote: > rs6000: Update instruction counts due to combine changes [PR112103] > > The PR91865 combine fix changed instruction counts slightly for rlwinm-0.c. > Adjust expected instruction counts accordingly. > > This passed on both powerpc64le-linux and powerpc64-linux running the > testsuite in both 32-bit and 64-bit modes. Ok for trunk? OK for trunk, thanks for fixing! > > FYI, I will open a new bug to track the removing of the superfluous > insns detected in PR112103. Hope this test case will become not fragile any more once this filed issue gets fixed. :) BR, Kewen > > > Peter > > > gcc/testsuite/ > PR target/112103 > * gcc.target/powerpc/rlwinm-0.c: Adjust expected instruction counts. > > diff --git a/gcc/testsuite/gcc.target/powerpc/rlwinm-0.c b/gcc/testsuite/gcc.target/powerpc/rlwinm-0.c > index 4f4fca2d8ef..a10d9174306 100644 > --- a/gcc/testsuite/gcc.target/powerpc/rlwinm-0.c > +++ b/gcc/testsuite/gcc.target/powerpc/rlwinm-0.c > @@ -4,10 +4,10 @@ > /* { dg-final { scan-assembler-times {(?n)^\s+[a-z]} 6739 { target ilp32 } } } */ > /* { dg-final { scan-assembler-times {(?n)^\s+[a-z]} 9716 { target lp64 } } } */ > /* { dg-final { scan-assembler-times {(?n)^\s+blr} 3375 } } */ > -/* { dg-final { scan-assembler-times {(?n)^\s+rldicl} 3081 { target lp64 } } } */ > +/* { dg-final { scan-assembler-times {(?n)^\s+rldicl} 3090 { target lp64 } } } */ > > /* { dg-final { scan-assembler-times {(?n)^\s+rlwinm} 3197 { target ilp32 } } } */ > -/* { dg-final { scan-assembler-times {(?n)^\s+rlwinm} 3093 { target lp64 } } } */ > +/* { dg-final { scan-assembler-times {(?n)^\s+rlwinm} 3084 { target lp64 } } } */ > /* { dg-final { scan-assembler-times {(?n)^\s+rotlwi} 154 } } */ > /* { dg-final { scan-assembler-times {(?n)^\s+srwi} 13 { target ilp32 } } } */ > /* { dg-final { scan-assembler-times {(?n)^\s+srdi} 13 { target lp64 } } } */
On 2/20/24 3:29 AM, Kewen.Lin wrote: > on 2024/2/20 06:35, Peter Bergner wrote: >> rs6000: Update instruction counts due to combine changes [PR112103] >> >> The PR91865 combine fix changed instruction counts slightly for rlwinm-0.c. >> Adjust expected instruction counts accordingly. >> >> This passed on both powerpc64le-linux and powerpc64-linux running the >> testsuite in both 32-bit and 64-bit modes. Ok for trunk? > > OK for trunk, thanks for fixing! Ok, pushed. Thanks. >> FYI, I will open a new bug to track the removing of the superfluous >> insns detected in PR112103. > > Hope this test case will become not fragile any more once this filed > issue gets fixed. :) I think this will become less fragile after we fix PR114004 which is the bug I opened to track fixing the superfluous insn that was emitted that we found in this bug. The fragility was due to the superfluous insn being different before and after Roger's patch. Once we don't emit it anymore, this test case should be less fragile. Peter
On Tue, Feb 20, 2024 at 01:49:30PM -0600, Peter Bergner wrote:
> I think this will become less fragile after we fix PR114004 which is
You call it "fragile". I call it the testcase found the exact kind of
bug this testcase was meant to find!
Yes, the test should become quieter when the compiler has fewer bugs :-)
Segher
diff --git a/gcc/testsuite/gcc.target/powerpc/rlwinm-0.c b/gcc/testsuite/gcc.target/powerpc/rlwinm-0.c index 4f4fca2d8ef..a10d9174306 100644 --- a/gcc/testsuite/gcc.target/powerpc/rlwinm-0.c +++ b/gcc/testsuite/gcc.target/powerpc/rlwinm-0.c @@ -4,10 +4,10 @@ /* { dg-final { scan-assembler-times {(?n)^\s+[a-z]} 6739 { target ilp32 } } } */ /* { dg-final { scan-assembler-times {(?n)^\s+[a-z]} 9716 { target lp64 } } } */ /* { dg-final { scan-assembler-times {(?n)^\s+blr} 3375 } } */ -/* { dg-final { scan-assembler-times {(?n)^\s+rldicl} 3081 { target lp64 } } } */ +/* { dg-final { scan-assembler-times {(?n)^\s+rldicl} 3090 { target lp64 } } } */ /* { dg-final { scan-assembler-times {(?n)^\s+rlwinm} 3197 { target ilp32 } } } */ -/* { dg-final { scan-assembler-times {(?n)^\s+rlwinm} 3093 { target lp64 } } } */ +/* { dg-final { scan-assembler-times {(?n)^\s+rlwinm} 3084 { target lp64 } } } */ /* { dg-final { scan-assembler-times {(?n)^\s+rotlwi} 154 } } */ /* { dg-final { scan-assembler-times {(?n)^\s+srwi} 13 { target ilp32 } } } */ /* { dg-final { scan-assembler-times {(?n)^\s+srdi} 13 { target lp64 } } } */