From patchwork Mon Jun 12 11:18:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: jeevitha X-Patchwork-Id: 106506 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp2510136vqr; Mon, 12 Jun 2023 04:19:14 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ71TGMF/nmOPKCvFcEGvdYcj9tPBWZNgFCw+Wc2j49vyEbrRfjpPf335iRuVEBv4Ycooahn X-Received: by 2002:a2e:9b11:0:b0:2ac:6038:ece5 with SMTP id u17-20020a2e9b11000000b002ac6038ece5mr2284442lji.49.1686568753874; Mon, 12 Jun 2023 04:19:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686568753; cv=none; d=google.com; s=arc-20160816; b=q+sjRXcRRl7osaxolzzSMo4cYBSJx8JtWGunEznE8DBHblmgYkRXNfCIR1D9s6JEsu BqLF7aiejk0JXtg+en9Y/TuxiFi5u2a808kS7XwnXZSFUlNmgFjynyl3v+0MOnwYEELg 9Vlen/M29tLyah0SoLnhOKCsHMERLUoTIJGTCwU3xzZGUXV2gSDFo+0Vg2e0/fJE6eAZ Zr/KrxeB3hiFfD6ulbneZjEPf4frQdPF0KwE6zb5vVtuNhvd+2XcNrnETZ3HIu87d6rf krvZhNbrmEBGzrqQOE5qYkGIkiYURg+o+KW+nWnjDhW8hSsOCxmifWwoGW5JEmx4wVzu gzrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:in-reply-to:to:references :content-language:subject:user-agent:mime-version:date:message-id :dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=fhgGueH7OdoMOuYRQnHNOzhJ3bifIF62+afoBa3Kdpo=; b=YmhzCqE6a6ldoVseRtHbTgaIdmJxNGZxgtJhNfMLnUjd0v/NP85tVxwwbTtYNQN25l lMrVYQSsyhkVuE8mUniKzbmJfAyEwyeDAz3XomuSKNd2eFjgVgtSy01cphtAdgFy31xR 28iGngpWh4/71iCfEjjZM48iPran5P38Ed2UmxtvCow32NO8CD0w3VNMGGN9lOwvKZrJ WONQ7JcQHRYwqvmDmVLl+8vZvNN4c2ie0FeBAz20Di9pcdFtKA4LFb1RoDz9iBpx3uUU oozh4ZhMk7Xa0VITqNfSlSCmi0dwpnXj/ZP6pEVtG7c4tsTbwboUHJdiqJuaFZp69xHR VxDQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=rTwYlUds; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id e25-20020a50fb99000000b00518676abc6bsi107142edq.623.2023.06.12.04.19.13 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jun 2023 04:19:13 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=rTwYlUds; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 34DA13858C62 for ; Mon, 12 Jun 2023 11:19:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 34DA13858C62 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1686568751; bh=fhgGueH7OdoMOuYRQnHNOzhJ3bifIF62+afoBa3Kdpo=; h=Date:Subject:References:To:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=rTwYlUdsmAYERt0t+hWRIsfKgNU7OZ8BdANrIkmKVw/ugnucrFUMzq9q8woP34FYt 1hvyOVFt/hVzfJ0kdhuTqExOktG43pRiPo529REjUn4JQ8Fl1+8ncHlkLHMLHQpoOr tAco9phxc/wNV9Mywv0q3oI9NwWK0bIe9bCo8RKc= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id D43723858D20 for ; Mon, 12 Jun 2023 11:18:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D43723858D20 Received: from pps.filterd (m0353727.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 35CBGnbu030799; Mon, 12 Jun 2023 11:18:26 GMT Received: from ppma02wdc.us.ibm.com (aa.5b.37a9.ip4.static.sl-reverse.com [169.55.91.170]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3r62bq80u3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 12 Jun 2023 11:18:26 +0000 Received: from pps.filterd (ppma02wdc.us.ibm.com [127.0.0.1]) by ppma02wdc.us.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 35CAjcgG014531; Mon, 12 Jun 2023 11:18:25 GMT Received: from smtprelay07.dal12v.mail.ibm.com ([9.208.130.99]) by ppma02wdc.us.ibm.com (PPS) with ESMTPS id 3r4gt5ahq6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 12 Jun 2023 11:18:25 +0000 Received: from smtpav03.dal12v.mail.ibm.com (smtpav03.dal12v.mail.ibm.com [10.241.53.102]) by smtprelay07.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 35CBIOw134275962 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 12 Jun 2023 11:18:24 GMT Received: from smtpav03.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 249A158056; Mon, 12 Jun 2023 11:18:24 +0000 (GMT) Received: from smtpav03.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id EEF9E5803F; Mon, 12 Jun 2023 11:18:22 +0000 (GMT) Received: from [9.109.208.172] (unknown [9.109.208.172]) by smtpav03.dal12v.mail.ibm.com (Postfix) with ESMTP; Mon, 12 Jun 2023 11:18:22 +0000 (GMT) Message-ID: Date: Mon, 12 Jun 2023 16:48:21 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: [PATCH] rs6000: Change bitwise xor to inequality operator [PR106907] Content-Language: en-US References: To: gcc-patches@gcc.gnu.org, Peter Bergner , Segher Boessenkool In-Reply-To: X-Forwarded-Message-Id: X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: Ha0YNWQDmFfAhgPpYmjCxyKQptBx2OUP X-Proofpoint-GUID: Ha0YNWQDmFfAhgPpYmjCxyKQptBx2OUP X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26 definitions=2023-06-12_06,2023-06-09_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 adultscore=0 mlxlogscore=999 clxscore=1015 priorityscore=1501 phishscore=0 suspectscore=0 lowpriorityscore=0 malwarescore=0 spamscore=0 bulkscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306120096 X-Spam-Status: No, score=-12.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: P Jeevitha via Gcc-patches From: jeevitha Reply-To: P Jeevitha Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768495517668554834?= X-GMAIL-MSGID: =?utf-8?q?1768495517668554834?= PR106907 has few warnings spotted from cppcheck. Here we have warnings for precedence clarification since boolean results are used in bitwise operation. Bitwise xor performed on bool is similar to checking inequality. So changed to inequality operator (!=) instead of bitwise xor (^). And fixed comment indentation 2023-06-12 Jeevitha Palanisamy gcc/ PR target/106907 * config/rs6000/rs6000.cc (altivec_expand_vec_perm_const): Change bitwise xor to inequality and fix comment indentation. diff --git a/gcc/config/rs6000/rs6000.cc b/gcc/config/rs6000/rs6000.cc index ea68ca6faef..ea7efda8dcd 100644 --- a/gcc/config/rs6000/rs6000.cc +++ b/gcc/config/rs6000/rs6000.cc @@ -23396,10 +23396,10 @@ altivec_expand_vec_perm_const (rtx target, rtx op0, rtx op1, && GET_MODE (XEXP (op0, 0)) != V8HImode))) continue; - /* For little-endian, the two input operands must be swapped - (or swapped back) to ensure proper right-to-left numbering - from 0 to 2N-1. */ - if (swapped ^ !BYTES_BIG_ENDIAN + /* For little-endian, the two input operands must be swapped + (or swapped back) to ensure proper right-to-left numbering + from 0 to 2N-1. */ + if (swapped != !BYTES_BIG_ENDIAN && icode != CODE_FOR_vsx_xxpermdi_v16qi) std::swap (op0, op1); if (imode != V16QImode)