diff mbox series

testsuite: Fix up gcc.target/i386/sse4_1-stv-1.c test [PR113452]

Message ID ZajVuimv6Cy7q7F3@tucnak
State Unresolved
Headers
Series testsuite: Fix up gcc.target/i386/sse4_1-stv-1.c test [PR113452] |

Checks

Context Check Description
snail/gcc-patch-check warning Git am fail log

Commit Message

Jakub Jelinek Jan. 18, 2024, 7:39 a.m. UTC 
  Hi!

From what I can see, this test has been written for a backend fix and
assumes the loop isn't vectorized (at least, it wasn't when the test was
added, it contains an early exit), but that is no longer true and because
of the vectorization it now contains an instruction which the test scans
for not being present.

I think we should just disable vectorization here.

Regtested on x86_64-linux and i686-linux, ok for trunk?

2024-01-18  Jakub Jelinek  <jakub@redhat.com>

	PR testsuite/113452
	* gcc.target/i386/sse4_1-stv-1.c: Add -fno-tree-vectorize to
	dg-options.


	Jakub

Comments

Richard Biener Jan. 18, 2024, 7:35 a.m. UTC | #1 
On Thu, 18 Jan 2024, Jakub Jelinek wrote:

> Hi!
> 
> From what I can see, this test has been written for a backend fix and
> assumes the loop isn't vectorized (at least, it wasn't when the test was
> added, it contains an early exit), but that is no longer true and because
> of the vectorization it now contains an instruction which the test scans
> for not being present.
> 
> I think we should just disable vectorization here.
> 
> Regtested on x86_64-linux and i686-linux, ok for trunk?

OK

> 2024-01-18  Jakub Jelinek  <jakub@redhat.com>
> 
> 	PR testsuite/113452
> 	* gcc.target/i386/sse4_1-stv-1.c: Add -fno-tree-vectorize to
> 	dg-options.
> 
> --- gcc/testsuite/gcc.target/i386/sse4_1-stv-1.c.jj	2022-05-31 11:33:51.603250042 +0200
> +++ gcc/testsuite/gcc.target/i386/sse4_1-stv-1.c	2024-01-17 17:46:21.999689350 +0100
> @@ -1,5 +1,5 @@
>  /* { dg-do compile { target ia32 } } */
> -/* { dg-options "-O2 -msse4.1 -mstv -mno-stackrealign" } */
> +/* { dg-options "-O2 -msse4.1 -mstv -mno-stackrealign -fno-tree-vectorize" } */
>  long long a[1024];
>  long long b[1024];
>  
> 
> 	Jakub
diff mbox series

Patch

--- gcc/testsuite/gcc.target/i386/sse4_1-stv-1.c.jj	2022-05-31 11:33:51.603250042 +0200
+++ gcc/testsuite/gcc.target/i386/sse4_1-stv-1.c	2024-01-17 17:46:21.999689350 +0100
@@ -1,5 +1,5 @@ 
 /* { dg-do compile { target ia32 } } */
-/* { dg-options "-O2 -msse4.1 -mstv -mno-stackrealign" } */
+/* { dg-options "-O2 -msse4.1 -mstv -mno-stackrealign -fno-tree-vectorize" } */
 long long a[1024];
 long long b[1024];