From patchwork Mon Aug 14 15:59:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Hubicka X-Patchwork-Id: 135527 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b824:0:b0:3f2:4152:657d with SMTP id z4csp2838488vqi; Mon, 14 Aug 2023 09:00:43 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEaXAV5UVqFRmOZbBE+kLF8CjvOOZDYYw4cLa2XX72QP1Hk899jVJ5Y6d3EHeO7qN3CW51Q X-Received: by 2002:aa7:c592:0:b0:525:58aa:6c83 with SMTP id g18-20020aa7c592000000b0052558aa6c83mr4061609edq.11.1692028843449; Mon, 14 Aug 2023 09:00:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1692028843; cv=none; d=google.com; s=arc-20160816; b=vx6Fv+p3/Y8DzfOdEPUyEhbN+10kJx+KvXzFJsoh41KPBLBhwN8T/dEeVeczSAaT0O VeKTbTGwC21L2lY0+lh7fcVIW3ukSBH1OgMRRgnt7pOv3y7lp27hSgjIJREKl5ObwqD1 Y71BlAt0Oy6rAaouml9/f8J+ABXALIh8Kb3WehdryFSxiuZVK3887Dzpps81dfOMnMND CM+/Zn2fmmkU7bqZ4Nqc1tK38iQLWfTjwr52u2v/MXcmTiYVSkzHm8lz5FVDwYD0pv2D 4dnkdbr5bKVsC9Bqvhn4f5lobMfK560LKAW6MxcBAMwXYp0KHxGKcc70FyiHFFKCH1W/ TdwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-disposition:mime-version:message-id:subject:to:date :dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=qXbZcCFO3iiw+xOU956d8bRXHMC/kmMLHi3jmWreGHA=; fh=KxPrluukuxmHUzYWntxWAHNXePa4vWvGreVeug6Wy5k=; b=q3He03bvefLeJipIdEal2S6E4yXXi8U09WIxmvgqhZg4RxAJVZDJL8KFQIKmw0R7iD XSDDoylFrH47ZhoJaNq43iK5YscCg8iaB8bNkOG4P6Nzz1owzOJe2ySmULiZjki/C3Tp XKULh3lUn6qrjlx90dnv5H5OJnje9Yq/xhnYNvbhui9P4QbunzakpEjhNhVUO/L4shgy t1lN3DGfIDSSsnJGT/lodxWRLHIs27IMgv+vKwNlWEbzVw5Dn0+rdGaO2P15nLGQ+LDD EsexpAWrct6OtwUu+S5Sj2cmitvgj4riECDHrSxjnNDAuI4NdP5r8KLJOAd8Jop1auz/ cyUw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=jYrWMZ6z; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id q2-20020aa7da82000000b005254add9a47si4006738eds.276.2023.08.14.09.00.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Aug 2023 09:00:43 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=jYrWMZ6z; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 24B123858423 for ; Mon, 14 Aug 2023 16:00:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 24B123858423 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1692028842; bh=qXbZcCFO3iiw+xOU956d8bRXHMC/kmMLHi3jmWreGHA=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=jYrWMZ6zH2d9+njwIhxPCLpkOJmqzOYnfi5O4ebrxKHNNGPxEh34CDpfX5InxyLFH UgIdixRiLein7tijjUQvgO7j+Hpuh4aQUX6Ia3FzLynJFqgSSn/Zl6QCpMSBpT7HYT Af/t7LvPXL3BUA+UK5B+72ZnnTxRAM4owPe8XNKE= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from nikam.ms.mff.cuni.cz (nikam.ms.mff.cuni.cz [195.113.20.16]) by sourceware.org (Postfix) with ESMTPS id E83493858C20 for ; Mon, 14 Aug 2023 15:59:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E83493858C20 Received: by nikam.ms.mff.cuni.cz (Postfix, from userid 16202) id 5AD0D281300; Mon, 14 Aug 2023 17:59:53 +0200 (CEST) Date: Mon, 14 Aug 2023 17:59:53 +0200 To: gcc-patches@gcc.gnu.org Subject: Avoid division by zero in fold_loop_internal_call Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, JMQ_SPF_NEUTRAL, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Jan Hubicka via Gcc-patches From: Jan Hubicka Reply-To: Jan Hubicka Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1774220836156182825 X-GMAIL-MSGID: 1774220836156182825 Hi, My patch to fix profile after folding internal call is missing check for the case profile was already zero before if-conversion. Bootstrapped/regtested x86_64-linux, comitted. gcc/ChangeLog: PR gcov-profile/110988 * tree-cfg.cc (fold_loop_internal_call): Avoid division by zero. diff --git a/gcc/tree-cfg.cc b/gcc/tree-cfg.cc index ab1f8067c54..105f4b1c953 100644 --- a/gcc/tree-cfg.cc +++ b/gcc/tree-cfg.cc @@ -7734,11 +7734,14 @@ fold_loop_internal_call (gimple *g, tree value) test. This should not happen as the guarded code should start with pre-header. */ gcc_assert (single_pred_edge (taken_edge->dest)); - taken_edge->dest->count - = taken_edge->dest->count.apply_scale (new_count, - old_count); - scale_strictly_dominated_blocks (taken_edge->dest, - new_count, old_count); + if (old_count.nonzero_p ()) + { + taken_edge->dest->count + = taken_edge->dest->count.apply_scale (new_count, + old_count); + scale_strictly_dominated_blocks (taken_edge->dest, + new_count, old_count); + } } } }