diff mbox series

[1/12] expr: Small optimization [PR102989]

Message ID	ZNPXsZL3/mmxuDT5@tucnak
State	Unresolved
Headers	Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6B6B13857B9B Date: Wed, 9 Aug 2023 20:15:13 +0200 To: Richard Biener <rguenther@suse.de> Cc: gcc-patches@gcc.gnu.org Subject: [PATCH 1/12] expr: Small optimization [PR102989] Message-ID: <ZNPXsZL3/mmxuDT5@tucnak> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Precedence: list From: Jakub Jelinek via Gcc-patches <gcc-patches@gcc.gnu.org> Reply-To: Jakub Jelinek <jakub@redhat.com> Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" <gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org> X-getmail-retrieved-from-mailbox: INBOX
Series	GCC _BitInt support [PR102989] \| [0/12] GCC _BitInt support [PR102989] [1/12] expr: Small optimization [PR102989] [2/12] lto-streamer-in: Adjust assert [PR102989] [3/12] phiopt: Fix phiopt ICE on vops [PR102989] [4/12] Middle-end _BitInt support [PR102989] [5/12] _BitInt lowering support [PR102989] [6/12] i386: Enable _BitInt on x86-64 [PR102989] [7/12] ubsan: _BitInt -fsanitize=undefined support [PR102989] [8/12] libgcc: Generated tables for _BitInt <-> _Decimal* conversions [PR102989] [9/12] libgcc _BitInt support [PR102989] [10/12] C _BitInt support [PR102989] [11/12] testsuite part 1 for _BitInt support [PR102989] [12/12] testsuite part 2 for _BitInt support [PR102989] [13/12] C _BitInt incremental fixes [PR102989] [14/12] libgcc _BitInt helper documentation [PR102989]

Checks

Context	Check	Description
snail/gcc-patch-check	warning	Git am fail log

Commit Message

Jakub Jelinek Aug. 9, 2023, 6:15 p.m. UTC

  Hi!

Small optimization to avoid testing modifier multiple times.

2023-08-09  Jakub Jelinek  <jakub@redhat.com>

	PR c/102989
	* expr.cc (expand_expr_real_1) <case MEM_REF>: Add an early return for
	EXPAND_WRITE or EXPAND_MEMORY modifiers to avoid testing it multiple
	times.


	Jakub

Comments

Richard Biener Aug. 10, 2023, 7:18 a.m. UTC | #1

On Wed, 9 Aug 2023, Jakub Jelinek wrote:

> Hi!
> 
> Small optimization to avoid testing modifier multiple times.

OK.

Richard.

> 2023-08-09  Jakub Jelinek  <jakub@redhat.com>
> 
> 	PR c/102989
> 	* expr.cc (expand_expr_real_1) <case MEM_REF>: Add an early return for
> 	EXPAND_WRITE or EXPAND_MEMORY modifiers to avoid testing it multiple
> 	times.
> 
> --- gcc/expr.cc.jj	2023-08-08 15:55:06.499164554 +0200
> +++ gcc/expr.cc	2023-08-08 15:59:36.594382141 +0200
> @@ -11248,17 +11248,15 @@ expand_expr_real_1 (tree exp, rtx target
>  	set_mem_addr_space (temp, as);
>  	if (TREE_THIS_VOLATILE (exp))
>  	  MEM_VOLATILE_P (temp) = 1;
> -	if (modifier != EXPAND_WRITE
> -	    && modifier != EXPAND_MEMORY
> -	    && !inner_reference_p
> +	if (modifier == EXPAND_WRITE || modifier == EXPAND_MEMORY)
> +	  return temp;
> +	if (!inner_reference_p
>  	    && mode != BLKmode
>  	    && align < GET_MODE_ALIGNMENT (mode))
>  	  temp = expand_misaligned_mem_ref (temp, mode, unsignedp, align,
>  					    modifier == EXPAND_STACK_PARM
>  					    ? NULL_RTX : target, alt_rtl);
> -	if (reverse
> -	    && modifier != EXPAND_MEMORY
> -	    && modifier != EXPAND_WRITE)
> +	if (reverse)
>  	  temp = flip_storage_order (mode, temp);
>  	return temp;
>        }
> 
> 	Jakub
> 
>

diff mbox series

Patch

--- gcc/expr.cc.jj	2023-08-08 15:55:06.499164554 +0200
+++ gcc/expr.cc	2023-08-08 15:59:36.594382141 +0200
@@ -11248,17 +11248,15 @@  expand_expr_real_1 (tree exp, rtx target
 	set_mem_addr_space (temp, as);
 	if (TREE_THIS_VOLATILE (exp))
 	  MEM_VOLATILE_P (temp) = 1;
-	if (modifier != EXPAND_WRITE
-	    && modifier != EXPAND_MEMORY
-	    && !inner_reference_p
+	if (modifier == EXPAND_WRITE || modifier == EXPAND_MEMORY)
+	  return temp;
+	if (!inner_reference_p
 	    && mode != BLKmode
 	    && align < GET_MODE_ALIGNMENT (mode))
 	  temp = expand_misaligned_mem_ref (temp, mode, unsignedp, align,
 					    modifier == EXPAND_STACK_PARM
 					    ? NULL_RTX : target, alt_rtl);
-	if (reverse
-	    && modifier != EXPAND_MEMORY
-	    && modifier != EXPAND_WRITE)
+	if (reverse)
 	  temp = flip_storage_order (mode, temp);
 	return temp;
       }