Message ID | ZKxjMDOl1K/d5z23@cowardly-lion.the-meissners.org |
---|---|
State | Accepted |
Headers |
Return-Path: <gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a6b2:0:b0:3e4:2afc:c1 with SMTP id c18csp40563vqm; Mon, 10 Jul 2023 13:00:36 -0700 (PDT) X-Google-Smtp-Source: APBJJlEvoScQd13p3LR86eHnEE1zt/bWJp2IhlPB5t0BAmHTMV0IOAdUmWJDBZ+5WtYGfdWpgtfh X-Received: by 2002:ac2:5b9b:0:b0:4fb:79b5:5512 with SMTP id o27-20020ac25b9b000000b004fb79b55512mr9832383lfn.66.1689019236279; Mon, 10 Jul 2023 13:00:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689019236; cv=none; d=google.com; s=arc-20160816; b=BXJ9WeXa3X4JuzBh3njqgt+pXyaEsEGSQwsEy4LzSXZFAwf+ghXJCfPk+tFoJy8VjH RGfysqz63QfLYPefFTptUOr2MMCNIdtlN3CO8H1jaLbPUqLEDZqwJmxV0z0tcPRPLHzI tD7Mi02+rVIU7fTAuWasr6Y5FwOUy20VT5Yn22zU4y63tOINoEZeWxkXgmNXtnqpZWq0 sZfmUTIyIn5vR8aZ6tNUh5lJkIv9blCcQk9Kd1AZd6GBrNPf3owjbKycFtF9NL2irjjs XvhzWguS2aHKMVUJOH7Tg6kXBeZdhci6t6idYjM01PKrxN6LVY5UJi51RibJafrInxOJ ZqXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-disposition:mime-version:mail-followup-to:message-id :subject:to:date:dmarc-filter:delivered-to:dkim-signature :dkim-filter; bh=hAS5BkwA99l0dWBZtZLx4cXONxcxQwz5VDTjTMCJEFA=; fh=G31eX21wCcEqFjJsAmn+T8P4BB0cHqyGTPRBQN0jWh4=; b=HRZOAx3lJ3rPY+coZH/MCtJrMkWu5IqPyBxsbX13Xs9jDJ6D5eTyfjG6C9kpcdjyEc /FsOQjFc9IYHKHHjQ1eOJf9PkFax4mttPyUrQmoBoNxZWi9j7AzbGrZfQU78Q/dhi/Mb ABoPDj2wof0zhW5w0/y6/WXE5Dm/pAF/sbsq2QNAHRUjqSBKIY5QpxvP1cumRjM2U5zR 5yvx8hdM6DZpBp/JfLXQWACKfzVKTJNmq6GadijlG+TRCBmZ/gqE2AousNQDQmIICK3R IgoonZTspCHJl0ZEFwhVSwYDG8RobTzTJSdp6M1NAtTE9h6IHKO/Q2TnFEK2H01sTKck b8Jg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=OFEDx4n1; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id f19-20020a056402151300b0051e049cfef9si234235edw.208.2023.07.10.13.00.35 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Jul 2023 13:00:36 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=OFEDx4n1; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 25ED13857B98 for <ouuuleilei@gmail.com>; Mon, 10 Jul 2023 20:00:35 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 25ED13857B98 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1689019235; bh=hAS5BkwA99l0dWBZtZLx4cXONxcxQwz5VDTjTMCJEFA=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=OFEDx4n1oAq5N4zwQ31rBlKIREGUAT5n9fi+BNJ732MPYnHnCrgLPqK5eTcSa/Sj5 Ai4a4qB06WfIcx6FBGBSFX79EJBRx/it81nGEdSd746p/D1zG+GzbxJnehLvV6OJNO UB1NdzJeU2ygl+yL3SVdoz/j+5dLFX90NMpdzENg= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id AF47C3858CDA for <gcc-patches@gcc.gnu.org>; Mon, 10 Jul 2023 19:59:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AF47C3858CDA Received: from pps.filterd (m0353724.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 36AJl59S029868; Mon, 10 Jul 2023 19:59:50 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3rrrerr84a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 10 Jul 2023 19:59:49 +0000 Received: from m0353724.ppops.net (m0353724.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 36AJm4eU032100; Mon, 10 Jul 2023 19:59:49 GMT Received: from ppma01wdc.us.ibm.com (fd.55.37a9.ip4.static.sl-reverse.com [169.55.85.253]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3rrrerr845-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 10 Jul 2023 19:59:49 +0000 Received: from pps.filterd (ppma01wdc.us.ibm.com [127.0.0.1]) by ppma01wdc.us.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 36AJwC7f004255; Mon, 10 Jul 2023 19:59:49 GMT Received: from smtprelay06.wdc07v.mail.ibm.com ([9.208.129.118]) by ppma01wdc.us.ibm.com (PPS) with ESMTPS id 3rpye5kf2r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 10 Jul 2023 19:59:48 +0000 Received: from smtpav06.wdc07v.mail.ibm.com (smtpav06.wdc07v.mail.ibm.com [10.39.53.233]) by smtprelay06.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 36AJxli462390628 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 10 Jul 2023 19:59:47 GMT Received: from smtpav06.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5444958054; Mon, 10 Jul 2023 19:59:47 +0000 (GMT) Received: from smtpav06.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A36FB5803F; Mon, 10 Jul 2023 19:59:46 +0000 (GMT) Received: from cowardly-lion.the-meissners.org (unknown [9.61.34.183]) by smtpav06.wdc07v.mail.ibm.com (Postfix) with ESMTPS; Mon, 10 Jul 2023 19:59:46 +0000 (GMT) Date: Mon, 10 Jul 2023 15:59:44 -0400 To: gcc-patches@gcc.gnu.org, Michael Meissner <meissner@linux.ibm.com>, Segher Boessenkool <segher@kernel.crashing.org>, "Kewen.Lin" <linkw@linux.ibm.com>, David Edelsohn <dje.gcc@gmail.com>, Peter Bergner <bergner@linux.ibm.com> Subject: [PATCH] Fix typo in insn name. Message-ID: <ZKxjMDOl1K/d5z23@cowardly-lion.the-meissners.org> Mail-Followup-To: Michael Meissner <meissner@linux.ibm.com>, gcc-patches@gcc.gnu.org, Segher Boessenkool <segher@kernel.crashing.org>, "Kewen.Lin" <linkw@linux.ibm.com>, David Edelsohn <dje.gcc@gmail.com>, Peter Bergner <bergner@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: CZUuFMYlA3-lheMTNwn6vSAf5Ri5Sft7 X-Proofpoint-GUID: pbDf6OO8w0JU6HN7F5fDB8M_vPEBYLYM X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-07-10_14,2023-07-06_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 bulkscore=0 spamscore=0 malwarescore=0 suspectscore=0 mlxscore=0 clxscore=1015 mlxlogscore=999 adultscore=0 lowpriorityscore=0 priorityscore=1501 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2307100177 X-Spam-Status: No, score=-10.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> From: Michael Meissner via Gcc-patches <gcc-patches@gcc.gnu.org> Reply-To: Michael Meissner <meissner@linux.ibm.com> Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" <gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org> X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771065034424211823 X-GMAIL-MSGID: 1771065034424211823 |
Series |
Fix typo in insn name.
|
|
Checks
Context | Check | Description |
---|---|---|
snail/gcc-patch-check | success | Github commit url |
Commit Message
Michael Meissner
July 10, 2023, 7:59 p.m. UTC
In doing other work, I noticed that there was an insn: vsx_extract_v4sf_<mode>_load Which did not have an iterator. I removed the useless <mode>. I have tested this patch on the following systems and there was no degration. Can I check it into the trunk branch? * Power10, LE, --with-cpu=power10, IBM 128-bit long double * Power9, LE, --with-cpu=power9, IBM 128-bit long double * Power9, LE, --with-cpu=power9, IEEE 128-bit long double * Power9, LE, --with-cpu=power9, 64-bit default long double * Power9, BE, --with-cpu=power9, IBM 128-bit long double * Power8, BE, --with-cpu=power8, IBM 128-bit long double 2023-07-10 Michael Meissner <meissner@linux.ibm.com> gcc/ * config/rs6000/vsx.md (vsx_extract_v4sf_load): Rename from vsx_extract_v4sf_<mode>_load. --- gcc/config/rs6000/vsx.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Hi! On Mon, Jul 10, 2023 at 03:59:44PM -0400, Michael Meissner wrote: > In doing other work, I noticed that there was an insn: > > vsx_extract_v4sf_<mode>_load > > Which did not have an iterator. I removed the useless <mode>. This patch does that, you mean. > --- a/gcc/config/rs6000/vsx.md > +++ b/gcc/config/rs6000/vsx.md > @@ -3576,7 +3576,7 @@ (define_insn_and_split "vsx_extract_v4sf" > [(set_attr "length" "8") > (set_attr "type" "fp")]) > > -(define_insn_and_split "*vsx_extract_v4sf_<mode>_load" > +(define_insn_and_split "*vsx_extract_v4sf_load" > [(set (match_operand:SF 0 "register_operand" "=f,v,v,?r") > (vec_select:SF > (match_operand:V4SF 1 "memory_operand" "m,Z,m,m") Does this fix any ICEs? Or do you have some example that makes better machine code after this change? Or would a better change perhaps be to just remove this pattern completely, if it doesn't do anything useful? I.e., please include a new testcase. Segher
On Mon, Jul 10, 2023 at 03:10:21PM -0500, Segher Boessenkool wrote: > Hi! > > On Mon, Jul 10, 2023 at 03:59:44PM -0400, Michael Meissner wrote: > > In doing other work, I noticed that there was an insn: > > > > vsx_extract_v4sf_<mode>_load > > > > Which did not have an iterator. I removed the useless <mode>. > > This patch does that, you mean. > > > --- a/gcc/config/rs6000/vsx.md > > +++ b/gcc/config/rs6000/vsx.md > > @@ -3576,7 +3576,7 @@ (define_insn_and_split "vsx_extract_v4sf" > > [(set_attr "length" "8") > > (set_attr "type" "fp")]) > > > > -(define_insn_and_split "*vsx_extract_v4sf_<mode>_load" > > +(define_insn_and_split "*vsx_extract_v4sf_load" > > [(set (match_operand:SF 0 "register_operand" "=f,v,v,?r") > > (vec_select:SF > > (match_operand:V4SF 1 "memory_operand" "m,Z,m,m") > > Does this fix any ICEs? Or do you have some example that makes better > machine code after this change? Or would a better change perhaps be to > just remove this pattern completely, if it doesn't do anything useful? > > I.e., please include a new testcase. There is absolutely no code change. It is purely a cleanup patch. In doing other patches, I just noticed that pattern had a _<mode> in it when it didn't have an iterator. I just cleaned up the code removing _<mode>. I probably should have changed it to vsx_extract_v4sf_sf_load.
Ping clean-up patch. | Date: Mon, 10 Jul 2023 15:59:44 -0400 | From: Michael Meissner <meissner@linux.ibm.com> | Subject: [PATCH] Fix typo in insn name. | Message-ID: <ZKxjMDOl1K/d5z23@cowardly-lion.the-meissners.org> As I said in the reply, the only thing this patch does is to rename vsx_extract_v4sf_<mode>_load to vsx_extract_v4sf_load since the insn does not use a mode iterator.
Hi Mike, on 2023/7/11 03:59, Michael Meissner wrote: > In doing other work, I noticed that there was an insn: > > vsx_extract_v4sf_<mode>_load > > Which did not have an iterator. I removed the useless <mode>. It actually has a mode iterator, the "P" is used for clobber. The whole pattern of this define_insn_and_split is (define_insn_and_split "*vsx_extract_v4sf_<mode>_load" [(set (match_operand:SF 0 "register_operand" "=f,v,v,?r") (vec_select:SF (match_operand:V4SF 1 "memory_operand" "m,Z,m,m") (parallel [(match_operand:QI 2 "const_0_to_3_operand" "n,n,n,n")]))) (clobber (match_scratch:P 3 "=&b,&b,&b,&b"))] <== *P used here* Its definition is: (define_mode_iterator P [(SI "TARGET_32BIT") (DI "TARGET_64BIT")]) I guess we can just leave it there? BR, Kewen > > I have tested this patch on the following systems and there was no degration. > Can I check it into the trunk branch? > > * Power10, LE, --with-cpu=power10, IBM 128-bit long double > * Power9, LE, --with-cpu=power9, IBM 128-bit long double > * Power9, LE, --with-cpu=power9, IEEE 128-bit long double > * Power9, LE, --with-cpu=power9, 64-bit default long double > * Power9, BE, --with-cpu=power9, IBM 128-bit long double > * Power8, BE, --with-cpu=power8, IBM 128-bit long double > > 2023-07-10 Michael Meissner <meissner@linux.ibm.com> > > gcc/ > > * config/rs6000/vsx.md (vsx_extract_v4sf_load): Rename from > vsx_extract_v4sf_<mode>_load. > --- > gcc/config/rs6000/vsx.md | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gcc/config/rs6000/vsx.md b/gcc/config/rs6000/vsx.md > index d34c3b21abe..aed450e31ec 100644 > --- a/gcc/config/rs6000/vsx.md > +++ b/gcc/config/rs6000/vsx.md > @@ -3576,7 +3576,7 @@ (define_insn_and_split "vsx_extract_v4sf" > [(set_attr "length" "8") > (set_attr "type" "fp")]) > > -(define_insn_and_split "*vsx_extract_v4sf_<mode>_load" > +(define_insn_and_split "*vsx_extract_v4sf_load" > [(set (match_operand:SF 0 "register_operand" "=f,v,v,?r") > (vec_select:SF > (match_operand:V4SF 1 "memory_operand" "m,Z,m,m")
On Wed, Jul 26, 2023 at 01:54:01PM +0800, Kewen.Lin wrote: > Hi Mike, > > on 2023/7/11 03:59, Michael Meissner wrote: > > In doing other work, I noticed that there was an insn: > > > > vsx_extract_v4sf_<mode>_load > > > > Which did not have an iterator. I removed the useless <mode>. > > It actually has a mode iterator, the "P" is used for clobber. > > The whole pattern of this define_insn_and_split is > > (define_insn_and_split "*vsx_extract_v4sf_<mode>_load" > [(set (match_operand:SF 0 "register_operand" "=f,v,v,?r") > (vec_select:SF > (match_operand:V4SF 1 "memory_operand" "m,Z,m,m") > (parallel [(match_operand:QI 2 "const_0_to_3_operand" "n,n,n,n")]))) > (clobber (match_scratch:P 3 "=&b,&b,&b,&b"))] <== *P used here* > > Its definition is: > > (define_mode_iterator P [(SI "TARGET_32BIT") (DI "TARGET_64BIT")]) > > I guess we can just leave it there? > > BR, > Kewen Yes, I didn't notice the :P in the insn.
diff --git a/gcc/config/rs6000/vsx.md b/gcc/config/rs6000/vsx.md index d34c3b21abe..aed450e31ec 100644 --- a/gcc/config/rs6000/vsx.md +++ b/gcc/config/rs6000/vsx.md @@ -3576,7 +3576,7 @@ (define_insn_and_split "vsx_extract_v4sf" [(set_attr "length" "8") (set_attr "type" "fp")]) -(define_insn_and_split "*vsx_extract_v4sf_<mode>_load" +(define_insn_and_split "*vsx_extract_v4sf_load" [(set (match_operand:SF 0 "register_operand" "=f,v,v,?r") (vec_select:SF (match_operand:V4SF 1 "memory_operand" "m,Z,m,m")