diff mbox series

[committed] libgomp: Appease some static analyzers [PR106906]

Message ID YyC4X5weKJ5HpmpZ@tucnak
State New, archived
Headers
Series [committed] libgomp: Appease some static analyzers [PR106906] |

Commit Message

Jakub Jelinek Sept. 13, 2022, 5:05 p.m. UTC 
  Hi!

While icv_addr[1] = false; assignments where icv_addr has void *
element type is correct and matches how it is used (in those cases
the void * pointer is then cast to bool and used that way), there is no
reason not to add explicit (void *) casts there which are there already
for (void *) true.  And, there is in fact even no point in actually
doing those stores at all because we set that pointer to NULL a few
lines earlier.  So, this patch adds the explicit casts and then
comments those out to show intent.

Bootstrapped/regtested on x86_64-linux and i686-linux, committed to trunk.

2022-09-13  Jakub Jelinek  <jakub@redhat.com>

	PR libgomp/106906
	* env.c (get_icv_member_addr): Cast false to void * before assigning
	it to icv_addr[1], and comment the whole assignment out.


	Jakub
diff mbox series

Patch

--- libgomp/env.c.jj	2022-09-12 10:32:00.935086858 +0200
+++ libgomp/env.c	2022-09-12 13:27:22.893571697 +0200
@@ -1892,14 +1892,14 @@  get_icv_member_addr (struct gomp_initial
     {
     case GOMP_ICV_NTEAMS:
       icv_addr[0] = &icvs->nteams_var;
-      icv_addr[1] = false;
+      /* icv_addr[1] = (void *) false; */
       break;
     case GOMP_ICV_DYNAMIC:
       icv_addr[0] = &(*icvs).dyn_var;
       break;
     case GOMP_ICV_TEAMS_THREAD_LIMIT:
       icv_addr[0] = &icvs->teams_thread_limit_var;
-      icv_addr[1] = false;
+      /* icv_addr[1] = (void *) false; */
       break;
     case GOMP_ICV_SCHEDULE:
       icv_addr[0] = &icvs->run_sched_var;
@@ -1907,7 +1907,7 @@  get_icv_member_addr (struct gomp_initial
       break;
     case GOMP_ICV_THREAD_LIMIT:
       icv_addr[0] = &icvs->thread_limit_var;
-      icv_addr[1] = false;
+      /* icv_addr[1] = (void *) false; */
       icv_addr[2] = (void *) UINT_MAX;
       break;
     case GOMP_ICV_NTHREADS: