diff mbox series

[v2,2/4] aarch64: Remove qualifier_internal

Message ID Ys7LVCj5W4ZcPn1Q@e124511.cambridge.arm.com
State New, archived
Headers
Series None |

Commit Message

Andrew Carlotti July 13, 2022, 1:40 p.m. UTC 
  This has been unused since 2014, so there's no reason to retain it.

gcc/ChangeLog:

	* config/aarch64/aarch64-builtins.cc
	(enum aarch64_type_qualifiers): Remove qualifier_internal.
	(aarch64_init_simd_builtin_functions): Remove qualifier_internal check.

---

Comments

Richard Sandiford July 13, 2022, 4:04 p.m. UTC | #1 
Andrew Carlotti <andrew.carlotti@arm.com> writes:
> This has been unused since 2014, so there's no reason to retain it.
>
> gcc/ChangeLog:
>
> 	* config/aarch64/aarch64-builtins.cc
> 	(enum aarch64_type_qualifiers): Remove qualifier_internal.
> 	(aarch64_init_simd_builtin_functions): Remove qualifier_internal check.

OK, thanks.

Richard

> ---
>
> diff --git a/gcc/config/aarch64/aarch64-builtins.cc b/gcc/config/aarch64/aarch64-builtins.cc
> index 52d27c6978990ca3e6c523654fe1cdc952e77ad7..55ad2e8b6831d6cc2b039270c8656d429347092d 100644
> --- a/gcc/config/aarch64/aarch64-builtins.cc
> +++ b/gcc/config/aarch64/aarch64-builtins.cc
> @@ -145,9 +145,7 @@ enum aarch64_type_qualifiers
>    qualifier_maybe_immediate = 0x10, /* 1 << 4  */
>    /* void foo (...).  */
>    qualifier_void = 0x20, /* 1 << 5  */
> -  /* Some patterns may have internal operands, this qualifier is an
> -     instruction to the initialisation code to skip this operand.  */
> -  qualifier_internal = 0x40, /* 1 << 6  */
> +  /* 1 << 6 is now unused */
>    /* Some builtins should use the T_*mode* encoded in a simd_builtin_datum
>       rather than using the type of the operand.  */
>    qualifier_map_mode = 0x80, /* 1 << 7  */
> @@ -1207,10 +1205,6 @@ aarch64_init_simd_builtin_functions (bool called_from_pragma)
>  	  else
>  	    type_signature[op_num] = 's';
>  
> -	  /* Skip an internal operand for vget_{low, high}.  */
> -	  if (qualifiers & qualifier_internal)
> -	    continue;
> -
>  	  /* Some builtins have different user-facing types
>  	     for certain arguments, encoded in d->mode.  */
>  	  if (qualifiers & qualifier_map_mode)
diff mbox series

Patch

diff --git a/gcc/config/aarch64/aarch64-builtins.cc b/gcc/config/aarch64/aarch64-builtins.cc
index 52d27c6978990ca3e6c523654fe1cdc952e77ad7..55ad2e8b6831d6cc2b039270c8656d429347092d 100644
--- a/gcc/config/aarch64/aarch64-builtins.cc
+++ b/gcc/config/aarch64/aarch64-builtins.cc
@@ -145,9 +145,7 @@  enum aarch64_type_qualifiers
   qualifier_maybe_immediate = 0x10, /* 1 << 4  */
   /* void foo (...).  */
   qualifier_void = 0x20, /* 1 << 5  */
-  /* Some patterns may have internal operands, this qualifier is an
-     instruction to the initialisation code to skip this operand.  */
-  qualifier_internal = 0x40, /* 1 << 6  */
+  /* 1 << 6 is now unused */
   /* Some builtins should use the T_*mode* encoded in a simd_builtin_datum
      rather than using the type of the operand.  */
   qualifier_map_mode = 0x80, /* 1 << 7  */
@@ -1207,10 +1205,6 @@  aarch64_init_simd_builtin_functions (bool called_from_pragma)
 	  else
 	    type_signature[op_num] = 's';
 
-	  /* Skip an internal operand for vget_{low, high}.  */
-	  if (qualifiers & qualifier_internal)
-	    continue;
-
 	  /* Some builtins have different user-facing types
 	     for certain arguments, encoded in d->mode.  */
 	  if (qualifiers & qualifier_map_mode)