[committed] docs: Fix peephole paragraph ordering

Message ID Y6SOhUlYMGLtprFN@e124511.cambridge.arm.com
State Repeat Merge
Headers
Series [committed] docs: Fix peephole paragraph ordering |

Checks

Context Check Description
snail/gcc-patch-check warning Git am fail log

Commit Message

Andrew Carlotti Dec. 22, 2022, 5:06 p.m. UTC
  The documentation for the DONE and FAIL macros was incorrectly inserted
between example code, and a remark attached to that example.

Committed as obvious.

gcc/ChangeLog:

	* doc/md.texi: Move example code remark next to it's code block.

---
  

Comments

Andrew Carlotti Dec. 22, 2022, 5:15 p.m. UTC | #1
Patches attached to the wrong email - this patch was actually:

On Thu, Dec 22, 2022 at 05:06:13PM +0000, Andrew Carlotti via Gcc-patches wrote:
> The documentation for the DONE and FAIL macros was incorrectly inserted
> between example code, and a remark attached to that example.
> 
> Committed as obvious.
> 
> gcc/ChangeLog:
> 
> 	* doc/md.texi: Move example code remark next to it's code block.
> 
> ---

diff --git a/gcc/doc/md.texi b/gcc/doc/md.texi
index cc28f868fc85b5148450548a54d69a39ecc4f03a..c1d3ae2060d800bbaa9751fcf841d7417af1e37d 100644
--- a/gcc/doc/md.texi
+++ b/gcc/doc/md.texi
@@ -9321,6 +9321,11 @@ so here's a silly made-up example:
   "")
 @end smallexample
 
+@noindent
+If we had not added the @code{(match_dup 4)} in the middle of the input
+sequence, it might have been the case that the register we chose at the
+beginning of the sequence is killed by the first or second @code{set}.
+
 There are two special macros defined for use in the preparation statements:
 @code{DONE} and @code{FAIL}.  Use them with a following semicolon,
 as a statement.
@@ -9348,11 +9353,6 @@ If the preparation falls through (invokes neither @code{DONE} nor
 @code{FAIL}), then the @code{define_peephole2} uses the replacement
 template.
 
-@noindent
-If we had not added the @code{(match_dup 4)} in the middle of the input
-sequence, it might have been the case that the register we chose at the
-beginning of the sequence is killed by the first or second @code{set}.
-
 @end ifset
 @ifset INTERNALS
 @node Insn Attributes
  

Patch

diff --git a/gcc/doc/md.texi b/gcc/doc/md.texi
index 482e86f15d8b312c67d4962510ce879fb5cbc541..78dc6d720700ca409677e44a34a60d4b7fceb046 100644
--- a/gcc/doc/md.texi
+++ b/gcc/doc/md.texi
@@ -1511,7 +1511,7 @@  operand 1 (meaning it must match operand 0), and @samp{dKs} for operand
 2.  The second alternative has @samp{d} (data register) for operand 0,
 @samp{0} for operand 1, and @samp{dmKs} for operand 2.  The @samp{=} and
 @samp{%} in the constraints apply to all the alternatives; their
-meaning is explained in the next section (@pxref{Class Preferences}).
+meaning is explained in a later section (@pxref{Modifiers}).
 
 If all the operands fit any one alternative, the instruction is valid.
 Otherwise, for each alternative, the compiler counts how many instructions