From patchwork Wed Nov 9 10:55:09 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jakub Jelinek X-Patchwork-Id: 17460 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp265840wru; Wed, 9 Nov 2022 02:56:08 -0800 (PST) X-Google-Smtp-Source: AMsMyM4ku/WBrkY3PNETfqVTRLLZR82fD8MWGIr/m2bRH4Cm0zSOjGlEflYeTOXkj0kJH5kXFLtH X-Received: by 2002:a05:6402:366:b0:463:11e8:13cb with SMTP id s6-20020a056402036600b0046311e813cbmr58428545edw.367.1667991368821; Wed, 09 Nov 2022 02:56:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1667991368; cv=none; d=google.com; s=arc-20160816; b=LigebZ0q/RXFXTkzX53llcnG0xvkRWBZHzuNNrg5aD8BzdKNY6RJ7g3SlVXTPUoS3p jCe8QPW7bELSYCvGZyVvwCBw+b1p2OpoAmzGP5Sxuo9ebZbZIyF2n/QpZq3IhagkFj6+ MYoEfYTdsCNnuWWD6mxGR1yxg9hQoxay27UhzZKq7ZOXfpDhCG1+rUsvgQyvIfyGg6qH NBmO/RrJVkwsksg2Qp8EhCsIHszRkf+gSOxdenzC251A4xeCqMZ5lLFw/zNfBnx2nSrJ LPkQijRmztHCN4Dd7q2Kw9OZ+pMJy1TLMvwdlxvXuYUcBYTuZvjO6cb0AFiMDNHjiDCP uUaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-disposition:mime-version:message-id:subject:cc:to:date :dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=0bggSWISsuqjuTmZGhWATEYGVdAOIiVk+vJOUK5BIcM=; b=Hzfm4LqmuSST497jH4M5gapsqM9rpAufeRBlTjDPtMPpYZ9bFhJHQiapY8hY6ztv2F +3D2X09qZtUCr7zhDUW8VEdHgLOMD6ixwxKSjjphGxsf0ZpyNMZ2c4VjhTLhNUrVyjvC iJwJ70YA4Gm16V779BReR+ndQ/9SdBj2BRVvnsKVtX61L2l/T/RHWgVWIDpzECskSjlF VD8Geb1zo9sNaTiUC4TXCIIxtfF3h7R1gIBLfDxm5alTglcXL4HDyXQlINdbLQqe7v0t u+nWbPuFtjQika5JjGXcuFV+V7WQirxai0h4L6jbppcoC+ImMLUPAbgtuhwqCga0TcKY mT3Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=dRi2P14O; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id n15-20020aa7db4f000000b0046159da6233si12532365edt.145.2022.11.09.02.56.08 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Nov 2022 02:56:08 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=dRi2P14O; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DF08C384F031 for ; Wed, 9 Nov 2022 10:56:07 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DF08C384F031 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1667991367; bh=0bggSWISsuqjuTmZGhWATEYGVdAOIiVk+vJOUK5BIcM=; h=Date:To:Cc:Subject:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=dRi2P14OU1OnlcFNw14yk83Pw/sY7iwIl/sU0U81lvvBwUU3RaOTcdzmhqg3INBfy mIfJqJf/q4/hY5zyojW7j4Xu3wvphYscTg3/4QTY0k3xk06oYZyoQWFuJihxl6Zths 5IvFJ0Z+YNj5mSEJtFREWETiSmVA/R4kPpxmn7OU= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 5635F38582AB for ; Wed, 9 Nov 2022 10:55:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5635F38582AB Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-20-BjPbe1qzOn-Ii5xgYwVTrA-1; Wed, 09 Nov 2022 05:55:13 -0500 X-MC-Unique: BjPbe1qzOn-Ii5xgYwVTrA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9A533185A7AC for ; Wed, 9 Nov 2022 10:55:13 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.194.183]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5B10640C6EC3; Wed, 9 Nov 2022 10:55:13 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 2A9AtAkc4104848 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 9 Nov 2022 11:55:10 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 2A9AtA2c4104847; Wed, 9 Nov 2022 11:55:10 +0100 Date: Wed, 9 Nov 2022 11:55:09 +0100 To: Aldy Hernandez Cc: gcc-patches@gcc.gnu.org Subject: [PATCH] Fix up foperator_abs::op1_range [PR107569] Message-ID: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Jakub Jelinek via Gcc-patches From: Jakub Jelinek Reply-To: Jakub Jelinek Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749015717588715461?= X-GMAIL-MSGID: =?utf-8?q?1749015717588715461?= Hi! foperator_abs::op1_range works except for the NaN handling, from: [frange] double [-Inf, 1.79769313486231570814527423731704356798070567525844996599e+308 (0x0.fffffffffffff8p+1024)] lhs it computes r [frange] double [-1.79769313486231570814527423731704356798070567525844996599e+308 (-0x0.fffffffffffff8p+1024), 1.79769313486231570814527423731704356798070567525844996599e+308 (0x0.fffffffffffff8p+1024)] +-NAN which is correct except for the +-NAN part. For r before the final step it makes sure to add -NAN if there is +NAN in the lhs range, but the final r.union_ makes it unconditional +-NAN, because the frange ctor sets +-NAN. So, I think we need to clear it (or have some set variant which says not to set NAN). This patch fixes that, but isn't enough to fix the PR, something in the assumptions handling is still broken (and the PR has other parts). Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2022-11-09 Jakub Jelinek PR tree-optimization/107569 * range-op-float.cc (foperator_abs::op1_range): Clear NaNs from the negatives frange before unioning it into r. Jakub --- gcc/range-op-float.cc.jj 2022-11-06 11:56:27.138137781 +0100 +++ gcc/range-op-float.cc 2022-11-08 18:13:18.026974667 +0100 @@ -1280,9 +1280,10 @@ foperator_abs::op1_range (frange &r, tre return true; // Then add the negative of each pair: // ABS(op1) = [5,20] would yield op1 => [-20,-5][5,20]. - r.union_ (frange (type, - real_value_negate (&positives.upper_bound ()), - real_value_negate (&positives.lower_bound ()))); + frange negatives (type, real_value_negate (&positives.upper_bound ()), + real_value_negate (&positives.lower_bound ())); + negatives.clear_nan (); + r.union_ (negatives); return true; }